diff options
| author | Julie Hockett <juliehockett@google.com> | 2018-01-17 17:41:50 +0000 |
|---|---|---|
| committer | Julie Hockett <juliehockett@google.com> | 2018-01-17 17:41:50 +0000 |
| commit | 996a8c1a660fd6d36ad3334f1aaf3ccfcb7e546b (patch) | |
| tree | 3e88c234f21b7a45a0eeaefde01f8aba29253767 | |
| parent | 6828ee3c1d43be395fc69faf9c664bbc7ff59158 (diff) | |
| download | bcm5719-llvm-996a8c1a660fd6d36ad3334f1aaf3ccfcb7e546b.tar.gz bcm5719-llvm-996a8c1a660fd6d36ad3334f1aaf3ccfcb7e546b.zip | |
[clang-tidy] Fixing Fuchsia overloaded operator warning message
Updating Fuchsia overloaded operator warning message for clarity.
Differential Revision: https://reviews.llvm.org/D42120
llvm-svn: 322692
| -rw-r--r-- | clang-tools-extra/clang-tidy/fuchsia/OverloadedOperatorCheck.cpp | 2 | ||||
| -rw-r--r-- | clang-tools-extra/test/clang-tidy/fuchsia-overloaded-operator.cpp | 10 |
2 files changed, 6 insertions, 6 deletions
diff --git a/clang-tools-extra/clang-tidy/fuchsia/OverloadedOperatorCheck.cpp b/clang-tools-extra/clang-tidy/fuchsia/OverloadedOperatorCheck.cpp index a2914827295..bf0a5069291 100644 --- a/clang-tools-extra/clang-tidy/fuchsia/OverloadedOperatorCheck.cpp +++ b/clang-tools-extra/clang-tidy/fuchsia/OverloadedOperatorCheck.cpp @@ -35,7 +35,7 @@ void OverloadedOperatorCheck::check(const MatchFinder::MatchResult &Result) { SourceLocation Loc = D->getLocStart(); if (Loc.isValid()) - diag(Loc, "cannot overload %0") << D; + diag(Loc, "overloading %0 is disallowed") << D; } } // namespace fuchsia diff --git a/clang-tools-extra/test/clang-tidy/fuchsia-overloaded-operator.cpp b/clang-tools-extra/test/clang-tidy/fuchsia-overloaded-operator.cpp index df1b10604f3..be65a329dc6 100644 --- a/clang-tools-extra/test/clang-tidy/fuchsia-overloaded-operator.cpp +++ b/clang-tools-extra/test/clang-tidy/fuchsia-overloaded-operator.cpp @@ -3,19 +3,19 @@ class A { public: int operator+(int); - // CHECK-MESSAGES: [[@LINE-1]]:3: warning: cannot overload 'operator+' [fuchsia-overloaded-operator] + // CHECK-MESSAGES: [[@LINE-1]]:3: warning: overloading 'operator+' is disallowed }; class B { public: B &operator=(const B &Other); - // CHECK-MESSAGES-NOT: [[@LINE-1]]:3: warning: cannot overload 'operator=' [fuchsia-overloaded-operator] + // CHECK-MESSAGES-NOT: [[@LINE-1]]:3: warning: overloading 'operator=' is disallowed B &operator=(B &&Other); - // CHECK-MESSAGES-NOT: [[@LINE-1]]:3: warning: cannot overload 'operator=' [fuchsia-overloaded-operator] + // CHECK-MESSAGES-NOT: [[@LINE-1]]:3: warning: overloading 'operator=' is disallowed }; A operator-(const A &A1, const A &A2); -// CHECK-MESSAGES: [[@LINE-1]]:1: warning: cannot overload 'operator-' [fuchsia-overloaded-operator] +// CHECK-MESSAGES: [[@LINE-1]]:1: warning: overloading 'operator-' is disallowed void operator delete(void*, void*) throw(); -// CHECK-MESSAGES: [[@LINE-1]]:1: warning: cannot overload 'operator delete' [fuchsia-overloaded-operator] +// CHECK-MESSAGES: [[@LINE-1]]:1: warning: overloading 'operator delete' is disallowed |
