diff options
author | Etienne Bergeron <etienneb@google.com> | 2016-05-12 19:51:18 +0000 |
---|---|---|
committer | Etienne Bergeron <etienneb@google.com> | 2016-05-12 19:51:18 +0000 |
commit | 98de80529a170aa90ffdcb519aeab622573414ad (patch) | |
tree | dd1a11a0756053ef68e3f16e400dd711e4fbaab6 | |
parent | f85452426c2806a9fd9d93269e72071a02fc838d (diff) | |
download | bcm5719-llvm-98de80529a170aa90ffdcb519aeab622573414ad.tar.gz bcm5719-llvm-98de80529a170aa90ffdcb519aeab622573414ad.zip |
[Tooling] Fix broken dependency for shared build
Summary:
There virtual destructor can't be found and cause a compilation error
on a shared build.
To repro: [Release + Shared]
```
-DCMAKE_BUILD_TYPE=Release -DBUILD_SHARED_LIBS=ON
```
Which produce this error:
```
tools/clang/unittests/Tooling/CMakeFiles/ToolingTests.dir/ToolingTest.cpp.o: In function `clang::tooling::newFrontendActionFactory_CreatesFrontendActionFactoryFromType_Test::TestBody()':
ToolingTest.cpp:(.text._ZN5clang7tooling66newFrontendActionFactory_CreatesFrontendActionFactoryFromType_Test8TestBodyEv+0x49): undefined reference to `clang::SyntaxOnlyAction::~SyntaxOnlyAction()'
```
Reviewers: alexfh
Subscribers: cfe-commits
Differential Revision: http://reviews.llvm.org/D20218
llvm-svn: 269334
-rw-r--r-- | clang/include/clang/Frontend/FrontendActions.h | 1 | ||||
-rw-r--r-- | clang/lib/Frontend/FrontendActions.cpp | 3 |
2 files changed, 4 insertions, 0 deletions
diff --git a/clang/include/clang/Frontend/FrontendActions.h b/clang/include/clang/Frontend/FrontendActions.h index 025955dd5ef..60e0ae4875f 100644 --- a/clang/include/clang/Frontend/FrontendActions.h +++ b/clang/include/clang/Frontend/FrontendActions.h @@ -129,6 +129,7 @@ protected: StringRef InFile) override; public: + ~SyntaxOnlyAction() override; bool hasCodeCompletionSupport() const override { return true; } }; diff --git a/clang/lib/Frontend/FrontendActions.cpp b/clang/lib/Frontend/FrontendActions.cpp index c6e6a518a28..79c1df43dd7 100644 --- a/clang/lib/Frontend/FrontendActions.cpp +++ b/clang/lib/Frontend/FrontendActions.cpp @@ -401,6 +401,9 @@ raw_pwrite_stream *GenerateModuleAction::ComputeASTConsumerArguments( return OS; } +SyntaxOnlyAction::~SyntaxOnlyAction() { +} + std::unique_ptr<ASTConsumer> SyntaxOnlyAction::CreateASTConsumer(CompilerInstance &CI, StringRef InFile) { return llvm::make_unique<ASTConsumer>(); |