diff options
| author | Douglas Gregor <dgregor@apple.com> | 2010-06-15 20:26:51 +0000 |
|---|---|---|
| committer | Douglas Gregor <dgregor@apple.com> | 2010-06-15 20:26:51 +0000 |
| commit | 9858ed5b699cea0ad8edcbe0820f3cee5112113e (patch) | |
| tree | cbe74ffafe274c6bffee293443d2446dc3ccdccb | |
| parent | 9eb41c35ceeadd7c3dad6b2db9d60308cd2706e7 (diff) | |
| download | bcm5719-llvm-9858ed5b699cea0ad8edcbe0820f3cee5112113e.tar.gz bcm5719-llvm-9858ed5b699cea0ad8edcbe0820f3cee5112113e.zip | |
Teach code completion not to ignore data members when performing code
completion for expressions.
llvm-svn: 106037
| -rw-r--r-- | clang/lib/Sema/SemaCodeComplete.cpp | 4 | ||||
| -rw-r--r-- | clang/test/Index/code-completion.cpp | 13 |
2 files changed, 15 insertions, 2 deletions
diff --git a/clang/lib/Sema/SemaCodeComplete.cpp b/clang/lib/Sema/SemaCodeComplete.cpp index d40853d724b..cb84ca6deb2 100644 --- a/clang/lib/Sema/SemaCodeComplete.cpp +++ b/clang/lib/Sema/SemaCodeComplete.cpp @@ -790,7 +790,7 @@ bool ResultBuilder::IsOrdinaryName(NamedDecl *ND) const { unsigned IDNS = Decl::IDNS_Ordinary; if (SemaRef.getLangOptions().CPlusPlus) - IDNS |= Decl::IDNS_Tag | Decl::IDNS_Namespace; + IDNS |= Decl::IDNS_Tag | Decl::IDNS_Namespace | Decl::IDNS_Member; else if (SemaRef.getLangOptions().ObjC1 && isa<ObjCIvarDecl>(ND)) return true; @@ -806,7 +806,7 @@ bool ResultBuilder::IsOrdinaryNonTypeName(NamedDecl *ND) const { unsigned IDNS = Decl::IDNS_Ordinary; if (SemaRef.getLangOptions().CPlusPlus) - IDNS |= Decl::IDNS_Tag | Decl::IDNS_Namespace; + IDNS |= Decl::IDNS_Tag | Decl::IDNS_Namespace | Decl::IDNS_Member; else if (SemaRef.getLangOptions().ObjC1 && isa<ObjCIvarDecl>(ND)) return true; diff --git a/clang/test/Index/code-completion.cpp b/clang/test/Index/code-completion.cpp index 670b13f6344..1d50fd3469a 100644 --- a/clang/test/Index/code-completion.cpp +++ b/clang/test/Index/code-completion.cpp @@ -33,6 +33,10 @@ void test_overloaded() { overloaded(Z(), 0); } +Z::operator int() const { + return 0; +} + // CHECK-MEMBER: FieldDecl:{ResultType double}{TypedText member} // CHECK-MEMBER: FieldDecl:{ResultType int}{Text X::}{TypedText member} // CHECK-MEMBER: FieldDecl:{ResultType float}{Text Y::}{TypedText member} @@ -52,3 +56,12 @@ void test_overloaded() { // CHECK-OVERLOAD: NotImplemented:{ResultType int &}{Text overloaded}{LeftParen (}{Text Z z}{Comma , }{CurrentParameter int second}{RightParen )} // CHECK-OVERLOAD: NotImplemented:{ResultType float &}{Text overloaded}{LeftParen (}{Text int i}{Comma , }{CurrentParameter long second}{RightParen )} // CHECK-OVERLOAD: NotImplemented:{ResultType double &}{Text overloaded}{LeftParen (}{Text float f}{Comma , }{CurrentParameter int second}{RightParen )} + +// RUN: c-index-test -code-completion-at=%s:37:10 %s | FileCheck -check-prefix=CHECK-EXPR %s +// CHECK-EXPR: NotImplemented:{TypedText int} (40) +// CHECK-EXPR: NotImplemented:{TypedText long} (40) +// CHECK-EXPR: FieldDecl:{ResultType double}{TypedText member} (10) +// CHECK-EXPR: FieldDecl:{ResultType int}{Text X::}{TypedText member} (5) +// CHECK-EXPR: FieldDecl:{ResultType float}{Text Y::}{TypedText member} (11) +// CHECK-EXPR: FunctionDecl:{ResultType void}{TypedText memfunc}{LeftParen (}{Optional {Placeholder int i}}{RightParen )} (22) + |
