diff options
author | Roger Ferrer Ibanez <rofirrim@gmail.com> | 2019-09-10 08:16:24 +0000 |
---|---|---|
committer | Roger Ferrer Ibanez <rofirrim@gmail.com> | 2019-09-10 08:16:24 +0000 |
commit | 93c4d53b0a5751bbaae747879bcdb4a5413b52fb (patch) | |
tree | 0132325e1c0295b9b79c0ce04cf6f9ea8f4557c2 | |
parent | 2fa2d45963580a95ea97f5b26f102a96c0eeee32 (diff) | |
download | bcm5719-llvm-93c4d53b0a5751bbaae747879bcdb4a5413b52fb.tar.gz bcm5719-llvm-93c4d53b0a5751bbaae747879bcdb4a5413b52fb.zip |
[RISCV] Make -march=rv{32,64}gc the default in RISC-V Linux
This is the logical follow-up of D65634.
Differential Revision: https://reviews.llvm.org/D66003
llvm-svn: 371496
-rw-r--r-- | clang/lib/Driver/ToolChains/Arch/RISCV.cpp | 19 | ||||
-rw-r--r-- | clang/lib/Driver/ToolChains/Arch/RISCV.h | 3 | ||||
-rw-r--r-- | clang/lib/Driver/ToolChains/Clang.cpp | 2 | ||||
-rw-r--r-- | clang/test/Driver/riscv-features.c | 13 |
4 files changed, 27 insertions, 10 deletions
diff --git a/clang/lib/Driver/ToolChains/Arch/RISCV.cpp b/clang/lib/Driver/ToolChains/Arch/RISCV.cpp index 0ba708ef746..624788a5874 100644 --- a/clang/lib/Driver/ToolChains/Arch/RISCV.cpp +++ b/clang/lib/Driver/ToolChains/Arch/RISCV.cpp @@ -12,6 +12,7 @@ #include "clang/Driver/DriverDiagnostic.h" #include "clang/Driver/Options.h" #include "llvm/Option/ArgList.h" +#include "llvm/ADT/Optional.h" #include "llvm/Support/TargetParser.h" #include "llvm/Support/raw_ostream.h" #include "ToolChains/CommonArgs.h" @@ -353,14 +354,18 @@ static bool getArchFeatures(const Driver &D, StringRef MArch, return true; } -void riscv::getRISCVTargetFeatures(const Driver &D, const ArgList &Args, +void riscv::getRISCVTargetFeatures(const Driver &D, const llvm::Triple &Triple, + const ArgList &Args, std::vector<StringRef> &Features) { - if (const Arg *A = Args.getLastArg(options::OPT_march_EQ)) { - StringRef MArch = A->getValue(); - - if (!getArchFeatures(D, MArch, Features, Args)) - return; - } + llvm::Optional<StringRef> MArch; + if (const Arg *A = Args.getLastArg(options::OPT_march_EQ)) + MArch = A->getValue(); + else if (Triple.getOS() == llvm::Triple::Linux) + // RISC-V Linux defaults to rv{32,64}gc. + MArch = Triple.getArch() == llvm::Triple::riscv32 ? "rv32gc" : "rv64gc"; + + if (MArch.hasValue() && !getArchFeatures(D, *MArch, Features, Args)) + return; // -mrelax is default, unless -mno-relax is specified. if (Args.hasFlag(options::OPT_mrelax, options::OPT_mno_relax, true)) diff --git a/clang/lib/Driver/ToolChains/Arch/RISCV.h b/clang/lib/Driver/ToolChains/Arch/RISCV.h index 443526900aa..10eaf3c897b 100644 --- a/clang/lib/Driver/ToolChains/Arch/RISCV.h +++ b/clang/lib/Driver/ToolChains/Arch/RISCV.h @@ -19,7 +19,8 @@ namespace clang { namespace driver { namespace tools { namespace riscv { -void getRISCVTargetFeatures(const Driver &D, const llvm::opt::ArgList &Args, +void getRISCVTargetFeatures(const Driver &D, const llvm::Triple &Triple, + const llvm::opt::ArgList &Args, std::vector<llvm::StringRef> &Features); StringRef getRISCVABI(const llvm::opt::ArgList &Args, const llvm::Triple &Triple); diff --git a/clang/lib/Driver/ToolChains/Clang.cpp b/clang/lib/Driver/ToolChains/Clang.cpp index 92c76d3be34..ce50efc54f9 100644 --- a/clang/lib/Driver/ToolChains/Clang.cpp +++ b/clang/lib/Driver/ToolChains/Clang.cpp @@ -336,7 +336,7 @@ static void getTargetFeatures(const ToolChain &TC, const llvm::Triple &Triple, break; case llvm::Triple::riscv32: case llvm::Triple::riscv64: - riscv::getRISCVTargetFeatures(D, Args, Features); + riscv::getRISCVTargetFeatures(D, Triple, Args, Features); break; case llvm::Triple::systemz: systemz::getSystemZTargetFeatures(Args, Features); diff --git a/clang/test/Driver/riscv-features.c b/clang/test/Driver/riscv-features.c index 44fb59b2f92..2f2ae51e471 100644 --- a/clang/test/Driver/riscv-features.c +++ b/clang/test/Driver/riscv-features.c @@ -18,4 +18,15 @@ // SAVE-RESTORE: warning: the clang compiler does not support '-msave-restore' // NO-SAVE-RESTORE-NOT: warning: the clang compiler does not support -// DEFAULT-NOT: warning: the clang compiler does not support
\ No newline at end of file +// DEFAULT-NOT: warning: the clang compiler does not support + +// RUN: %clang -target riscv32-linux -### %s -fsyntax-only 2>&1 \ +// RUN: | FileCheck %s -check-prefix=DEFAULT-LINUX +// RUN: %clang -target riscv64-linux -### %s -fsyntax-only 2>&1 \ +// RUN: | FileCheck %s -check-prefix=DEFAULT-LINUX + +// DEFAULT-LINUX: "-target-feature" "+m" +// DEFAULT-LINUX-SAME: "-target-feature" "+a" +// DEFAULT-LINUX-SAME: "-target-feature" "+f" +// DEFAULT-LINUX-SAME: "-target-feature" "+d" +// DEFAULT-LINUX-SAME: "-target-feature" "+c" |