diff options
| author | Amara Emerson <aemerson@apple.com> | 2019-04-09 21:22:37 +0000 |
|---|---|---|
| committer | Amara Emerson <aemerson@apple.com> | 2019-04-09 21:22:37 +0000 |
| commit | 92d74f19cf4773229454a9314030587b329bc275 (patch) | |
| tree | 3e35f30525c71ff787af2b7a2d4476bb53d12351 | |
| parent | 2b523f81625b455fd3c0676156f109fa5f83c023 (diff) | |
| download | bcm5719-llvm-92d74f19cf4773229454a9314030587b329bc275.tar.gz bcm5719-llvm-92d74f19cf4773229454a9314030587b329bc275.zip | |
[AArch64][GlobalISel] Add legalization for some vector G_SHL and G_ASHR.
This is needed for some future support for vector ICMP.
Differential Revision: https://reviews.llvm.org/D60433
llvm-svn: 358033
4 files changed, 44 insertions, 5 deletions
diff --git a/llvm/include/llvm/CodeGen/GlobalISel/LegalizerInfo.h b/llvm/include/llvm/CodeGen/GlobalISel/LegalizerInfo.h index 417aa402f37..2047e1dadd2 100644 --- a/llvm/include/llvm/CodeGen/GlobalISel/LegalizerInfo.h +++ b/llvm/include/llvm/CodeGen/GlobalISel/LegalizerInfo.h @@ -494,6 +494,12 @@ public: Types2); } + LegalizeRuleSet &alwaysLegal() { + using namespace LegalizeMutations; + markAllTypeIdxsAsCovered(); + return actionIf(LegalizeAction::Legal, always); + } + /// The instruction is lowered. LegalizeRuleSet &lower() { using namespace LegalizeMutations; diff --git a/llvm/lib/Target/AArch64/AArch64LegalizerInfo.cpp b/llvm/lib/Target/AArch64/AArch64LegalizerInfo.cpp index 256a276bb45..eb6dfd84335 100644 --- a/llvm/lib/Target/AArch64/AArch64LegalizerInfo.cpp +++ b/llvm/lib/Target/AArch64/AArch64LegalizerInfo.cpp @@ -105,10 +105,10 @@ AArch64LegalizerInfo::AArch64LegalizerInfo(const AArch64Subtarget &ST) { .widenScalarToNextPow2(0); getActionDefinitionsBuilder({G_LSHR, G_ASHR}) - .legalFor({{s32, s32}, {s64, s64}}) - .clampScalar(1, s32, s64) - .clampScalar(0, s32, s64) - .minScalarSameAs(1, 0); + .legalFor({{s32, s32}, {s64, s64}, {v2s32, v2s32}, {v4s32, v4s32}}) + .clampScalar(1, s32, s64) + .clampScalar(0, s32, s64) + .minScalarSameAs(1, 0); getActionDefinitionsBuilder({G_SREM, G_UREM}) .lowerFor({s1, s8, s16, s32, s64}); @@ -273,6 +273,8 @@ AArch64LegalizerInfo::AArch64LegalizerInfo(const AArch64Subtarget &ST) { getActionDefinitionsBuilder({G_ZEXT, G_SEXT, G_ANYEXT}) .legalForCartesianProduct({s8, s16, s32, s64}, {s1, s8, s16, s32}); + getActionDefinitionsBuilder(G_TRUNC).alwaysLegal(); + // FP conversions getActionDefinitionsBuilder(G_FPTRUNC).legalFor( {{s16, s32}, {s16, s64}, {s32, s64}, {v4s16, v4s32}, {v2s32, v2s64}}); diff --git a/llvm/test/CodeGen/AArch64/GlobalISel/legalize-shift.mir b/llvm/test/CodeGen/AArch64/GlobalISel/legalize-shift.mir index 3fb6a4f6e8a..7bab4bf0bfd 100644 --- a/llvm/test/CodeGen/AArch64/GlobalISel/legalize-shift.mir +++ b/llvm/test/CodeGen/AArch64/GlobalISel/legalize-shift.mir @@ -202,3 +202,34 @@ body: | $q0 = COPY %2 ... + +--- +name: test_ashr_v2i32 +body: | + bb.0: + ; CHECK-LABEL: name: test_ashr_v2i32 + ; CHECK: [[COPY:%[0-9]+]]:_(<2 x s32>) = COPY $d0 + ; CHECK: [[COPY1:%[0-9]+]]:_(<2 x s32>) = COPY $d1 + ; CHECK: [[ASHR:%[0-9]+]]:_(<2 x s32>) = G_ASHR [[COPY]], [[COPY1]](<2 x s32>) + ; CHECK: $d0 = COPY [[ASHR]](<2 x s32>) + %0:_(<2 x s32>) = COPY $d0 + %1:_(<2 x s32>) = COPY $d1 + %2:_(<2 x s32>) = G_ASHR %0, %1 + $d0 = COPY %2 + +... +--- +name: test_ashr_v4i32 +body: | + bb.0: + ; CHECK-LABEL: name: test_ashr_v4i32 + ; CHECK: [[COPY:%[0-9]+]]:_(<4 x s32>) = COPY $q0 + ; CHECK: [[COPY1:%[0-9]+]]:_(<4 x s32>) = COPY $q1 + ; CHECK: [[ASHR:%[0-9]+]]:_(<4 x s32>) = G_ASHR [[COPY]], [[COPY1]](<4 x s32>) + ; CHECK: $q0 = COPY [[ASHR]](<4 x s32>) + %0:_(<4 x s32>) = COPY $q0 + %1:_(<4 x s32>) = COPY $q1 + %2:_(<4 x s32>) = G_ASHR %0, %1 + $q0 = COPY %2 + +... diff --git a/llvm/test/CodeGen/AArch64/GlobalISel/legalizer-info-validation.mir b/llvm/test/CodeGen/AArch64/GlobalISel/legalizer-info-validation.mir index 633a0786778..4fbcf801cd2 100644 --- a/llvm/test/CodeGen/AArch64/GlobalISel/legalizer-info-validation.mir +++ b/llvm/test/CodeGen/AArch64/GlobalISel/legalizer-info-validation.mir @@ -160,7 +160,7 @@ # DEBUG: .. the first uncovered type index: 2, OK # # DEBUG-NEXT: G_TRUNC (opcode {{[0-9]+}}): 2 type indices -# DEBUG: .. type index coverage check SKIPPED: no rules defined +# DEBUG: .. type index coverage check SKIPPED: user-defined predicate detected # # DEBUG-NEXT: G_CONSTANT (opcode {{[0-9]+}}): 1 type index # DEBUG: .. the first uncovered type index: 1, OK |

