summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDavide Italiano <davide@freebsd.org>2015-07-25 01:19:32 +0000
committerDavide Italiano <davide@freebsd.org>2015-07-25 01:19:32 +0000
commit922b702bf9d4a27cde8fe08f9bb694b8ca8d94ac (patch)
treed935c5f5fea7cfcca3e824ba4433f115fc027143
parent28df04211cd50a0da0ef984e6163a32e3e38aa2b (diff)
downloadbcm5719-llvm-922b702bf9d4a27cde8fe08f9bb694b8ca8d94ac.tar.gz
bcm5719-llvm-922b702bf9d4a27cde8fe08f9bb694b8ca8d94ac.zip
[SemaTemplate] Detect instantiation of unparsed exceptions.
This fixes the clang crash reported in PR24000. Differential Revision: http://reviews.llvm.org/D11341 llvm-svn: 243196
-rw-r--r--clang/lib/Sema/SemaExceptionSpec.cpp8
-rw-r--r--clang/test/SemaTemplate/crash-unparsed-exception.cpp17
2 files changed, 24 insertions, 1 deletions
diff --git a/clang/lib/Sema/SemaExceptionSpec.cpp b/clang/lib/Sema/SemaExceptionSpec.cpp
index 8a9372336e8..ec3d9fd82fe 100644
--- a/clang/lib/Sema/SemaExceptionSpec.cpp
+++ b/clang/lib/Sema/SemaExceptionSpec.cpp
@@ -161,7 +161,13 @@ Sema::ResolveExceptionSpec(SourceLocation Loc, const FunctionProtoType *FPT) {
else
InstantiateExceptionSpec(Loc, SourceDecl);
- return SourceDecl->getType()->castAs<FunctionProtoType>();
+ const FunctionProtoType *Proto =
+ SourceDecl->getType()->castAs<FunctionProtoType>();
+ if (Proto->getExceptionSpecType() == clang::EST_Unparsed) {
+ Diag(Loc, diag::err_exception_spec_not_parsed);
+ Proto = nullptr;
+ }
+ return Proto;
}
void
diff --git a/clang/test/SemaTemplate/crash-unparsed-exception.cpp b/clang/test/SemaTemplate/crash-unparsed-exception.cpp
new file mode 100644
index 00000000000..1226b35deb7
--- /dev/null
+++ b/clang/test/SemaTemplate/crash-unparsed-exception.cpp
@@ -0,0 +1,17 @@
+// RUN: %clang_cc1 -fsyntax-only -std=c++11 -verify -fcxx-exceptions -fexceptions %s
+
+struct A {
+ virtual ~A();
+};
+template <class>
+struct B {};
+struct C {
+ template <typename>
+ struct D {
+ ~D() throw();
+ };
+ struct E : A {
+ D<int> d; //expected-error{{exception specification is not available until end of class definition}}
+ };
+ B<int> b; //expected-note{{in instantiation of template class 'B<int>' requested here}}
+};
OpenPOWER on IntegriCloud