diff options
author | Sjoerd Meijer <sjoerd.meijer@arm.com> | 2019-11-21 14:03:28 +0000 |
---|---|---|
committer | Sjoerd Meijer <sjoerd.meijer@arm.com> | 2019-11-21 14:06:10 +0000 |
commit | 901cd3b3f62d0c700e5d2c3f97eff97d634bec5e (patch) | |
tree | 4fa4571bbafc1e9fbfa4bd4bbbaf3ebe2b03a5fc | |
parent | 8cf8ec40a1fee9706237d30385e78e1de214d8f7 (diff) | |
download | bcm5719-llvm-901cd3b3f62d0c700e5d2c3f97eff97d634bec5e.tar.gz bcm5719-llvm-901cd3b3f62d0c700e5d2c3f97eff97d634bec5e.zip |
[LV] PreferPredicateOverEpilog respecting option
Follow-up of cb47b8783: don't query TTI->preferPredicateOverEpilogue when
option -prefer-predicate-over-epilog is set to false, i.e. when we prefer not
to predicate the loop.
Differential Revision: https://reviews.llvm.org/D70382
-rw-r--r-- | llvm/lib/Transforms/Vectorize/LoopVectorize.cpp | 6 | ||||
-rw-r--r-- | llvm/test/Transforms/LoopVectorize/ARM/prefer-tail-loop-folding.ll | 18 |
2 files changed, 23 insertions, 1 deletions
diff --git a/llvm/lib/Transforms/Vectorize/LoopVectorize.cpp b/llvm/lib/Transforms/Vectorize/LoopVectorize.cpp index af05683273d..fcd8b05b883 100644 --- a/llvm/lib/Transforms/Vectorize/LoopVectorize.cpp +++ b/llvm/lib/Transforms/Vectorize/LoopVectorize.cpp @@ -7429,6 +7429,9 @@ getScalarEpilogueLowering(Function *F, Loop *L, LoopVectorizeHints &Hints, ScalarEvolution *SE, DominatorTree *DT, const LoopAccessInfo *LAI) { ScalarEpilogueLowering SEL = CM_ScalarEpilogueAllowed; + bool PredicateOptDisabled = PreferPredicateOverEpilog.getNumOccurrences() && + !PreferPredicateOverEpilog; + if (Hints.getForce() != LoopVectorizeHints::FK_Enabled && (F->hasOptSize() || llvm::shouldOptimizeForSize(L->getHeader(), PSI, BFI))) @@ -7436,7 +7439,8 @@ getScalarEpilogueLowering(Function *F, Loop *L, LoopVectorizeHints &Hints, else if (PreferPredicateOverEpilog || Hints.getPredicate() == LoopVectorizeHints::FK_Enabled || (TTI->preferPredicateOverEpilogue(L, LI, *SE, *AC, TLI, DT, LAI) && - Hints.getPredicate() != LoopVectorizeHints::FK_Disabled)) + Hints.getPredicate() != LoopVectorizeHints::FK_Disabled && + !PredicateOptDisabled)) SEL = CM_ScalarEpilogueNotNeededUsePredicate; return SEL; diff --git a/llvm/test/Transforms/LoopVectorize/ARM/prefer-tail-loop-folding.ll b/llvm/test/Transforms/LoopVectorize/ARM/prefer-tail-loop-folding.ll index 2b8d9314ba8..ac2b65036fe 100644 --- a/llvm/test/Transforms/LoopVectorize/ARM/prefer-tail-loop-folding.ll +++ b/llvm/test/Transforms/LoopVectorize/ARM/prefer-tail-loop-folding.ll @@ -30,6 +30,18 @@ ; RUN: -enable-arm-maskedldst=true -S < %s | \ ; RUN: FileCheck %s -check-prefixes=CHECK,PREFER-FOLDING +; RUN: opt -mtriple=thumbv8.1m.main-arm-eabihf -mattr=+mve.fp \ +; RUN: -prefer-predicate-over-epilog=false \ +; RUN: -disable-mve-tail-predication=false -loop-vectorize \ +; RUN: -enable-arm-maskedldst=true -S < %s | \ +; RUN: FileCheck %s -check-prefixes=CHECK,NO-FOLDING + +; RUN: opt -mtriple=thumbv8.1m.main-arm-eabihf -mattr=+mve.fp \ +; RUN: -prefer-predicate-over-epilog=true \ +; RUN: -disable-mve-tail-predication=false -loop-vectorize \ +; RUN: -enable-arm-maskedldst=true -S < %s | \ +; RUN: FileCheck %s -check-prefixes=CHECK,FOLDING-OPT + define void @prefer_folding(i32* noalias nocapture %A, i32* noalias nocapture readonly %B, i32* noalias nocapture readonly %C) #0 { ; CHECK-LABEL: prefer_folding( ; PREFER-FOLDING: vector.body: @@ -186,6 +198,12 @@ define void @narrowing_load_not_allowed(i8* noalias nocapture %A, i8* noalias no ; PREFER-FOLDING-NOT: llvm.masked.load ; PREFER-FOLDING-NOT: llvm.masked.store ; PREFER-FOLDING: br i1 %{{.*}}, label %{{.*}}, label %vector.body + +; FOLDING-OPT: vector.body: +; FOLDING-OPT call <8 x i16> @llvm.masked.load.v8i16.p0v8i16 +; FOLDING-OPT call <8 x i8> @llvm.masked.load.v8i8.p0v8i8 +; FOLDING-OPT call void @llvm.masked.store.v8i8.p0v8i8 +; FOLDING-OPT: br i1 %{{.*}}, label %{{.*}}, label %vector.body entry: br label %for.body |