diff options
| author | Mitch Phillips <mitchphillips@outlook.com> | 2019-06-17 22:35:32 +0000 |
|---|---|---|
| committer | Mitch Phillips <mitchphillips@outlook.com> | 2019-06-17 22:35:32 +0000 |
| commit | 8fbb88fbff5e0fef1418650f2d3f716598344d97 (patch) | |
| tree | e6d4d497522b56326d31c07bb496cb18f1cc4a33 | |
| parent | ca42687d62a81fb09fe0187e5f2788077eb6a841 (diff) | |
| download | bcm5719-llvm-8fbb88fbff5e0fef1418650f2d3f716598344d97.tar.gz bcm5719-llvm-8fbb88fbff5e0fef1418650f2d3f716598344d97.zip | |
[GWP-ASan] Disable GWP-ASan on Android for now.
Summary:
Temporarily disable GWP-ASan for android until the bugs at:
http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-android/builds/87
... can be fixed. See comments for the full bug trace.
Reviewers: eugenis
Reviewed By: eugenis
Subscribers: srhines, kubamracek, mgorny, cryptoad, jfb, #sanitizers, llvm-commits
Tags: #sanitizers, #llvm
Differential Revision: https://reviews.llvm.org/D63460
llvm-svn: 363624
| -rw-r--r-- | compiler-rt/cmake/config-ix.cmake | 4 | ||||
| -rw-r--r-- | compiler-rt/lib/gwp_asan/CMakeLists.txt | 3 |
2 files changed, 5 insertions, 2 deletions
diff --git a/compiler-rt/cmake/config-ix.cmake b/compiler-rt/cmake/config-ix.cmake index 49a22a92227..ce77cdc8d54 100644 --- a/compiler-rt/cmake/config-ix.cmake +++ b/compiler-rt/cmake/config-ix.cmake @@ -687,8 +687,10 @@ endif() # Note: Fuchsia and Windows are not currently supported by GWP-ASan. Support # is planned for these platforms. Darwin is also not supported due to TLS # calling malloc on first use. +# TODO(hctim): Enable this on Android again. Looks like it's causing a SIGSEGV +# for Scudo and GWP-ASan, further testing needed. if (COMPILER_RT_HAS_SANITIZER_COMMON AND GWP_ASAN_SUPPORTED_ARCH AND - OS_NAME MATCHES "Android|Linux") + OS_NAME MATCHES "Linux") set(COMPILER_RT_HAS_GWP_ASAN TRUE) else() set(COMPILER_RT_HAS_GWP_ASAN FALSE) diff --git a/compiler-rt/lib/gwp_asan/CMakeLists.txt b/compiler-rt/lib/gwp_asan/CMakeLists.txt index 53f5152551c..33db1109bf6 100644 --- a/compiler-rt/lib/gwp_asan/CMakeLists.txt +++ b/compiler-rt/lib/gwp_asan/CMakeLists.txt @@ -21,7 +21,8 @@ set(GWP_ASAN_HEADERS # Ensure that GWP-ASan meets the delegated requirements of some supporting # allocators. Some supporting allocators (e.g. scudo standalone) cannot use any # parts of the C++ standard library. -set(GWP_ASAN_CFLAGS -fno-rtti -fno-exceptions -fPIC -nostdinc++ -pthread) +set(GWP_ASAN_CFLAGS -fno-rtti -fno-exceptions -nostdinc++ -pthread) +append_list_if(COMPILER_RT_HAS_FPIC_FLAG -fPIC GWP_ASAN_CFLAGS) # Remove -stdlib= which is unused when passing -nostdinc++. string(REGEX REPLACE "-stdlib=[a-zA-Z+]*" "" CMAKE_CXX_FLAGS ${CMAKE_CXX_FLAGS}) |
