diff options
| author | Benjamin Kramer <benny.kra@googlemail.com> | 2018-09-11 12:19:45 +0000 |
|---|---|---|
| committer | Benjamin Kramer <benny.kra@googlemail.com> | 2018-09-11 12:19:45 +0000 |
| commit | 8f776db7ff8898959312b234d5d6671f3e2ec61c (patch) | |
| tree | e6608aaf0615f04ee6e6de6ae24d4bb00999f1cf | |
| parent | db7ee7660a8efce83ad34a3b211f5d3e624a3afd (diff) | |
| download | bcm5719-llvm-8f776db7ff8898959312b234d5d6671f3e2ec61c.tar.gz bcm5719-llvm-8f776db7ff8898959312b234d5d6671f3e2ec61c.zip | |
[clang-tidy] Insert absl::StrAppend when replacing StrCat.
There might be no using decl for StrAppend around, inserting the
qualified name is less likely to break things.
llvm-svn: 341929
| -rw-r--r-- | clang-tools-extra/clang-tidy/abseil/StrCatAppendCheck.cpp | 2 | ||||
| -rw-r--r-- | clang-tools-extra/test/clang-tidy/abseil-str-cat-append.cpp | 8 |
2 files changed, 5 insertions, 5 deletions
diff --git a/clang-tools-extra/clang-tidy/abseil/StrCatAppendCheck.cpp b/clang-tools-extra/clang-tidy/abseil/StrCatAppendCheck.cpp index 25b9d17e833..49072371542 100644 --- a/clang-tools-extra/clang-tidy/abseil/StrCatAppendCheck.cpp +++ b/clang-tools-extra/clang-tidy/abseil/StrCatAppendCheck.cpp @@ -93,7 +93,7 @@ void StrCatAppendCheck::check(const MatchFinder::MatchResult &Result) { << FixItHint::CreateReplacement( CharSourceRange::getTokenRange(Op->getBeginLoc(), Call->getCallee()->getEndLoc()), - "StrAppend") + "absl::StrAppend") << FixItHint::CreateInsertion(Call->getArg(0)->getBeginLoc(), "&"); } diff --git a/clang-tools-extra/test/clang-tidy/abseil-str-cat-append.cpp b/clang-tools-extra/test/clang-tidy/abseil-str-cat-append.cpp index 9a12733880a..5ecb284df4b 100644 --- a/clang-tools-extra/test/clang-tidy/abseil-str-cat-append.cpp +++ b/clang-tools-extra/test/clang-tidy/abseil-str-cat-append.cpp @@ -97,7 +97,7 @@ void Bar() { // CHECK-MESSAGES: [[@LINE-1]]:3: warning: call to 'absl::StrCat' has no effect A = StrCat(A, B); // CHECK-MESSAGES: [[@LINE-1]]:3: warning: call 'absl::StrAppend' instead of 'absl::StrCat' when appending to a string to avoid a performance penalty -// CHECK-FIXES: {{^}} StrAppend(&A, B); +// CHECK-FIXES: {{^}} absl::StrAppend(&A, B); B = StrCat(A, B); #define M(X) X = StrCat(X, A) @@ -117,13 +117,13 @@ void OutsideAbsl() { std::string A, B; A = absl::StrCat(A, B); // CHECK-MESSAGES: [[@LINE-1]]:3: warning: call 'absl::StrAppend' instead of 'absl::StrCat' when appending to a string to avoid a performance penalty -// CHECK-FIXES: {{^}} StrAppend(&A, B); +// CHECK-FIXES: {{^}} absl::StrAppend(&A, B); } -void OutisdeUsingAbsl() { +void OutsideUsingAbsl() { std::string A, B; using absl::StrCat; A = StrCat(A, B); // CHECK-MESSAGES: [[@LINE-1]]:3: warning: call 'absl::StrAppend' instead of 'absl::StrCat' when appending to a string to avoid a performance penalty -// CHECK-FIXES: {{^}} StrAppend(&A, B); +// CHECK-FIXES: {{^}} absl::StrAppend(&A, B); } |

