summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSam Clegg <sbc@chromium.org>2019-06-04 16:35:23 +0000
committerSam Clegg <sbc@chromium.org>2019-06-04 16:35:23 +0000
commit8e8ddaa38ff691b4dd21a93bcc348a383f7ffcac (patch)
treeee43d7184dc6924f2d9f681ad1ba8c09869d9abd
parent48566aaab461e014dc8350c2ddd6012e34ffe434 (diff)
downloadbcm5719-llvm-8e8ddaa38ff691b4dd21a93bcc348a383f7ffcac.tar.gz
bcm5719-llvm-8e8ddaa38ff691b4dd21a93bcc348a383f7ffcac.zip
[WebAssembly] Add comment as follow-up to rL362276. NFC.
Subscribers: dschuff, jgravelle-google, aheejin, sunfish, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D62824 llvm-svn: 362522
-rw-r--r--lld/wasm/SymbolTable.cpp4
1 files changed, 3 insertions, 1 deletions
diff --git a/lld/wasm/SymbolTable.cpp b/lld/wasm/SymbolTable.cpp
index d10952797d5..c4a460f3ad7 100644
--- a/lld/wasm/SymbolTable.cpp
+++ b/lld/wasm/SymbolTable.cpp
@@ -199,10 +199,12 @@ DefinedFunction *SymbolTable::addSyntheticFunction(StringRef Name,
Flags, nullptr, Function);
}
+// Adds an optional, linker generated, data symbols. The symbol will only be
+// added if there is an undefine reference to it, or if it is explictly exported
+// via the --export flag. Otherwise we don't add the symbol and return nullptr.
DefinedData *SymbolTable::addOptionalDataSymbol(StringRef Name, uint32_t Value,
uint32_t Flags) {
Symbol *S = find(Name);
- // Enable --export of optional symbols
if (!S && (Config->ExportAll || Config->ExportedSymbols.count(Name) != 0))
S = insertName(Name).first;
else if (!S || S->isDefined())
OpenPOWER on IntegriCloud