diff options
| author | Jakob Stoklund Olesen <stoklund@2pi.dk> | 2012-03-28 20:11:44 +0000 |
|---|---|---|
| committer | Jakob Stoklund Olesen <stoklund@2pi.dk> | 2012-03-28 20:11:44 +0000 |
| commit | 8cb97523c6f44bcf24f35a86b4de56d077567d1e (patch) | |
| tree | 56c780d7727595a2e67c93e899b8a2aab6e0d949 | |
| parent | 8e58c90f514ce7c333a957455d262f40e5cd7904 (diff) | |
| download | bcm5719-llvm-8cb97523c6f44bcf24f35a86b4de56d077567d1e.tar.gz bcm5719-llvm-8cb97523c6f44bcf24f35a86b4de56d077567d1e.zip | |
Revert r153516: "Invalidate liveness in Thumb2ITBlockPass."
Revert r153519: "ARMLoadStoreOptimizer invalidates register liveness."
These patches caused miscompilations in povray by turning off branch
folding's updating of live-in lists.
It turns out the the late scheduler depends on the live-in lists, even
if it doesn't need correct kill flags.
<rdar://problem/11139228>
llvm-svn: 153593
| -rw-r--r-- | llvm/lib/Target/ARM/ARMLoadStoreOptimizer.cpp | 4 | ||||
| -rw-r--r-- | llvm/lib/Target/ARM/Thumb2ITBlockPass.cpp | 4 |
2 files changed, 0 insertions, 8 deletions
diff --git a/llvm/lib/Target/ARM/ARMLoadStoreOptimizer.cpp b/llvm/lib/Target/ARM/ARMLoadStoreOptimizer.cpp index 5b729a642b7..51dfa65da62 100644 --- a/llvm/lib/Target/ARM/ARMLoadStoreOptimizer.cpp +++ b/llvm/lib/Target/ARM/ARMLoadStoreOptimizer.cpp @@ -1411,10 +1411,6 @@ bool ARMLoadStoreOpt::runOnMachineFunction(MachineFunction &Fn) { } delete RS; - - // Kill flags aren't updated accurately by this pass. - Fn.getRegInfo().invalidateLiveness(); - return Modified; } diff --git a/llvm/lib/Target/ARM/Thumb2ITBlockPass.cpp b/llvm/lib/Target/ARM/Thumb2ITBlockPass.cpp index e2166ffc322..ecb4c2f0e5d 100644 --- a/llvm/lib/Target/ARM/Thumb2ITBlockPass.cpp +++ b/llvm/lib/Target/ARM/Thumb2ITBlockPass.cpp @@ -15,7 +15,6 @@ #include "llvm/CodeGen/MachineInstrBuilder.h" #include "llvm/CodeGen/MachineInstrBundle.h" #include "llvm/CodeGen/MachineFunctionPass.h" -#include "llvm/CodeGen/MachineRegisterInfo.h" #include "llvm/ADT/SmallSet.h" #include "llvm/ADT/Statistic.h" using namespace llvm; @@ -259,9 +258,6 @@ bool Thumb2ITBlockPass::runOnMachineFunction(MachineFunction &Fn) { if (!AFI->isThumbFunction()) return false; - // IT block insertion invalidates accurate register liveness. - Fn.getRegInfo().invalidateLiveness(); - bool Modified = false; for (MachineFunction::iterator MFI = Fn.begin(), E = Fn.end(); MFI != E; ) { MachineBasicBlock &MBB = *MFI; |

