diff options
author | Zachary Turner <zturner@google.com> | 2016-09-07 19:41:19 +0000 |
---|---|---|
committer | Zachary Turner <zturner@google.com> | 2016-09-07 19:41:19 +0000 |
commit | 8c9a7d7c41b07dce6e60feb7e0c7d7633ed7a2c5 (patch) | |
tree | a8b3f0f42d884ea16d79c4029ee679bc4d2c93d6 | |
parent | b96ebe6a1ab251f2141173cf3820c23cd72a5547 (diff) | |
download | bcm5719-llvm-8c9a7d7c41b07dce6e60feb7e0c7d7633ed7a2c5.tar.gz bcm5719-llvm-8c9a7d7c41b07dce6e60feb7e0c7d7633ed7a2c5.zip |
Fix a few oversights in the clang-tidy VS plugin.
Over-zealous cleanup of using statements removed some that were
actually needed. Also cleaned up a few warnings.
llvm-svn: 280844
4 files changed, 2 insertions, 9 deletions
diff --git a/clang-tools-extra/clang-tidy-vs/ClangTidy/CheckDatabase.cs b/clang-tools-extra/clang-tidy-vs/ClangTidy/CheckDatabase.cs index 3cf8efca2df..6b76688873e 100644 --- a/clang-tools-extra/clang-tidy-vs/ClangTidy/CheckDatabase.cs +++ b/clang-tools-extra/clang-tidy-vs/ClangTidy/CheckDatabase.cs @@ -50,7 +50,7 @@ namespace LLVM.ClangTidy foreach (var Check in Checks_)
{
if (Names.Contains(Check.Name))
- throw new ArgumentException(String.Format("Check {0} exists more than once!", Check.Name));
+ continue;
Names.Add(Check.Name);
}
}
diff --git a/clang-tools-extra/clang-tidy-vs/ClangTidy/CheckTree.cs b/clang-tools-extra/clang-tidy-vs/ClangTidy/CheckTree.cs index ab746fe32b7..f3e25830b17 100644 --- a/clang-tools-extra/clang-tidy-vs/ClangTidy/CheckTree.cs +++ b/clang-tools-extra/clang-tidy-vs/ClangTidy/CheckTree.cs @@ -1,6 +1,7 @@ using System;
using System.Collections.Generic;
using System.ComponentModel;
+using System.Linq;
using System.Text;
namespace LLVM.ClangTidy
diff --git a/clang-tools-extra/clang-tidy-vs/ClangTidy/ClangTidyProperties.cs b/clang-tools-extra/clang-tidy-vs/ClangTidy/ClangTidyProperties.cs index ac83121706b..c6597c1924c 100644 --- a/clang-tools-extra/clang-tidy-vs/ClangTidy/ClangTidyProperties.cs +++ b/clang-tools-extra/clang-tidy-vs/ClangTidy/ClangTidyProperties.cs @@ -40,7 +40,6 @@ namespace LLVM.ClangTidy static ClangTidyProperties()
{
RootProperties_ = new ClangTidyProperties(null);
- PropertyDescriptor D;
}
public static ClangTidyProperties RootProperties
diff --git a/clang-tools-extra/clang-tidy-vs/ClangTidy/ClangTidyPropertyGrid.cs b/clang-tools-extra/clang-tidy-vs/ClangTidy/ClangTidyPropertyGrid.cs index c6d93708f79..20c8a8fff5e 100644 --- a/clang-tools-extra/clang-tidy-vs/ClangTidy/ClangTidyPropertyGrid.cs +++ b/clang-tools-extra/clang-tidy-vs/ClangTidy/ClangTidyPropertyGrid.cs @@ -42,13 +42,6 @@ namespace LLVM.ClangTidy /// </summary>
List<KeyValuePair<string, ClangTidyProperties>> PropertyChain_ = null;
- /// <summary>
- /// A tree representing all the checks that the extension knows about, used
- /// when serializing a file to intelligently determine when to use wildcard
- /// include / exclude rules.
- /// </summary>
- CheckTree Checks_;
-
public ClangTidyPropertyGrid()
{
InitializeComponent();
|