diff options
| author | Douglas Katzman <dougk@google.com> | 2015-08-05 18:03:47 +0000 |
|---|---|---|
| committer | Douglas Katzman <dougk@google.com> | 2015-08-05 18:03:47 +0000 |
| commit | 8b50e0175f99bef03c0f6b7b6f014f657a6bd5a1 (patch) | |
| tree | bc78f03fb57d0fc2190324c83344ad91ccd28789 | |
| parent | 405e4f90519fb6c11246ed2698b6049682601227 (diff) | |
| download | bcm5719-llvm-8b50e0175f99bef03c0f6b7b6f014f657a6bd5a1.tar.gz bcm5719-llvm-8b50e0175f99bef03c0f6b7b6f014f657a6bd5a1.zip | |
Claim arguments that belong to 'clang_ignored_gcc_optimization_f_Group'
This seems preferable to printing two warnings per unsupported option-
one warning about not supporting it, and one about not using it.
It also makes the '-Wno-' option do what you mean.
Differential Revision: http://reviews.llvm.org/D11766
llvm-svn: 244079
| -rw-r--r-- | clang/lib/Driver/Tools.cpp | 1 | ||||
| -rw-r--r-- | clang/test/Driver/clang_f_opts.c | 13 |
2 files changed, 14 insertions, 0 deletions
diff --git a/clang/lib/Driver/Tools.cpp b/clang/lib/Driver/Tools.cpp index 2135b77f5e6..043d9958b3c 100644 --- a/clang/lib/Driver/Tools.cpp +++ b/clang/lib/Driver/Tools.cpp @@ -3848,6 +3848,7 @@ void Clang::ConstructJob(Compilation &C, const JobAction &JA, for (const Arg *A : Args.filtered(options::OPT_clang_ignored_gcc_optimization_f_Group)) { D.Diag(diag::warn_ignored_gcc_optimization) << A->getAsString(Args); + A->claim(); } claimNoWarnArgs(Args); diff --git a/clang/test/Driver/clang_f_opts.c b/clang/test/Driver/clang_f_opts.c index 003430174b6..4e95266c2e7 100644 --- a/clang/test/Driver/clang_f_opts.c +++ b/clang/test/Driver/clang_f_opts.c @@ -412,6 +412,19 @@ // CHECK-NO-WARNING1-NOT: optimization flag '-finline-limit=1000' is not supported // CHECK-NO-WARNING2-NOT: optimization flag '-finline-limit' is not supported +// Test that an ignored optimization argument only prints 1 warning, +// not both a warning about not claiming the arg, *and* about not supporting +// the arg; and that adding -Wno-ignored-optimization silences the warning. +// +// RUN: %clang -### -fprofile-correction %s 2>&1 \ +// RUN: | FileCheck --check-prefix=CHECK-NO-WARNING3 %s +// CHECK-NO-WARNING3: optimization flag '-fprofile-correction' is not supported +// CHECK-NO-WARNING3-NOT: argument unused +// RUN: %clang -### -fprofile-correction -Wno-ignored-optimization-argument %s 2>&1 \ +// RUN: | FileCheck --check-prefix=CHECK-NO-WARNING4 %s +// CHECK-NO-WARNING4-NOT: not supported +// CHECK-NO-WARNING4-NOT: argument unused + // RUN: %clang -### -S -fsigned-char %s 2>&1 | FileCheck -check-prefix=CHAR-SIGN1 %s // CHAR-SIGN1-NOT: -fno-signed-char |
