diff options
| author | Richard Smith <richard-llvm@metafoo.co.uk> | 2019-05-09 22:22:48 +0000 |
|---|---|---|
| committer | Richard Smith <richard-llvm@metafoo.co.uk> | 2019-05-09 22:22:48 +0000 |
| commit | 89009441094ab3930b953ae1198ed120c00be430 (patch) | |
| tree | 977f326f00c7c73a18415643df5d8a9e5a4c61cf | |
| parent | 7b844849fe098ac600c06740988436e80b5f4d14 (diff) | |
| download | bcm5719-llvm-89009441094ab3930b953ae1198ed120c00be430.tar.gz bcm5719-llvm-89009441094ab3930b953ae1198ed120c00be430.zip | |
Remember to decay arrays to pointers before checking whether the
left-hand side of an -> operator is a pointer to class type.
llvm-svn: 360387
| -rw-r--r-- | clang/lib/Sema/SemaExprCXX.cpp | 9 | ||||
| -rw-r--r-- | clang/test/Parser/cxx-class.cpp | 13 |
2 files changed, 19 insertions, 3 deletions
diff --git a/clang/lib/Sema/SemaExprCXX.cpp b/clang/lib/Sema/SemaExprCXX.cpp index 6af59d5c431..683fc5b3198 100644 --- a/clang/lib/Sema/SemaExprCXX.cpp +++ b/clang/lib/Sema/SemaExprCXX.cpp @@ -6790,9 +6790,12 @@ ExprResult Sema::ActOnStartCXXMemberReference(Scope *S, Expr *Base, FirstIteration = false; } - if (OpKind == tok::arrow && - (BaseType->isPointerType() || BaseType->isObjCObjectPointerType())) - BaseType = BaseType->getPointeeType(); + if (OpKind == tok::arrow) { + if (BaseType->isPointerType()) + BaseType = BaseType->getPointeeType(); + else if (auto *AT = Context.getAsArrayType(BaseType)) + BaseType = AT->getElementType(); + } } // Objective-C properties allow "." access on Objective-C pointer types, diff --git a/clang/test/Parser/cxx-class.cpp b/clang/test/Parser/cxx-class.cpp index fe9c1ac95b4..e672c45068d 100644 --- a/clang/test/Parser/cxx-class.cpp +++ b/clang/test/Parser/cxx-class.cpp @@ -283,6 +283,19 @@ struct C {} decltype(D())::c; // expected-error {{'decltype' cannot be used to n #endif } +namespace ArrayMemberAccess { + struct A { + int x; + template<typename T> int f() const; + }; + void f(const A (&a)[]) { + // OK: not a template-id. + bool cond = a->x < 10 && a->x > 0; + // OK: a template-id. + a->f<int>(); + } +} + // PR11109 must appear at the end of the source file class pr11109r3 { // expected-note{{to match this '{'}} public // expected-error{{expected ':'}} expected-error{{expected '}'}} expected-error{{expected ';' after class}} |

