lto: Start taking symbol visibility into consideration.

llvm-svn: 262761

3 files changed, 40 insertions, 2 deletions

diff --git a/lld/ELF/InputFiles.cpp b/lld/ELF/InputFiles.cpp
index cbfc4944598..88177a8c963 100644
--- a/lld/ELF/InputFiles.cpp
+++ b/lld/ELF/InputFiles.cpp
@@ -427,10 +427,23 @@ void BitcodeFile::parse(DenseSet<StringRef> &ComdatGroups) {
   }
 
   for (const BasicSymbolRef &Sym : Obj->symbols()) {
-    if (const GlobalValue *GV = Obj->getSymbolGV(Sym.getRawDataRefImpl()))
+    uint8_t Visibility = STV_DEFAULT;
+    if (const GlobalValue *GV = Obj->getSymbolGV(Sym.getRawDataRefImpl())) {
       if (const Comdat *C = GV->getComdat())
         if (!KeptComdats.count(C))
           continue;
+      switch (GV->getVisibility()) {
+      case GlobalValue::DefaultVisibility:
+        Visibility = STV_DEFAULT;
+        break;
+      case GlobalValue::HiddenVisibility:
+        Visibility = STV_HIDDEN;
+        break;
+      case GlobalValue::ProtectedVisibility:
+        Visibility = STV_PROTECTED;
+        break;
+      }
+    }
 
     SmallString<64> Name;
     raw_svector_ostream OS(Name);
@@ -440,7 +453,7 @@ void BitcodeFile::parse(DenseSet<StringRef> &ComdatGroups) {
     uint32_t Flags = Sym.getFlags();
     bool IsWeak = Flags & BasicSymbolRef::SF_Weak;
     if (Flags & BasicSymbolRef::SF_Undefined)
-      Body = new (Alloc) Undefined(NameRef, IsWeak, STV_DEFAULT, false);
+      Body = new (Alloc) Undefined(NameRef, IsWeak, Visibility, false);
     else
       Body = new (Alloc) DefinedBitcode(NameRef, IsWeak);
     SymbolBodies.push_back(Body);
diff --git a/lld/test/ELF/lto/Inputs/visibility.s b/lld/test/ELF/lto/Inputs/visibility.s
new file mode 100644
index 00000000000..a63aa6ddbcd
--- /dev/null
+++ b/lld/test/ELF/lto/Inputs/visibility.s
@@ -0,0 +1,3 @@
+        .global g
+g:
+        ret
diff --git a/lld/test/ELF/lto/visibility.ll b/lld/test/ELF/lto/visibility.ll
new file mode 100644
index 00000000000..3f561f27d35
--- /dev/null
+++ b/lld/test/ELF/lto/visibility.ll
@@ -0,0 +1,22 @@
+; REQUIRES: x86
+; RUN: llvm-as %s -o %t1.o
+; RUN: llvm-mc -triple=x86_64-pc-linux %p/Inputs/visibility.s -o %t2.o -filetype=obj
+; RUN: ld.lld %t1.o %t2.o -o %t.so -shared
+; RUN: llvm-readobj -t %t.so | FileCheck %s
+
+; CHECK:      Name: g
+; CHECK-NEXT: Value: 0x1000
+; CHECK-NEXT: Size: 0
+; CHECK-NEXT: Binding: Local
+; CHECK-NEXT: Type: None
+; CHECK-NEXT: Other: 2
+; CHECK-NEXT: Section: .text
+
+target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
+target triple = "x86_64-unknown-linux-gnu"
+
+declare hidden void @g()
+define void @f() {
+  call void @g()
+  ret void
+}