summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSanjay Patel <spatel@rotateright.com>2018-12-06 23:53:58 +0000
committerSanjay Patel <spatel@rotateright.com>2018-12-06 23:53:58 +0000
commit86cb67985179984da5fc2e8bc97c7f5579bada84 (patch)
treee35de510ca5edfe392aa2c021d7b1c4db4659e7d
parentcf65b9207b58e09e9a763ff4f1aed8687c086f37 (diff)
downloadbcm5719-llvm-86cb67985179984da5fc2e8bc97c7f5579bada84.tar.gz
bcm5719-llvm-86cb67985179984da5fc2e8bc97c7f5579bada84.zip
[DAGCombiner] don't bother saving a SDLoc for a node that's dead; NFCI
We shouldn't care about the debug location for a node that we're creating, but attaching the root of the pattern should be the best effort. (If this is not true, then we are doing it wrong all over the SDAG). This is no-functional-change-intended, and there are no regression test diffs...and that's what I expected. But there's a similar line above this diff, where those assumptions apparently do not hold. llvm-svn: 348550
-rw-r--r--llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp2
1 files changed, 1 insertions, 1 deletions
diff --git a/llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp b/llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
index ee7b3825911..70ce0a7e5e2 100644
--- a/llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
+++ b/llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
@@ -3767,7 +3767,7 @@ SDValue DAGCombiner::hoistLogicOpWithSameOpcodeHands(SDNode *N) {
// If either operand has other uses, this transform is not an improvement.
if (!N0.hasOneUse() || !N1.hasOneUse())
return SDValue();
- SDValue Logic = DAG.getNode(LogicOpcode, SDLoc(N0), XVT, X, Y);
+ SDValue Logic = DAG.getNode(LogicOpcode, DL, XVT, X, Y);
AddToWorklist(Logic.getNode());
return DAG.getNode(HandOpcode, DL, VT, Logic, N0.getOperand(1));
}
OpenPOWER on IntegriCloud