summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorGeoff Berry <gberry@codeaurora.org>2017-04-13 15:36:25 +0000
committerGeoff Berry <gberry@codeaurora.org>2017-04-13 15:36:25 +0000
commit85a530fb599458666bfa9b492075df1841bdd7a5 (patch)
tree5fbe0c4e8133e2bdd571a6c604026b24e1f19d78
parent5619952ee1c7f5ccf54e94202905f0d35d999293 (diff)
downloadbcm5719-llvm-85a530fb599458666bfa9b492075df1841bdd7a5.tar.gz
bcm5719-llvm-85a530fb599458666bfa9b492075df1841bdd7a5.zip
Re-apply "[GVNHoist] Move GVNHoist to function simplification part of pipeline."
This reverts commit r296872 now that PR32153 has been fixed. llvm-svn: 300200
-rw-r--r--llvm/lib/Transforms/IPO/PassManagerBuilder.cpp4
-rw-r--r--llvm/test/Transforms/GVNHoist/hoist-inline.ll38
2 files changed, 40 insertions, 2 deletions
diff --git a/llvm/lib/Transforms/IPO/PassManagerBuilder.cpp b/llvm/lib/Transforms/IPO/PassManagerBuilder.cpp
index 6cc6d3b63f4..f11b58d1adc 100644
--- a/llvm/lib/Transforms/IPO/PassManagerBuilder.cpp
+++ b/llvm/lib/Transforms/IPO/PassManagerBuilder.cpp
@@ -245,8 +245,6 @@ void PassManagerBuilder::populateFunctionPassManager(
FPM.add(createCFGSimplificationPass());
FPM.add(createSROAPass());
FPM.add(createEarlyCSEPass());
- if (EnableGVNHoist)
- FPM.add(createGVNHoistPass());
FPM.add(createLowerExpectIntrinsicPass());
}
@@ -291,6 +289,8 @@ void PassManagerBuilder::addFunctionSimplificationPasses(
// Break up aggregate allocas, using SSAUpdater.
MPM.add(createSROAPass());
MPM.add(createEarlyCSEPass()); // Catch trivial redundancies
+ if (EnableGVNHoist)
+ MPM.add(createGVNHoistPass());
// Speculative execution if the target has divergent branches; otherwise nop.
MPM.add(createSpeculativeExecutionIfHasBranchDivergencePass());
MPM.add(createJumpThreadingPass()); // Thread jumps.
diff --git a/llvm/test/Transforms/GVNHoist/hoist-inline.ll b/llvm/test/Transforms/GVNHoist/hoist-inline.ll
new file mode 100644
index 00000000000..7d761486ab1
--- /dev/null
+++ b/llvm/test/Transforms/GVNHoist/hoist-inline.ll
@@ -0,0 +1,38 @@
+; RUN: opt -S -O2 < %s | FileCheck %s
+
+; Check that the inlined loads are hoisted.
+; CHECK-LABEL: define i32 @fun(
+; CHECK-LABEL: entry:
+; CHECK: load i32, i32* @A
+; CHECK: if.then:
+
+@A = external global i32
+@B = external global i32
+@C = external global i32
+
+define i32 @loadA() {
+ %a = load i32, i32* @A
+ ret i32 %a
+}
+
+define i32 @fun(i1 %c) {
+entry:
+ br i1 %c, label %if.then, label %if.else
+
+if.then:
+ store i32 1, i32* @B
+ %call1 = call i32 @loadA()
+ store i32 2, i32* @C
+ br label %if.endif
+
+if.else:
+ store i32 2, i32* @C
+ %call2 = call i32 @loadA()
+ store i32 1, i32* @B
+ br label %if.endif
+
+if.endif:
+ %ret = phi i32 [ %call1, %if.then ], [ %call2, %if.else ]
+ ret i32 %ret
+}
+
OpenPOWER on IntegriCloud