diff options
| author | Nico Weber <nicolasweber@gmx.de> | 2019-01-21 18:59:11 +0000 |
|---|---|---|
| committer | Nico Weber <nicolasweber@gmx.de> | 2019-01-21 18:59:11 +0000 |
| commit | 8441c467bf9b02638afc9fb3affce8eb1207e65d (patch) | |
| tree | fc18dfd766355fefc58ff5c63bae9f9a308e2fc0 | |
| parent | f728767633e7ee5b1ffe1c17c9989ecd35c716f6 (diff) | |
| download | bcm5719-llvm-8441c467bf9b02638afc9fb3affce8eb1207e65d.tar.gz bcm5719-llvm-8441c467bf9b02638afc9fb3affce8eb1207e65d.zip | |
gn build: Stop passing -DLLVM_LIBXML2_ENABLED to some targets
This is a remnant from before the gn build had a working config.h.
Defining LLVM_LIBXML2_ENABLED only for targets that depend on build/libs/xml is
nice in that only some of the codebase needs to be rebuilt when
llvm_enable_libxml2 changes -- but config.h already defines it and defining it
there and then redundantly a second time for some targets is worse than having
it just in config.h.
No behavior change.
Differential Revision: https://reviews.llvm.org/D56908
llvm-svn: 351758
| -rw-r--r-- | llvm/utils/gn/build/libs/xml/BUILD.gn | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/llvm/utils/gn/build/libs/xml/BUILD.gn b/llvm/utils/gn/build/libs/xml/BUILD.gn index f3590f4601c..3af3c851698 100644 --- a/llvm/utils/gn/build/libs/xml/BUILD.gn +++ b/llvm/utils/gn/build/libs/xml/BUILD.gn @@ -3,7 +3,6 @@ import("//llvm/utils/gn/build/mac_sdk.gni") config("xml_config") { visibility = [ ":xml" ] - defines = [ "LLVM_LIBXML2_ENABLED" ] libs = [ "xml2" ] if (host_os == "mac") { include_dirs = [ "$mac_sdk_path/usr/include/libxml2" ] |
