diff options
author | Rafael Espindola <rafael.espindola@gmail.com> | 2014-01-10 21:40:29 +0000 |
---|---|---|
committer | Rafael Espindola <rafael.espindola@gmail.com> | 2014-01-10 21:40:29 +0000 |
commit | 81e7fd011fa0fab28b23c787e2ab66fc1bc9a926 (patch) | |
tree | 2a53ca73dcc53598adb93818ec728008e8f0841f | |
parent | 2a008784d36f492b1fbead7a0f2e7c838ea0befb (diff) | |
download | bcm5719-llvm-81e7fd011fa0fab28b23c787e2ab66fc1bc9a926.tar.gz bcm5719-llvm-81e7fd011fa0fab28b23c787e2ab66fc1bc9a926.zip |
Use the simpler version of sys::fs::remove when possible.
llvm-svn: 198958
-rw-r--r-- | llvm/include/llvm/Support/FileUtilities.h | 6 | ||||
-rw-r--r-- | llvm/lib/Support/FileOutputBuffer.cpp | 6 | ||||
-rw-r--r-- | llvm/lib/Support/GraphWriter.cpp | 3 | ||||
-rw-r--r-- | llvm/lib/Support/LockFileManager.cpp | 13 | ||||
-rw-r--r-- | llvm/lib/Support/ToolOutputFile.cpp | 6 |
5 files changed, 12 insertions, 22 deletions
diff --git a/llvm/include/llvm/Support/FileUtilities.h b/llvm/include/llvm/Support/FileUtilities.h index 79c59e4306c..873b8df30e0 100644 --- a/llvm/include/llvm/Support/FileUtilities.h +++ b/llvm/include/llvm/Support/FileUtilities.h @@ -51,8 +51,7 @@ namespace llvm { ~FileRemover() { if (DeleteIt) { // Ignore problems deleting the file. - bool existed; - sys::fs::remove(Filename.str(), existed); + sys::fs::remove(Filename.str()); } } @@ -62,8 +61,7 @@ namespace llvm { void setFile(const Twine& filename, bool deleteIt = true) { if (DeleteIt) { // Ignore problems deleting the file. - bool existed; - sys::fs::remove(Filename.str(), existed); + sys::fs::remove(Filename.str()); } Filename.clear(); diff --git a/llvm/lib/Support/FileOutputBuffer.cpp b/llvm/lib/Support/FileOutputBuffer.cpp index ed084faed78..c01778f9600 100644 --- a/llvm/lib/Support/FileOutputBuffer.cpp +++ b/llvm/lib/Support/FileOutputBuffer.cpp @@ -28,8 +28,7 @@ FileOutputBuffer::FileOutputBuffer(mapped_file_region * R, } FileOutputBuffer::~FileOutputBuffer() { - bool Existed; - sys::fs::remove(Twine(TempPath), Existed); + sys::fs::remove(Twine(TempPath)); } error_code FileOutputBuffer::create(StringRef FilePath, @@ -57,8 +56,7 @@ error_code FileOutputBuffer::create(StringRef FilePath, } // Delete target file. - bool Existed; - EC = sys::fs::remove(FilePath, Existed); + EC = sys::fs::remove(FilePath); if (EC) return EC; diff --git a/llvm/lib/Support/GraphWriter.cpp b/llvm/lib/Support/GraphWriter.cpp index 85be415dce0..83aa25507f6 100644 --- a/llvm/lib/Support/GraphWriter.cpp +++ b/llvm/lib/Support/GraphWriter.cpp @@ -87,8 +87,7 @@ ExecGraphViewer(StringRef ExecPath, std::vector<const char*> &args, errs() << "Error: " << ErrMsg << "\n"; return false; } - bool Existed; - sys::fs::remove(Filename, Existed); + sys::fs::remove(Filename); errs() << " done. \n"; } else { diff --git a/llvm/lib/Support/LockFileManager.cpp b/llvm/lib/Support/LockFileManager.cpp index eeec274ad8e..5f153a9f795 100644 --- a/llvm/lib/Support/LockFileManager.cpp +++ b/llvm/lib/Support/LockFileManager.cpp @@ -111,8 +111,7 @@ LockFileManager::LockFileManager(StringRef FileName) // We failed to write out PID, so make up an excuse, remove the // unique lock file, and fail. Error = make_error_code(errc::no_space_on_device); - bool Existed; - sys::fs::remove(UniqueLockFileName.c_str(), Existed); + sys::fs::remove(UniqueLockFileName.c_str()); return; } } @@ -137,14 +136,13 @@ LockFileManager::LockFileManager(StringRef FileName) // Someone else managed to create the lock file first. Wipe out our unique // lock file (it's useless now) and read the process ID from the lock file. - bool Existed; - sys::fs::remove(UniqueLockFileName.str(), Existed); + sys::fs::remove(UniqueLockFileName.str()); if ((Owner = readLockFile(LockFileName))) return; // There is a lock file that nobody owns; try to clean it up and report // an error. - sys::fs::remove(LockFileName.str(), Existed); + sys::fs::remove(LockFileName.str()); Error = EC; } @@ -163,9 +161,8 @@ LockFileManager::~LockFileManager() { return; // Since we own the lock, remove the lock file and our own unique lock file. - bool Existed; - sys::fs::remove(LockFileName.str(), Existed); - sys::fs::remove(UniqueLockFileName.str(), Existed); + sys::fs::remove(LockFileName.str()); + sys::fs::remove(UniqueLockFileName.str()); } void LockFileManager::waitForUnlock() { diff --git a/llvm/lib/Support/ToolOutputFile.cpp b/llvm/lib/Support/ToolOutputFile.cpp index 5c1268a40a9..b5fb20f4b20 100644 --- a/llvm/lib/Support/ToolOutputFile.cpp +++ b/llvm/lib/Support/ToolOutputFile.cpp @@ -25,10 +25,8 @@ tool_output_file::CleanupInstaller::CleanupInstaller(const char *filename) tool_output_file::CleanupInstaller::~CleanupInstaller() { // Delete the file if the client hasn't told us not to. - if (!Keep && Filename != "-") { - bool Existed; - sys::fs::remove(Filename, Existed); - } + if (!Keep && Filename != "-") + sys::fs::remove(Filename); // Ok, the file is successfully written and closed, or deleted. There's no // further need to clean it up on signals. |