diff options
| author | Fariborz Jahanian <fjahanian@apple.com> | 2010-12-16 00:56:28 +0000 |
|---|---|---|
| committer | Fariborz Jahanian <fjahanian@apple.com> | 2010-12-16 00:56:28 +0000 |
| commit | 7cabbe04ebdd38cd62fe4563325e9dffee84f243 (patch) | |
| tree | c8e85b26d743c91085b1803c254fdd6754dbdc02 | |
| parent | 9613a09e5c999ef116f378c701b5e2be5d417808 (diff) | |
| download | bcm5719-llvm-7cabbe04ebdd38cd62fe4563325e9dffee84f243.tar.gz bcm5719-llvm-7cabbe04ebdd38cd62fe4563325e9dffee84f243.zip | |
Improve diagnostics when property being looked up
in a forward @class object. // rdar://8774513
llvm-svn: 121933
| -rw-r--r-- | clang/include/clang/Basic/DiagnosticSemaKinds.td | 4 | ||||
| -rw-r--r-- | clang/lib/Sema/SemaExprObjC.cpp | 6 | ||||
| -rw-r--r-- | clang/test/SemaObjC/property-9.m | 11 |
3 files changed, 21 insertions, 0 deletions
diff --git a/clang/include/clang/Basic/DiagnosticSemaKinds.td b/clang/include/clang/Basic/DiagnosticSemaKinds.td index e9617a2f11f..8095b946565 100644 --- a/clang/include/clang/Basic/DiagnosticSemaKinds.td +++ b/clang/include/clang/Basic/DiagnosticSemaKinds.td @@ -2416,6 +2416,10 @@ def err_ref_array_type : Error< "cannot refer to declaration with an array type inside block">; def err_property_not_found : Error< "property %0 not found on object of type %1">; +def err_property_not_found_forward_class : Error< + "property %0 cannot be found in forward class object %1">; +def note_forward_class : Note< + "forward class is declared here">; def err_duplicate_property : Error< "property has a previous declaration">; def ext_gnu_void_ptr : Extension< diff --git a/clang/lib/Sema/SemaExprObjC.cpp b/clang/lib/Sema/SemaExprObjC.cpp index 5d5e8a528bb..baa34f9ce8d 100644 --- a/clang/lib/Sema/SemaExprObjC.cpp +++ b/clang/lib/Sema/SemaExprObjC.cpp @@ -353,6 +353,12 @@ HandleExprPropertyRefExpr(const ObjCObjectPointerType *OPT, ObjCInterfaceDecl *IFace = IFaceT->getDecl(); IdentifierInfo *Member = MemberName.getAsIdentifierInfo(); + if (IFace->isForwardDecl()) { + Diag(MemberLoc, diag::err_property_not_found_forward_class) + << MemberName << QualType(OPT, 0); + Diag(IFace->getLocation(), diag::note_forward_class); + return ExprError(); + } // Search for a declared property first. if (ObjCPropertyDecl *PD = IFace->FindPropertyDeclaration(Member)) { // Check whether we can reference this property. diff --git a/clang/test/SemaObjC/property-9.m b/clang/test/SemaObjC/property-9.m index 669f9c0e4bd..2b6564d2959 100644 --- a/clang/test/SemaObjC/property-9.m +++ b/clang/test/SemaObjC/property-9.m @@ -96,3 +96,14 @@ typedef signed char BOOL; - (float)setMyStyle:(int)style; @end +// rdar://8774513 +@class MDAInstance; // expected-note {{forward class is declared here}} + +@interface MDATestDocument +@property(retain) MDAInstance *instance; +@end + +id f0(MDATestDocument *d) { + return d.instance.path; // expected-error {{property 'path' cannot be found in forward class object 'MDAInstance *'}} +} + |
