diff options
| author | Pavel Labath <labath@google.com> | 2016-12-05 11:15:36 +0000 |
|---|---|---|
| committer | Pavel Labath <labath@google.com> | 2016-12-05 11:15:36 +0000 |
| commit | 7a6252158e2fa1f3dfd0a4c846db0c6365d3f3ea (patch) | |
| tree | 647c9f59f36e4d739c8bb3509b0e953a65cd6543 | |
| parent | 4cb4b36aa2537fd7115d4bf67b4d4b94cd1c0b94 (diff) | |
| download | bcm5719-llvm-7a6252158e2fa1f3dfd0a4c846db0c6365d3f3ea.tar.gz bcm5719-llvm-7a6252158e2fa1f3dfd0a4c846db0c6365d3f3ea.zip | |
Clean up some use of __ANDROID_NDK__ in the cmake files
Rationale:
scripts/Python/modules: android is excluded at a higher level, so no point in
checking here
tools/lldb-mi: lldb-mi builds fine (with some cosmetic tweaks) on android, and
there is no reason it shouldn't.
tools/lldb-server: LLDB_DISABLE_LIBEDIT/CURSES already take the platform into
account, so there is no point in checking again.
I am reasonably confident this should not break the build on any platform, but
I'll keep an eye out on the bots.
llvm-svn: 288661
| -rw-r--r-- | lldb/scripts/Python/modules/CMakeLists.txt | 2 | ||||
| -rw-r--r-- | lldb/tools/CMakeLists.txt | 8 | ||||
| -rw-r--r-- | lldb/tools/lldb-mi/CMakeLists.txt | 2 | ||||
| -rw-r--r-- | lldb/tools/lldb-mi/MIUtilString.cpp | 1 | ||||
| -rw-r--r-- | lldb/tools/lldb-server/CMakeLists.txt | 16 |
5 files changed, 13 insertions, 16 deletions
diff --git a/lldb/scripts/Python/modules/CMakeLists.txt b/lldb/scripts/Python/modules/CMakeLists.txt index 396d447ff26..01ab5771bda 100644 --- a/lldb/scripts/Python/modules/CMakeLists.txt +++ b/lldb/scripts/Python/modules/CMakeLists.txt @@ -6,6 +6,6 @@ if (CXX_SUPPORTS_NO_MACRO_REDEFINED) endif () # build the Python readline suppression module only on Linux -if (CMAKE_SYSTEM_NAME MATCHES "Linux" AND NOT __ANDROID_NDK__) +if (CMAKE_SYSTEM_NAME MATCHES "Linux") add_subdirectory(readline) endif() diff --git a/lldb/tools/CMakeLists.txt b/lldb/tools/CMakeLists.txt index 49af928c381..86b9621a198 100644 --- a/lldb/tools/CMakeLists.txt +++ b/lldb/tools/CMakeLists.txt @@ -2,11 +2,9 @@ if (CMAKE_SYSTEM_NAME MATCHES "Darwin") add_subdirectory(darwin-debug) add_subdirectory(debugserver) endif() - add_subdirectory(argdumper) - add_subdirectory(driver) -if (NOT __ANDROID_NDK__) - add_subdirectory(lldb-mi) -endif() +add_subdirectory(argdumper) +add_subdirectory(driver) +add_subdirectory(lldb-mi) if (LLDB_CAN_USE_LLDB_SERVER) add_subdirectory(lldb-server) endif() diff --git a/lldb/tools/lldb-mi/CMakeLists.txt b/lldb/tools/lldb-mi/CMakeLists.txt index f42ec02beda..1e73b8200a8 100644 --- a/lldb/tools/lldb-mi/CMakeLists.txt +++ b/lldb/tools/lldb-mi/CMakeLists.txt @@ -87,7 +87,7 @@ set(LLVM_LINK_COMPONENTS Support) add_lldb_executable(lldb-mi ${LLDB_MI_SOURCES}) target_link_libraries(lldb-mi liblldb) -if ( NOT CMAKE_SYSTEM_NAME MATCHES "Windows" ) +if (HAVE_LIBPTHREAD) target_link_libraries(lldb-mi pthread) endif () diff --git a/lldb/tools/lldb-mi/MIUtilString.cpp b/lldb/tools/lldb-mi/MIUtilString.cpp index 2ea17fe0840..3e6911f6818 100644 --- a/lldb/tools/lldb-mi/MIUtilString.cpp +++ b/lldb/tools/lldb-mi/MIUtilString.cpp @@ -8,6 +8,7 @@ //===----------------------------------------------------------------------===// // Third party headers +#include <cstdlib> #include <inttypes.h> // for PRIx8 #include <limits.h> // for ULONG_MAX #include <memory> // std::unique_ptr diff --git a/lldb/tools/lldb-server/CMakeLists.txt b/lldb/tools/lldb-server/CMakeLists.txt index 990c4195eda..bc238282ea7 100644 --- a/lldb/tools/lldb-server/CMakeLists.txt +++ b/lldb/tools/lldb-server/CMakeLists.txt @@ -108,15 +108,13 @@ set( CLANG_USED_LIBS ) set(LLDB_SYSTEM_LIBS) -if (NOT CMAKE_SYSTEM_NAME MATCHES "Windows" AND NOT __ANDROID_NDK__) - if (NOT LLDB_DISABLE_LIBEDIT) - list(APPEND LLDB_SYSTEM_LIBS edit) - endif() - if (NOT LLDB_DISABLE_CURSES) - list(APPEND LLDB_SYSTEM_LIBS ${CURSES_LIBRARIES}) - if(LLVM_ENABLE_TERMINFO AND HAVE_TERMINFO) - list(APPEND LLDB_SYSTEM_LIBS ${TERMINFO_LIBS}) - endif() +if (NOT LLDB_DISABLE_LIBEDIT) + list(APPEND LLDB_SYSTEM_LIBS edit) +endif() +if (NOT LLDB_DISABLE_CURSES) + list(APPEND LLDB_SYSTEM_LIBS ${CURSES_LIBRARIES}) + if(LLVM_ENABLE_TERMINFO AND HAVE_TERMINFO) + list(APPEND LLDB_SYSTEM_LIBS ${TERMINFO_LIBS}) endif() endif() |

