summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorReid Kleckner <rnk@google.com>2016-03-11 19:11:15 +0000
committerReid Kleckner <rnk@google.com>2016-03-11 19:11:15 +0000
commit7a2113882ffc8d588fca232e13878c855b3c3ece (patch)
treea4c939f5f6db2d7a66e0ff8c98a92075e7013636
parentb51325dbdb10f0b4ab2b9c5ec4a979dffc246794 (diff)
downloadbcm5719-llvm-7a2113882ffc8d588fca232e13878c855b3c3ece.tar.gz
bcm5719-llvm-7a2113882ffc8d588fca232e13878c855b3c3ece.zip
Make printf-4 more robust to strlen interception after r263177
The CHECK line was matching stack-buffer-overflow from puts calling strlen, which is not the bug the test is trying to catch. llvm-svn: 263282
-rw-r--r--compiler-rt/test/asan/TestCases/printf-4.c12
1 files changed, 7 insertions, 5 deletions
diff --git a/compiler-rt/test/asan/TestCases/printf-4.c b/compiler-rt/test/asan/TestCases/printf-4.c
index 13bfc876c36..d49a06ff91a 100644
--- a/compiler-rt/test/asan/TestCases/printf-4.c
+++ b/compiler-rt/test/asan/TestCases/printf-4.c
@@ -1,10 +1,8 @@
// RUN: %clang_asan -O2 %s -o %t
-// We need replace_str=0 and replace_intrin=0 to avoid reporting errors in
-// strlen() and memcpy() called by puts().
-// RUN: %env_asan_opts=replace_str=0:replace_intrin=0:check_printf=1 not %run %t 2>&1 | FileCheck --check-prefix=CHECK-ON %s
-// RUN: %env_asan_opts=replace_str=0:replace_intrin=0 not %run %t 2>&1 | FileCheck --check-prefix=CHECK-ON %s
+// RUN: %env_asan_opts=check_printf=1 not %run %t 2>&1 | FileCheck --check-prefix=CHECK-ON %s
+// RUN: not %run %t 2>&1 | FileCheck --check-prefix=CHECK-ON %s
-// FIXME: printf is not intercepted on Windows yet.
+// FIXME: sprintf is not intercepted on Windows yet.
// XFAIL: win32
#include <stdio.h>
@@ -14,10 +12,14 @@ int main() {
volatile float f = 1.239;
volatile char s[] = "34";
volatile char buf[2];
+ puts("before sprintf");
sprintf((char *)buf, "%c %d %.3f %s\n", c, x, f, s);
+ puts("after sprintf");
puts((const char *)buf);
return 0;
// Check that size of output buffer is sanitized.
+ // CHECK-ON: before sprintf
+ // CHECK-ON-NOT: after sprintf
// CHECK-ON: stack-buffer-overflow
// CHECK-ON-NOT: 0 12 1.239 34
}
OpenPOWER on IntegriCloud