diff options
| author | George Rimar <grimar@accesssoftek.com> | 2017-02-21 15:46:43 +0000 |
|---|---|---|
| committer | George Rimar <grimar@accesssoftek.com> | 2017-02-21 15:46:43 +0000 |
| commit | 78ef645f949dfa1f8be8c99fc04169267d2c5e36 (patch) | |
| tree | 1ea3c8b15d8014d5640d22e3b7938c0bd7f973f3 | |
| parent | cc43087afc0684aaa52eac5e79fe4f03d17f13c0 (diff) | |
| download | bcm5719-llvm-78ef645f949dfa1f8be8c99fc04169267d2c5e36.tar.gz bcm5719-llvm-78ef645f949dfa1f8be8c99fc04169267d2c5e36.zip | |
[ELF] - Do not segfault when using --gc-sections with linker script
Patch fixes PR32024.
Sections that were not marked as Live has null output section.
Previously we tried to access that field and segfaulted.
Differential revision: https://reviews.llvm.org/D30188
llvm-svn: 295727
| -rw-r--r-- | lld/ELF/LinkerScript.cpp | 2 | ||||
| -rw-r--r-- | lld/test/ELF/linkerscript/sections-gc.s | 19 |
2 files changed, 21 insertions, 0 deletions
diff --git a/lld/ELF/LinkerScript.cpp b/lld/ELF/LinkerScript.cpp index db7bb03568b..a5ecf48f18f 100644 --- a/lld/ELF/LinkerScript.cpp +++ b/lld/ELF/LinkerScript.cpp @@ -503,6 +503,8 @@ template <class ELFT> void LinkerScript<ELFT>::process(BaseCommand &Base) { continue; auto *IB = static_cast<InputSectionBase<ELFT> *>(ID); + if (!IB->Live) + continue; switchTo(IB->OutSec); if (auto *I = dyn_cast<InputSection<ELFT>>(IB)) output(I); diff --git a/lld/test/ELF/linkerscript/sections-gc.s b/lld/test/ELF/linkerscript/sections-gc.s new file mode 100644 index 00000000000..d71dc652511 --- /dev/null +++ b/lld/test/ELF/linkerscript/sections-gc.s @@ -0,0 +1,19 @@ +# REQUIRES: x86 +# RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %s -o %t +# RUN: echo "SECTIONS { .text : { *(.text*) } }" > %t.script +# RUN: ld.lld %t --gc-sections --script %t.script -o %t1 +# RUN: llvm-objdump -section-headers %t1 | FileCheck %s + +# CHECK: Sections: +# CHECK-NEXT: Name Size +# CHECK: .text 00000001 + +.section .text.foo, "ax" +.global _start +_start: + nop + +.section .text.bar, "ax" +.global bar +bar: + nop |

