diff options
author | Konstantin Zhuravlyov <kzhuravl_dev@outlook.com> | 2018-06-21 18:36:04 +0000 |
---|---|---|
committer | Konstantin Zhuravlyov <kzhuravl_dev@outlook.com> | 2018-06-21 18:36:04 +0000 |
commit | 766c77efd7ec420583458d2f0726f42058109383 (patch) | |
tree | 7c399365d1dcd3f4ea9e20327c5e1f7b4ce76ab1 | |
parent | 3382dc644e86cded3e6b6e6069c8cc4e484886a7 (diff) | |
download | bcm5719-llvm-766c77efd7ec420583458d2f0726f42058109383.tar.gz bcm5719-llvm-766c77efd7ec420583458d2f0726f42058109383.zip |
AMDGPU/AMDHSA: Remove GridWorkGroupCountX/Y/Z
and everything that comes with it from implementation
and v3 header files.
Leave definition in v2 header files for backwards
compatibility.
Differential Revision: https://reviews.llvm.org/D48191
llvm-svn: 335267
-rw-r--r-- | llvm/docs/AMDGPUUsage.rst | 11 | ||||
-rw-r--r-- | llvm/include/llvm/Support/AMDHSAKernelDescriptor.h | 5 | ||||
-rw-r--r-- | llvm/lib/Target/AMDGPU/AMDGPUArgumentUsageInfo.cpp | 3 | ||||
-rw-r--r-- | llvm/lib/Target/AMDGPU/AMDGPUArgumentUsageInfo.h | 3 | ||||
-rw-r--r-- | llvm/lib/Target/AMDGPU/AMDGPUAsmPrinter.cpp | 27 | ||||
-rw-r--r-- | llvm/lib/Target/AMDGPU/SIMachineFunctionInfo.cpp | 3 | ||||
-rw-r--r-- | llvm/lib/Target/AMDGPU/SIMachineFunctionInfo.h | 15 |
7 files changed, 3 insertions, 64 deletions
diff --git a/llvm/docs/AMDGPUUsage.rst b/llvm/docs/AMDGPUUsage.rst index 5c1430732c1..0f60d4995c7 100644 --- a/llvm/docs/AMDGPUUsage.rst +++ b/llvm/docs/AMDGPUUsage.rst @@ -1667,15 +1667,8 @@ CP microcode requires the Kernel descritor to be allocated on 64 byte alignment. 453 1 bit ENABLE_SGPR_FLAT_SCRATCH_INIT *see above* 454 1 bit ENABLE_SGPR_PRIVATE_SEGMENT *see above* _SIZE - 455 1 bit ENABLE_SGPR_GRID_WORKGROUP Not implemented in CP and - _COUNT_X should always be 0. - 456 1 bit ENABLE_SGPR_GRID_WORKGROUP Not implemented in CP and - _COUNT_Y should always be 0. - 457 1 bit ENABLE_SGPR_GRID_WORKGROUP Not implemented in CP and - _COUNT_Z should always be 0. - 463:458 6 bits Reserved, must be 0. - 511:464 6 Reserved, must be 0. - bytes + 455 1 bit Reserved, must be 0. + 511:456 8 bytes Reserved, must be 0. 512 **Total size 64 bytes.** ======= ==================================================================== diff --git a/llvm/include/llvm/Support/AMDHSAKernelDescriptor.h b/llvm/include/llvm/Support/AMDHSAKernelDescriptor.h index bcaf7383044..82c82be5f5b 100644 --- a/llvm/include/llvm/Support/AMDHSAKernelDescriptor.h +++ b/llvm/include/llvm/Support/AMDHSAKernelDescriptor.h @@ -131,10 +131,7 @@ enum : int32_t { KERNEL_CODE_PROPERTY(ENABLE_SGPR_DISPATCH_ID, 4, 1), KERNEL_CODE_PROPERTY(ENABLE_SGPR_FLAT_SCRATCH_INIT, 5, 1), KERNEL_CODE_PROPERTY(ENABLE_SGPR_PRIVATE_SEGMENT_SIZE, 6, 1), - KERNEL_CODE_PROPERTY(ENABLE_SGPR_GRID_WORKGROUP_COUNT_X, 7, 1), - KERNEL_CODE_PROPERTY(ENABLE_SGPR_GRID_WORKGROUP_COUNT_Y, 8, 1), - KERNEL_CODE_PROPERTY(ENABLE_SGPR_GRID_WORKGROUP_COUNT_Z, 9, 1), - KERNEL_CODE_PROPERTY(RESERVED, 10, 6), + KERNEL_CODE_PROPERTY(RESERVED, 7, 9), }; #undef KERNEL_CODE_PROPERTY diff --git a/llvm/lib/Target/AMDGPU/AMDGPUArgumentUsageInfo.cpp b/llvm/lib/Target/AMDGPU/AMDGPUArgumentUsageInfo.cpp index dcca3a2fab9..7465cf22b5a 100644 --- a/llvm/lib/Target/AMDGPU/AMDGPUArgumentUsageInfo.cpp +++ b/llvm/lib/Target/AMDGPU/AMDGPUArgumentUsageInfo.cpp @@ -55,9 +55,6 @@ void AMDGPUArgumentUsageInfo::print(raw_ostream &OS, const Module *M) const { << " DispatchID: " << FI.second.DispatchID << " FlatScratchInit: " << FI.second.FlatScratchInit << " PrivateSegmentSize: " << FI.second.PrivateSegmentSize - << " GridWorkgroupCountX: " << FI.second.GridWorkGroupCountX - << " GridWorkgroupCountY: " << FI.second.GridWorkGroupCountY - << " GridWorkgroupCountZ: " << FI.second.GridWorkGroupCountZ << " WorkGroupIDX: " << FI.second.WorkGroupIDX << " WorkGroupIDY: " << FI.second.WorkGroupIDY << " WorkGroupIDZ: " << FI.second.WorkGroupIDZ diff --git a/llvm/lib/Target/AMDGPU/AMDGPUArgumentUsageInfo.h b/llvm/lib/Target/AMDGPU/AMDGPUArgumentUsageInfo.h index bf9635549a8..b2bc4021b46 100644 --- a/llvm/lib/Target/AMDGPU/AMDGPUArgumentUsageInfo.h +++ b/llvm/lib/Target/AMDGPU/AMDGPUArgumentUsageInfo.h @@ -111,9 +111,6 @@ struct AMDGPUFunctionArgInfo { ArgDescriptor DispatchID; ArgDescriptor FlatScratchInit; ArgDescriptor PrivateSegmentSize; - ArgDescriptor GridWorkGroupCountX; - ArgDescriptor GridWorkGroupCountY; - ArgDescriptor GridWorkGroupCountZ; // System SGPRs in kernels. ArgDescriptor WorkGroupIDX; diff --git a/llvm/lib/Target/AMDGPU/AMDGPUAsmPrinter.cpp b/llvm/lib/Target/AMDGPU/AMDGPUAsmPrinter.cpp index 5d6e98a1861..8af37fa1615 100644 --- a/llvm/lib/Target/AMDGPU/AMDGPUAsmPrinter.cpp +++ b/llvm/lib/Target/AMDGPU/AMDGPUAsmPrinter.cpp @@ -360,18 +360,6 @@ uint16_t AMDGPUAsmPrinter::getAmdhsaKernelCodeProperties( KernelCodeProperties |= amdhsa::KERNEL_CODE_PROPERTY_ENABLE_SGPR_FLAT_SCRATCH_INIT; } - if (MFI.hasGridWorkgroupCountX()) { - KernelCodeProperties |= - amdhsa::KERNEL_CODE_PROPERTY_ENABLE_SGPR_GRID_WORKGROUP_COUNT_X; - } - if (MFI.hasGridWorkgroupCountY()) { - KernelCodeProperties |= - amdhsa::KERNEL_CODE_PROPERTY_ENABLE_SGPR_GRID_WORKGROUP_COUNT_Y; - } - if (MFI.hasGridWorkgroupCountZ()) { - KernelCodeProperties |= - amdhsa::KERNEL_CODE_PROPERTY_ENABLE_SGPR_GRID_WORKGROUP_COUNT_Z; - } return KernelCodeProperties; } @@ -1207,21 +1195,6 @@ void AMDGPUAsmPrinter::getAmdKernelCode(amd_kernel_code_t &Out, if (MFI->hasFlatScratchInit()) Out.code_properties |= AMD_CODE_PROPERTY_ENABLE_SGPR_FLAT_SCRATCH_INIT; - if (MFI->hasGridWorkgroupCountX()) { - Out.code_properties |= - AMD_CODE_PROPERTY_ENABLE_SGPR_GRID_WORKGROUP_COUNT_X; - } - - if (MFI->hasGridWorkgroupCountY()) { - Out.code_properties |= - AMD_CODE_PROPERTY_ENABLE_SGPR_GRID_WORKGROUP_COUNT_Y; - } - - if (MFI->hasGridWorkgroupCountZ()) { - Out.code_properties |= - AMD_CODE_PROPERTY_ENABLE_SGPR_GRID_WORKGROUP_COUNT_Z; - } - if (MFI->hasDispatchPtr()) Out.code_properties |= AMD_CODE_PROPERTY_ENABLE_SGPR_DISPATCH_PTR; diff --git a/llvm/lib/Target/AMDGPU/SIMachineFunctionInfo.cpp b/llvm/lib/Target/AMDGPU/SIMachineFunctionInfo.cpp index 0a789dcd090..1b74c140d0a 100644 --- a/llvm/lib/Target/AMDGPU/SIMachineFunctionInfo.cpp +++ b/llvm/lib/Target/AMDGPU/SIMachineFunctionInfo.cpp @@ -35,9 +35,6 @@ SIMachineFunctionInfo::SIMachineFunctionInfo(const MachineFunction &MF) KernargSegmentPtr(false), DispatchID(false), FlatScratchInit(false), - GridWorkgroupCountX(false), - GridWorkgroupCountY(false), - GridWorkgroupCountZ(false), WorkGroupIDX(false), WorkGroupIDY(false), WorkGroupIDZ(false), diff --git a/llvm/lib/Target/AMDGPU/SIMachineFunctionInfo.h b/llvm/lib/Target/AMDGPU/SIMachineFunctionInfo.h index 6a3eae4b128..ef91d1e4307 100644 --- a/llvm/lib/Target/AMDGPU/SIMachineFunctionInfo.h +++ b/llvm/lib/Target/AMDGPU/SIMachineFunctionInfo.h @@ -155,9 +155,6 @@ private: bool KernargSegmentPtr : 1; bool DispatchID : 1; bool FlatScratchInit : 1; - bool GridWorkgroupCountX : 1; - bool GridWorkgroupCountY : 1; - bool GridWorkgroupCountZ : 1; // Feature bits required for inputs passed in system SGPRs. bool WorkGroupIDX : 1; // Always initialized. @@ -336,18 +333,6 @@ public: return FlatScratchInit; } - bool hasGridWorkgroupCountX() const { - return GridWorkgroupCountX; - } - - bool hasGridWorkgroupCountY() const { - return GridWorkgroupCountY; - } - - bool hasGridWorkgroupCountZ() const { - return GridWorkgroupCountZ; - } - bool hasWorkGroupIDX() const { return WorkGroupIDX; } |