diff options
author | Nick Kledzik <kledzik@apple.com> | 2012-06-15 20:37:24 +0000 |
---|---|---|
committer | Nick Kledzik <kledzik@apple.com> | 2012-06-15 20:37:24 +0000 |
commit | 751eb3d2b30d90069b1797a31f8e489f0763c585 (patch) | |
tree | 67c7d197aa0675a358f8e7e45ee5db6b8b571307 | |
parent | d6a27324f979c7f4c086f5d7ee3b2265283a8528 (diff) | |
download | bcm5719-llvm-751eb3d2b30d90069b1797a31f8e489f0763c585.tar.gz bcm5719-llvm-751eb3d2b30d90069b1797a31f8e489f0763c585.zip |
use llvm_unreachable() instead of assert(0) for invalid enum values in switch statements
llvm-svn: 158542
-rw-r--r-- | lld/lib/Core/Resolver.cpp | 2 | ||||
-rw-r--r-- | lld/lib/ReaderWriter/MachO/ReferenceKinds.cpp | 13 | ||||
-rw-r--r-- | lld/lib/ReaderWriter/MachO/SimpleAtoms.hpp | 2 | ||||
-rw-r--r-- | lld/lib/ReaderWriter/MachO/WriterOptionsMachO.cpp | 14 |
4 files changed, 16 insertions, 15 deletions
diff --git a/lld/lib/Core/Resolver.cpp b/lld/lib/Core/Resolver.cpp index d50a772fed3..018cb0a658d 100644 --- a/lld/lib/Core/Resolver.cpp +++ b/lld/lib/Core/Resolver.cpp @@ -359,7 +359,7 @@ void Resolver::MergedFile::addAtom(const Atom& atom) { } else if (const AbsoluteAtom* abAtom = dyn_cast<AbsoluteAtom>(&atom)) { _absoluteAtoms._atoms.push_back(abAtom); } else { - assert(0 && "atom has unknown definition kind"); + llvm_unreachable("atom has unknown definition kind"); } } diff --git a/lld/lib/ReaderWriter/MachO/ReferenceKinds.cpp b/lld/lib/ReaderWriter/MachO/ReferenceKinds.cpp index 83007709ed3..805936b4466 100644 --- a/lld/lib/ReaderWriter/MachO/ReferenceKinds.cpp +++ b/lld/lib/ReaderWriter/MachO/ReferenceKinds.cpp @@ -13,6 +13,7 @@ #include "llvm/ADT/StringRef.h" #include "llvm/ADT/StringSwitch.h" +#include "llvm/Support/ErrorHandling.h" namespace lld { namespace mach_o { @@ -72,7 +73,7 @@ Reference::Kind KindHandler_x86_64::stringToKind(StringRef str) { .Case("subordinateFDE", subordinateFDE) .Case("subordinateLSDA", subordinateLSDA); - assert(0 && "invalid x86_64 Reference kind"); + llvm_unreachable("invalid x86_64 Reference kind"); return 0; } @@ -113,7 +114,7 @@ StringRef KindHandler_x86_64::kindToString(Reference::Kind kind) { case subordinateLSDA: return StringRef("subordinateLSDA"); } - assert(0 && "invalid x86_64 Reference kind"); + llvm_unreachable("invalid x86_64 Reference kind"); return StringRef(); } @@ -197,7 +198,7 @@ Reference::Kind KindHandler_x86::stringToKind(StringRef str) { .Case("lazyTarget", lazyTarget) .Case("lazyImmediate", lazyImmediate); - assert(0 && "invalid x86 Reference kind"); + llvm_unreachable("invalid x86 Reference kind"); return 0; } @@ -222,7 +223,7 @@ StringRef KindHandler_x86::kindToString(Reference::Kind kind) { case subordinateLSDA: return StringRef("subordinateLSDA"); } - assert(0 && "invalid x86 Reference kind"); + llvm_unreachable("invalid x86 Reference kind"); return StringRef(); } @@ -292,7 +293,7 @@ Reference::Kind KindHandler_arm::stringToKind(StringRef str) { .Case("lazyImmediate", lazyImmediate) .Case("subordinateLSDA", subordinateLSDA); - assert(0 && "invalid ARM Reference kind"); + llvm_unreachable("invalid ARM Reference kind"); return 0; } @@ -323,7 +324,7 @@ StringRef KindHandler_arm::kindToString(Reference::Kind kind) { case subordinateLSDA: return StringRef("subordinateLSDA"); } - assert(0 && "invalid ARM Reference kind"); + llvm_unreachable("invalid ARM Reference kind"); return StringRef(); } diff --git a/lld/lib/ReaderWriter/MachO/SimpleAtoms.hpp b/lld/lib/ReaderWriter/MachO/SimpleAtoms.hpp index 498793f4746..0db2e055afe 100644 --- a/lld/lib/ReaderWriter/MachO/SimpleAtoms.hpp +++ b/lld/lib/ReaderWriter/MachO/SimpleAtoms.hpp @@ -45,7 +45,7 @@ public: _absoluteAtoms._atoms.push_back(abAtom); } else { - assert(0 && "atom has unknown definition kind"); + llvm_unreachable("atom has unknown definition kind"); } } diff --git a/lld/lib/ReaderWriter/MachO/WriterOptionsMachO.cpp b/lld/lib/ReaderWriter/MachO/WriterOptionsMachO.cpp index b9094648ad1..9e726a61406 100644 --- a/lld/lib/ReaderWriter/MachO/WriterOptionsMachO.cpp +++ b/lld/lib/ReaderWriter/MachO/WriterOptionsMachO.cpp @@ -41,7 +41,7 @@ StringRef WriterOptionsMachO::archName() const { case arch_armv7: return StringRef("armv7"); } - assert(0 && "unknown arch"); + llvm_unreachable("unknown arch"); return StringRef("???"); } @@ -55,7 +55,7 @@ uint32_t WriterOptionsMachO::cpuType() const { case arch_armv7: return mach_o::CPU_TYPE_ARM; } - assert(0 && "unknown arch"); + llvm_unreachable("unknown arch"); return 0; } @@ -70,7 +70,7 @@ uint32_t WriterOptionsMachO::cpuSubtype() const { case arch_armv7: return mach_o::CPU_SUBTYPE_ARM_V7; } - assert(0 && "unknown arch"); + llvm_unreachable("unknown arch"); return 0; } @@ -84,7 +84,7 @@ uint64_t WriterOptionsMachO::pageZeroSize() const { assert(_pageZeroSize == 0); return 0; } - assert(0 && "unknown outputkind"); + llvm_unreachable("unknown outputkind"); return 0; } @@ -98,7 +98,7 @@ bool WriterOptionsMachO::addEntryPointLoadCommand() const { case outputObjectFile: return false; } - assert(0 && "unknown outputkind"); + llvm_unreachable("unknown outputkind"); return false; } @@ -112,7 +112,7 @@ bool WriterOptionsMachO::addUnixThreadLoadCommand() const { case outputObjectFile: return false; } - assert(0 && "unknown outputkind"); + llvm_unreachable("unknown outputkind"); return false; } @@ -135,7 +135,7 @@ StringRef WriterOptionsMachO::entryPointName() const { case outputObjectFile: return StringRef(); } - assert(0 && "unknown outputkind"); + llvm_unreachable("unknown outputkind"); return StringRef(); } |