summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorKuba Brecka <kuba.brecka@gmail.com>2014-12-16 04:46:15 +0000
committerKuba Brecka <kuba.brecka@gmail.com>2014-12-16 04:46:15 +0000
commit731089bbce16d5d40e0c89c24cbc9923623240c9 (patch)
treed523a9e8c905d8098220adf5febc47077327a444
parent08408ea86ebc526d43de128349925cdba68cf3b0 (diff)
downloadbcm5719-llvm-731089bbce16d5d40e0c89c24cbc9923623240c9.tar.gz
bcm5719-llvm-731089bbce16d5d40e0c89c24cbc9923623240c9.zip
Add an MACOS_VERSION_UNKNOWN_NEWER enum value for OS X versions above 10.10.
We recently had a broken version check because an newer OS X version is treated as MACOS_VERSION_UNKNOWN which is less than all the defined values. Let's have a separate enum value for unknown but newer versions, so the ">=" and "<=" version checks still work even in upcoming OS X releases. Reviewed at http://reviews.llvm.org/D6137 llvm-svn: 224315
-rw-r--r--compiler-rt/lib/sanitizer_common/sanitizer_mac.cc6
-rw-r--r--compiler-rt/lib/sanitizer_common/sanitizer_mac.h1
2 files changed, 6 insertions, 1 deletions
diff --git a/compiler-rt/lib/sanitizer_common/sanitizer_mac.cc b/compiler-rt/lib/sanitizer_common/sanitizer_mac.cc
index 98c5b94112c..3c95cba254b 100644
--- a/compiler-rt/lib/sanitizer_common/sanitizer_mac.cc
+++ b/compiler-rt/lib/sanitizer_common/sanitizer_mac.cc
@@ -298,7 +298,11 @@ MacosVersion GetMacosVersionInternal() {
case '2': return MACOS_VERSION_MOUNTAIN_LION;
case '3': return MACOS_VERSION_MAVERICKS;
case '4': return MACOS_VERSION_YOSEMITE;
- default: return MACOS_VERSION_UNKNOWN;
+ default:
+ if (IsDigit(version[1]))
+ return MACOS_VERSION_UNKNOWN_NEWER;
+ else
+ return MACOS_VERSION_UNKNOWN;
}
}
default: return MACOS_VERSION_UNKNOWN;
diff --git a/compiler-rt/lib/sanitizer_common/sanitizer_mac.h b/compiler-rt/lib/sanitizer_common/sanitizer_mac.h
index 3ed0ed3b00c..9eed905187e 100644
--- a/compiler-rt/lib/sanitizer_common/sanitizer_mac.h
+++ b/compiler-rt/lib/sanitizer_common/sanitizer_mac.h
@@ -27,6 +27,7 @@ enum MacosVersion {
MACOS_VERSION_MOUNTAIN_LION,
MACOS_VERSION_MAVERICKS,
MACOS_VERSION_YOSEMITE,
+ MACOS_VERSION_UNKNOWN_NEWER
};
MacosVersion GetMacosVersion();
OpenPOWER on IntegriCloud