summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJinsong Ji <jji@us.ibm.com>2019-09-29 12:43:46 +0000
committerJinsong Ji <jji@us.ibm.com>2019-09-29 12:43:46 +0000
commit72b544e656b643135246c15cb334d09dca9851ac (patch)
tree78b483717555d86d2b38aeb2e6c8af6a8bf94e02
parent120a5e9a745f931d805d63c6c5313a1aa24d98f5 (diff)
downloadbcm5719-llvm-72b544e656b643135246c15cb334d09dca9851ac.tar.gz
bcm5719-llvm-72b544e656b643135246c15cb334d09dca9851ac.zip
[PowerPC] Fix conditions of assert in PPCAsmPrinter
Summary: g++ build emits warning: llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp:667:77: error: suggest parentheses around ?&&? within ?||? [-Werror=parentheses] assert(MO.isGlobal() || MO.isCPI() || MO.isJTI() || MO.isBlockAddress() && ~~~~~~~~~~~~~~~~~~~~^~ "Unexpected operand type for LWZtoc pseudo."); I believe the intension is to assert all different types, so we should add a parentheses to include all '||'. Reviewers: #powerpc, sfertile, hubert.reinterpretcast, Xiangling_L Reviewed By: Xiangling_L Subscribers: wuzish, nemanjai, hiraditya, kbarton, MaskRay, shchenz, steven.zhang, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D68180 llvm-svn: 373164
-rw-r--r--llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp2
1 files changed, 1 insertions, 1 deletions
diff --git a/llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp b/llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp
index c8f26dd2f14..db30e16d154 100644
--- a/llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp
+++ b/llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp
@@ -664,7 +664,7 @@ void PPCAsmPrinter::EmitInstruction(const MachineInstr *MI) {
TmpInst.setOpcode(PPC::LWZ);
const MachineOperand &MO = MI->getOperand(1);
- assert(MO.isGlobal() || MO.isCPI() || MO.isJTI() || MO.isBlockAddress() &&
+ assert((MO.isGlobal() || MO.isCPI() || MO.isJTI() || MO.isBlockAddress()) &&
"Unexpected operand type for LWZtoc pseudo.");
// Map the operand to its corresponding MCSymbol.
OpenPOWER on IntegriCloud