summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorBenjamin Kramer <benny.kra@googlemail.com>2016-07-21 14:13:45 +0000
committerBenjamin Kramer <benny.kra@googlemail.com>2016-07-21 14:13:45 +0000
commit7035cbf8ebf2acb00cd17fd8c2004d8d884cfb37 (patch)
tree191533b04e39e5f53cc285f4550543c0a2697834
parentc8e20b1150356dc8796778791a7eeb27c8dc6106 (diff)
downloadbcm5719-llvm-7035cbf8ebf2acb00cd17fd8c2004d8d884cfb37.tar.gz
bcm5719-llvm-7035cbf8ebf2acb00cd17fd8c2004d8d884cfb37.zip
[clang-tidy] Avoid duplicated DenseMap lookup.
The std::string is still constructed on demand. No functionality change intended. llvm-svn: 276282
-rw-r--r--clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp3
1 files changed, 1 insertions, 2 deletions
diff --git a/clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp b/clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp
index d0a7e5f5080..619c0c18fd5 100644
--- a/clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp
+++ b/clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp
@@ -176,8 +176,7 @@ DiagnosticBuilder ClangTidyContext::diag(
assert(Loc.isValid());
unsigned ID = DiagEngine->getDiagnosticIDs()->getCustomDiagID(
Level, (Description + " [" + CheckName + "]").str());
- if (CheckNamesByDiagnosticID.count(ID) == 0)
- CheckNamesByDiagnosticID.insert(std::make_pair(ID, CheckName.str()));
+ CheckNamesByDiagnosticID.try_emplace(ID, CheckName);
return DiagEngine->Report(Loc, ID);
}
OpenPOWER on IntegriCloud