diff options
| author | Eric Christopher <echristo@apple.com> | 2010-08-08 01:37:14 +0000 |
|---|---|---|
| committer | Eric Christopher <echristo@apple.com> | 2010-08-08 01:37:14 +0000 |
| commit | 6ff7161d51a9e5a43fd7e69ab2df69a67fcd12e3 (patch) | |
| tree | 5b0dbf8bfe877ba9e827ed0600dda15dccf69fcb | |
| parent | 8aa19b05eed2cb72491fc2b69dc4c8913c3e58f9 (diff) | |
| download | bcm5719-llvm-6ff7161d51a9e5a43fd7e69ab2df69a67fcd12e3.tar.gz bcm5719-llvm-6ff7161d51a9e5a43fd7e69ab2df69a67fcd12e3.zip | |
Thread local variables aren't considered common linkage.
llvm-svn: 110530
| -rw-r--r-- | clang/lib/CodeGen/CodeGenModule.cpp | 3 | ||||
| -rw-r--r-- | clang/test/CodeGen/thread-specifier.c | 1 |
2 files changed, 3 insertions, 1 deletions
diff --git a/clang/lib/CodeGen/CodeGenModule.cpp b/clang/lib/CodeGen/CodeGenModule.cpp index 297aa4524e3..6283b744c3e 100644 --- a/clang/lib/CodeGen/CodeGenModule.cpp +++ b/clang/lib/CodeGen/CodeGenModule.cpp @@ -1201,7 +1201,8 @@ void CodeGenModule::EmitGlobalVarDefinition(const VarDecl *D) { GV->setLinkage(llvm::GlobalVariable::WeakAnyLinkage); else if (!getLangOptions().CPlusPlus && !CodeGenOpts.NoCommon && !D->hasExternalStorage() && !D->getInit() && - !D->getAttr<SectionAttr>()) { + !D->getAttr<SectionAttr>() && !D->isThreadSpecified()) { + // Thread local vars aren't considered common linkage. GV->setLinkage(llvm::GlobalVariable::CommonLinkage); // common vars aren't constant even if declared const. GV->setConstant(false); diff --git a/clang/test/CodeGen/thread-specifier.c b/clang/test/CodeGen/thread-specifier.c index b1e1ed84647..a16103f08f6 100644 --- a/clang/test/CodeGen/thread-specifier.c +++ b/clang/test/CodeGen/thread-specifier.c @@ -1,4 +1,5 @@ // RUN: %clang_cc1 -triple i686-pc-linux-gnu -emit-llvm -o - %s | grep thread_local | count 4 +// RUN: %clang_cc1 -triple i686-pc-linux-gnu -emit-llvm -o - %s | not grep common __thread int a; extern __thread int b; |
