diff options
| author | Joel E. Denny <jdenny.ornl@gmail.com> | 2019-11-19 10:54:21 -0500 |
|---|---|---|
| committer | Joel E. Denny <jdenny.ornl@gmail.com> | 2019-11-19 12:08:54 -0500 |
| commit | 6e418decd936a3e22dec5cebc77ecb86dc7f37c3 (patch) | |
| tree | 0c983dfa2c2b336e4e557ae212c7b61cc82c5347 | |
| parent | 6b0eb5a6727590472e2e9cbf65fa2d7c3a18d2b5 (diff) | |
| download | bcm5719-llvm-6e418decd936a3e22dec5cebc77ecb86dc7f37c3.tar.gz bcm5719-llvm-6e418decd936a3e22dec5cebc77ecb86dc7f37c3.zip | |
[FileCheck] Use lit's internal shell for the test suite
An advantage is that there are less portability concerns when writing
tests. For example, `-u` is not supported by all implementations of
`env`, but lit's internal shell provides its own `env` that supports
`-u`.
A disadvantage is that some shell constructs, such as parentheses, are
not supported, but FileCheck's test suite currently doesn't require
such constructs.
For comparison, lit configures its test suite in the same manner. See
`llvm/utils/lit/tests/lit.cfg`.
Reviewed By: rnk
Differential Revision: https://reviews.llvm.org/D70278
| -rw-r--r-- | llvm/test/FileCheck/lit.local.cfg | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/llvm/test/FileCheck/lit.local.cfg b/llvm/test/FileCheck/lit.local.cfg index 307da456c38..1191450c655 100644 --- a/llvm/test/FileCheck/lit.local.cfg +++ b/llvm/test/FileCheck/lit.local.cfg @@ -1,3 +1,8 @@ +import lit + +# Use lit's internal shell to help guarantee test portability. +config.test_format = lit.formats.ShTest(execute_external=False) + # Unset environment variables that the FileCheck tests # expect not to be set. file_check_expected_unset_vars = [ |
