diff options
| author | Jonas Devlieghere <jonas@devlieghere.com> | 2019-08-23 04:11:38 +0000 |
|---|---|---|
| committer | Jonas Devlieghere <jonas@devlieghere.com> | 2019-08-23 04:11:38 +0000 |
| commit | 6c9dc12caaffc4bb2d9d836b890dc27b7a8c167a (patch) | |
| tree | 826397538491a269fd3acdaec4d3edaebdeab4f6 | |
| parent | 2a52583d670046f05053fcd7da978e060205b372 (diff) | |
| download | bcm5719-llvm-6c9dc12caaffc4bb2d9d836b890dc27b7a8c167a.tar.gz bcm5719-llvm-6c9dc12caaffc4bb2d9d836b890dc27b7a8c167a.zip | |
[LLDB] Address post-commit code review feedback.
This patch addresses Adrian McCarthy's code review feedback in
https://reviews.llvm.org/D66447
llvm-svn: 369731
| -rw-r--r-- | lldb/packages/Python/lldbsuite/test/lang/cpp/char8_t/main.cpp | 2 | ||||
| -rw-r--r-- | lldb/source/Symbol/ClangASTContext.cpp | 4 |
2 files changed, 2 insertions, 4 deletions
diff --git a/lldb/packages/Python/lldbsuite/test/lang/cpp/char8_t/main.cpp b/lldb/packages/Python/lldbsuite/test/lang/cpp/char8_t/main.cpp index b257ae2d794..b73ba0c4e61 100644 --- a/lldb/packages/Python/lldbsuite/test/lang/cpp/char8_t/main.cpp +++ b/lldb/packages/Python/lldbsuite/test/lang/cpp/char8_t/main.cpp @@ -1,5 +1,3 @@ -#include <cstring> - char8_t a = u8'a'; const char8_t* ab = u8"你好"; char8_t abc[9] = u8"你好"; diff --git a/lldb/source/Symbol/ClangASTContext.cpp b/lldb/source/Symbol/ClangASTContext.cpp index d1d9a7399f3..faeaf78339b 100644 --- a/lldb/source/Symbol/ClangASTContext.cpp +++ b/lldb/source/Symbol/ClangASTContext.cpp @@ -1390,9 +1390,9 @@ CompilerType ClangASTContext::GetBuiltinTypeForDWARFEncodingAndBitSize( if (type_name) { if (streq(type_name, "char16_t")) return CompilerType(this, ast->Char16Ty.getAsOpaquePtr()); - else if (streq(type_name, "char32_t")) + if (streq(type_name, "char32_t")) return CompilerType(this, ast->Char32Ty.getAsOpaquePtr()); - else if (streq(type_name, "char8_t")) + if (streq(type_name, "char8_t")) return CompilerType(this, ast->Char8Ty.getAsOpaquePtr()); } break; |

