diff options
| author | Chris Bieneman <beanz@apple.com> | 2015-11-18 22:49:26 +0000 |
|---|---|---|
| committer | Chris Bieneman <beanz@apple.com> | 2015-11-18 22:49:26 +0000 |
| commit | 6b43f1f40f644b896f44078872c0b93ec3afef67 (patch) | |
| tree | 66cd3f4e973091a145649097d1adb0b4056e22c0 | |
| parent | 6e644abd46ec6f339e6e639e30566816e75694a7 (diff) | |
| download | bcm5719-llvm-6b43f1f40f644b896f44078872c0b93ec3afef67.tar.gz bcm5719-llvm-6b43f1f40f644b896f44078872c0b93ec3afef67.zip | |
[CMake] Support -fvisibility-inlines-hidden when LLVM_ENABLE_PIC=Off
I'm unaware of any reasons why -fvisibility-inlines-hidden would depend on PIC, and since autoconf supports this flag without PIC, we should support it in CMake too.
llvm-svn: 253517
| -rw-r--r-- | llvm/cmake/modules/HandleLLVMOptions.cmake | 13 |
1 files changed, 6 insertions, 7 deletions
diff --git a/llvm/cmake/modules/HandleLLVMOptions.cmake b/llvm/cmake/modules/HandleLLVMOptions.cmake index 82a4084ffd9..e86e1a169ce 100644 --- a/llvm/cmake/modules/HandleLLVMOptions.cmake +++ b/llvm/cmake/modules/HandleLLVMOptions.cmake @@ -181,16 +181,15 @@ if( LLVM_ENABLE_PIC ) # On Windows all code is PIC. MinGW warns if -fPIC is used. else() add_flag_or_print_warning("-fPIC" FPIC) - - if( WIN32 OR CYGWIN) - # MinGW warns if -fvisibility-inlines-hidden is used. - else() - check_cxx_compiler_flag("-fvisibility-inlines-hidden" SUPPORTS_FVISIBILITY_INLINES_HIDDEN_FLAG) - append_if(SUPPORTS_FVISIBILITY_INLINES_HIDDEN_FLAG "-fvisibility-inlines-hidden" CMAKE_CXX_FLAGS) - endif() endif() endif() +if(NOT WIN32 AND NOT CYGWIN) + # MinGW warns if -fvisibility-inlines-hidden is used. + check_cxx_compiler_flag("-fvisibility-inlines-hidden" SUPPORTS_FVISIBILITY_INLINES_HIDDEN_FLAG) + append_if(SUPPORTS_FVISIBILITY_INLINES_HIDDEN_FLAG "-fvisibility-inlines-hidden" CMAKE_CXX_FLAGS) +endif() + if( CMAKE_SIZEOF_VOID_P EQUAL 8 AND NOT WIN32 ) # TODO: support other platforms and toolchains. if( LLVM_BUILD_32_BITS ) |
