diff options
| author | Johannes Doerfert <jdoerfert@anl.gov> | 2019-06-04 20:34:43 +0000 |
|---|---|---|
| committer | Johannes Doerfert <jdoerfert@anl.gov> | 2019-06-04 20:34:43 +0000 |
| commit | 6b432dca5d4aa6bea8a39e7858f8cfd19f2b87ed (patch) | |
| tree | d0438462d908535c0dc778db5d36fbf8f7d9d52b | |
| parent | 40107ce753ff172f76ceb67da2817868f952c003 (diff) | |
| download | bcm5719-llvm-6b432dca5d4aa6bea8a39e7858f8cfd19f2b87ed.tar.gz bcm5719-llvm-6b432dca5d4aa6bea8a39e7858f8cfd19f2b87ed.zip | |
[SelectionDAG][FIX] Allow "returned" arguments to be bit-casted
Summary:
An argument that is return by a function but bit-casted before can still
be annotated as "returned". Make sure we do not crash for this case.
Reviewers: sunfish, stephenwlin, niravd, arsenm
Subscribers: wdng, hiraditya, bollu, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D59917
llvm-svn: 362546
| -rw-r--r-- | llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp | 7 | ||||
| -rw-r--r-- | llvm/test/CodeGen/X86/arg_returned_bitcast.ll | 12 |
2 files changed, 17 insertions, 2 deletions
diff --git a/llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp b/llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp index da06ac7a414..4f7257d4a15 100644 --- a/llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp +++ b/llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp @@ -9111,8 +9111,11 @@ TargetLowering::LowerCallTo(TargetLowering::CallLoweringInfo &CLI) const { // for now. if (Args[i].IsReturned && !Op.getValueType().isVector() && CanLowerReturn) { - assert(CLI.RetTy == Args[i].Ty && RetTys.size() == NumValues && - "unexpected use of 'returned'"); + assert((CLI.RetTy == Args[i].Ty || + (CLI.RetTy->isPointerTy() && Args[i].Ty->isPointerTy() && + CLI.RetTy->getPointerAddressSpace() == + Args[i].Ty->getPointerAddressSpace())) && + RetTys.size() == NumValues && "unexpected use of 'returned'"); // Before passing 'returned' to the target lowering code, ensure that // either the register MVT and the actual EVT are the same size or that // the return value and argument are extended in the same way; in these diff --git a/llvm/test/CodeGen/X86/arg_returned_bitcast.ll b/llvm/test/CodeGen/X86/arg_returned_bitcast.ll new file mode 100644 index 00000000000..2287c129b75 --- /dev/null +++ b/llvm/test/CodeGen/X86/arg_returned_bitcast.ll @@ -0,0 +1,12 @@ +; RUN: llc < %s -mtriple=i686-unknown-linux-gnu | FileCheck %s + +; Test that the "returned" attribute "works" even if there is a bitcast between +; the argument and return value. + +declare double* @bar(i8* returned) + +define double* @foo(i8*) { + %r = tail call double* @bar(i8* %0) +; CHECK: jmp bar + ret double* %r +} |
