summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorVedant Kumar <vsk@apple.com>2016-07-15 22:44:54 +0000
committerVedant Kumar <vsk@apple.com>2016-07-15 22:44:54 +0000
commit6ab6b36475a4339e4a788b9f8ea40b25f6c9d033 (patch)
treee395e1ae22175ac791add43fef955747f939f97e
parent7a4bd83c6cc1a3c6b12ee9f77c22fe4da650730a (diff)
downloadbcm5719-llvm-6ab6b36475a4339e4a788b9f8ea40b25f6c9d033.tar.gz
bcm5719-llvm-6ab6b36475a4339e4a788b9f8ea40b25f6c9d033.zip
[llvm-cov] Document a few private fields of CodeCoverageTool (NFC)
llvm-svn: 275639
-rw-r--r--llvm/tools/llvm-cov/CodeCoverage.cpp3
-rw-r--r--llvm/tools/llvm-cov/CoverageViewOptions.h2
2 files changed, 4 insertions, 1 deletions
diff --git a/llvm/tools/llvm-cov/CodeCoverage.cpp b/llvm/tools/llvm-cov/CodeCoverage.cpp
index ed48c28c0fc..59cb708a42c 100644
--- a/llvm/tools/llvm-cov/CodeCoverage.cpp
+++ b/llvm/tools/llvm-cov/CodeCoverage.cpp
@@ -101,11 +101,14 @@ public:
std::string CoverageArch;
private:
+ /// File paths (absolute, or otherwise) to input source files.
std::vector<std::string> CollectedPaths;
+ /// Errors and warnings which have not been printed.
std::mutex DeferredMessagesLock;
std::vector<std::string> DeferredMessages;
+ /// A container for input source file buffers.
std::mutex LoadedSourceFilesLock;
std::vector<std::pair<std::string, std::unique_ptr<MemoryBuffer>>>
LoadedSourceFiles;
diff --git a/llvm/tools/llvm-cov/CoverageViewOptions.h b/llvm/tools/llvm-cov/CoverageViewOptions.h
index 873eae885a7..eafc0cfd165 100644
--- a/llvm/tools/llvm-cov/CoverageViewOptions.h
+++ b/llvm/tools/llvm-cov/CoverageViewOptions.h
@@ -40,7 +40,7 @@ struct CoverageViewOptions {
}
/// \brief Check if an output directory has been specified.
- bool hasOutputDirectory() const { return ShowOutputDirectory != ""; }
+ bool hasOutputDirectory() const { return !ShowOutputDirectory.empty(); }
};
}
OpenPOWER on IntegriCloud