diff options
author | Julian Lettner <jlettner@apple.com> | 2019-02-15 22:12:36 +0000 |
---|---|---|
committer | Julian Lettner <jlettner@apple.com> | 2019-02-15 22:12:36 +0000 |
commit | 68c6764c20dfc486b9f0283a06b5f44b8c7a69f9 (patch) | |
tree | bae6cde72ebd6d2bd77b1f7105e76dabe565cee8 | |
parent | db2f084aa9dc062f95c9d630be9acfa7b8394b35 (diff) | |
download | bcm5719-llvm-68c6764c20dfc486b9f0283a06b5f44b8c7a69f9.tar.gz bcm5719-llvm-68c6764c20dfc486b9f0283a06b5f44b8c7a69f9.zip |
[Sanitizer] iOS: Pull up parallelism_group handling into common.lit.config
Serial execution on iOS devices is not specific to sanitizers. We want
to throttle all on-device tests. Pull the setting of the
parallelism_group up into the common lit configuration file.
Rename `darwin-ios-device-sanitizer` to `ios-device`. This group is not
specific to sanitizers and (theoretically) independent from the host OS.
Note that we don't support running unit tests on-device (there are no
configurations generated for that). If that ever changes, we also need
this configuration in `unittests/lit.common.unit.cfg`.
Reviewers: delcypher
Differential Revision: https://reviews.llvm.org/D58209
llvm-svn: 354179
-rw-r--r-- | compiler-rt/test/asan/lit.cfg | 2 | ||||
-rw-r--r-- | compiler-rt/test/fuzzer/lit.cfg | 2 | ||||
-rw-r--r-- | compiler-rt/test/lit.common.cfg | 7 | ||||
-rw-r--r-- | compiler-rt/test/sanitizer_common/lit.common.cfg | 2 | ||||
-rw-r--r-- | compiler-rt/test/tsan/lit.cfg | 2 | ||||
-rw-r--r-- | compiler-rt/test/ubsan/lit.common.cfg | 5 |
6 files changed, 3 insertions, 17 deletions
diff --git a/compiler-rt/test/asan/lit.cfg b/compiler-rt/test/asan/lit.cfg index 3deb4ccc5f9..ccdf0716c98 100644 --- a/compiler-rt/test/asan/lit.cfg +++ b/compiler-rt/test/asan/lit.cfg @@ -223,5 +223,3 @@ if config.host_os not in ['Linux', 'Darwin', 'FreeBSD', 'SunOS', 'Windows', 'Net if config.host_os == 'Darwin': if config.target_arch in ["x86_64", "x86_64h"]: config.parallelism_group = "darwin-64bit-sanitizer" - elif config.apple_platform != "osx" and not config.apple_platform.endswith("sim"): - config.parallelism_group = "darwin-ios-device-sanitizer" diff --git a/compiler-rt/test/fuzzer/lit.cfg b/compiler-rt/test/fuzzer/lit.cfg index 2ce347356da..eff9a5508fa 100644 --- a/compiler-rt/test/fuzzer/lit.cfg +++ b/compiler-rt/test/fuzzer/lit.cfg @@ -129,5 +129,3 @@ config.substitutions.append(('%env_asan_opts=', if config.host_os == 'Darwin': if config.target_arch in ["x86_64", "x86_64h"]: config.parallelism_group = "darwin-64bit-sanitizer" - elif config.apple_platform != "osx" and not config.apple_platform.endswith("sim"): - config.parallelism_group = "darwin-ios-device-sanitizer" diff --git a/compiler-rt/test/lit.common.cfg b/compiler-rt/test/lit.common.cfg index 6965fa6f418..40b377eb0cb 100644 --- a/compiler-rt/test/lit.common.cfg +++ b/compiler-rt/test/lit.common.cfg @@ -407,12 +407,11 @@ if platform.system() == 'Windows': if platform.system() == 'Darwin': lit_config.parallelism_groups["darwin-64bit-sanitizer"] = 3 -# The current implementation of the tools in sanitizer_common/ios_comamnds -# do not support parallel execution so force sequential execution of the -# tests on iOS devices. +# Force sequential execution when running tests on iOS devices. if config.host_os == 'Darwin' and config.apple_platform != "osx" and not config.apple_platform.endswith("sim"): lit_config.warning("iOS device test cases being run sequentially") - lit_config.parallelism_groups["darwin-ios-device-sanitizer"] = 1 + lit_config.parallelism_groups["ios-device"] = 1 + config.parallelism_group = "ios-device" # Multiple substitutions are necessary to support multiple shared objects used # at once. diff --git a/compiler-rt/test/sanitizer_common/lit.common.cfg b/compiler-rt/test/sanitizer_common/lit.common.cfg index f7723ecbef2..323c1ef2683 100644 --- a/compiler-rt/test/sanitizer_common/lit.common.cfg +++ b/compiler-rt/test/sanitizer_common/lit.common.cfg @@ -74,5 +74,3 @@ if config.host_os not in ['Linux', 'Darwin', 'NetBSD', 'FreeBSD']: if config.host_os == 'Darwin': if config.target_arch in ["x86_64", "x86_64h"]: config.parallelism_group = "darwin-64bit-sanitizer" - elif config.apple_platform != "osx" and not config.apple_platform.endswith("sim"): - config.parallelism_group = "darwin-ios-device-sanitizer" diff --git a/compiler-rt/test/tsan/lit.cfg b/compiler-rt/test/tsan/lit.cfg index 233d273f313..114e325ce78 100644 --- a/compiler-rt/test/tsan/lit.cfg +++ b/compiler-rt/test/tsan/lit.cfg @@ -88,5 +88,3 @@ if config.android: if config.host_os == 'Darwin': if config.target_arch in ["x86_64", "x86_64h"]: config.parallelism_group = "darwin-64bit-sanitizer" - elif config.apple_platform != "osx" and not config.apple_platform.endswith("sim"): - config.parallelism_group = "darwin-ios-device-sanitizer" diff --git a/compiler-rt/test/ubsan/lit.common.cfg b/compiler-rt/test/ubsan/lit.common.cfg index 9a7a8900e34..e20832bd655 100644 --- a/compiler-rt/test/ubsan/lit.common.cfg +++ b/compiler-rt/test/ubsan/lit.common.cfg @@ -74,8 +74,3 @@ if config.host_os not in ['Linux', 'Darwin', 'FreeBSD', 'Windows', 'NetBSD', 'Su config.available_features.add('arch=' + config.target_arch) config.excludes = ['Inputs'] - -# Limit parallelism if necessary -if config.host_os == 'Darwin': - if config.apple_platform != "osx" and not config.apple_platform.endswith("sim"): - config.parallelism_group = "darwin-ios-device-sanitizer" |