diff options
| author | Eric Christopher <echristo@apple.com> | 2010-05-17 02:13:02 +0000 |
|---|---|---|
| committer | Eric Christopher <echristo@apple.com> | 2010-05-17 02:13:02 +0000 |
| commit | 68b1bbe66ab2ffb2dceb10af943ab1fe001fb537 (patch) | |
| tree | edbb4f28feb7319b07920f30b1f0b8c7f7e693c0 | |
| parent | 8044c989d1f9199598ec1b6fb1ba7d99c6b2ca2a (diff) | |
| download | bcm5719-llvm-68b1bbe66ab2ffb2dceb10af943ab1fe001fb537.tar.gz bcm5719-llvm-68b1bbe66ab2ffb2dceb10af943ab1fe001fb537.zip | |
Assume that we'll handle mangling the symbols earlier and just put the
symbol to the file as we have it. Simplifies out tbss handling.
llvm-svn: 103928
| -rw-r--r-- | llvm/lib/MC/MCAsmStreamer.cpp | 9 | ||||
| -rw-r--r-- | llvm/lib/MC/MCParser/AsmParser.cpp | 8 | ||||
| -rw-r--r-- | llvm/test/MC/AsmParser/directive_tbss.s | 2 |
3 files changed, 7 insertions, 12 deletions
diff --git a/llvm/lib/MC/MCAsmStreamer.cpp b/llvm/lib/MC/MCAsmStreamer.cpp index 62735ad3f3a..4f7699ca99d 100644 --- a/llvm/lib/MC/MCAsmStreamer.cpp +++ b/llvm/lib/MC/MCAsmStreamer.cpp @@ -363,14 +363,13 @@ void MCAsmStreamer::EmitZerofill(const MCSection *Section, MCSymbol *Symbol, EmitEOL(); } -// .tbss sym$tlv$init, size, align +// .tbss sym, size, align +// This depends that the symbol has already been mangled from the original, +// e.g. _a. void MCAsmStreamer::EmitTBSSSymbol(MCSymbol *Symbol, uint64_t Size, unsigned ByteAlignment) { assert(Symbol != NULL && "Symbol shouldn't be NULL!"); - OS << ".tbss "; - - // This is a mach-o specific directive and the name requires some mangling. - OS << *Symbol << "$tlv$init, " << Size; + OS << ".tbss " << *Symbol << ", " << Size; // Output align if we have it. if (ByteAlignment != 0) OS << ", " << Log2_32(ByteAlignment); diff --git a/llvm/lib/MC/MCParser/AsmParser.cpp b/llvm/lib/MC/MCParser/AsmParser.cpp index 18977de8adb..e5af357de34 100644 --- a/llvm/lib/MC/MCParser/AsmParser.cpp +++ b/llvm/lib/MC/MCParser/AsmParser.cpp @@ -1436,13 +1436,9 @@ bool AsmParser::ParseDirectiveDarwinTBSS() { StringRef Name; if (ParseIdentifier(Name)) return TokError("expected identifier in directive"); - - // Demangle the name output. The trailing characters are guaranteed to be - // $tlv$init so just strip that off. - StringRef DemName = Name.substr(0, Name.size() - strlen("$tlv$init")); - + // Handle the identifier as the key symbol. - MCSymbol *Sym = CreateSymbol(DemName); + MCSymbol *Sym = CreateSymbol(Name); if (Lexer.isNot(AsmToken::Comma)) return TokError("unexpected token in directive"); diff --git a/llvm/test/MC/AsmParser/directive_tbss.s b/llvm/test/MC/AsmParser/directive_tbss.s index 01ba17be263..38d3a3e1fcf 100644 --- a/llvm/test/MC/AsmParser/directive_tbss.s +++ b/llvm/test/MC/AsmParser/directive_tbss.s @@ -1,4 +1,4 @@ -# RUN: llvm-mc -triple i386-unknown-unknown %s | FileCheck %s +# RUN: llvm-mc -triple i386-unknown-darwin %s | FileCheck %s # CHECK: .tbss _a$tlv$init, 4 # CHECK: .tbss _b$tlv$init, 4, 3 |
