diff options
| author | Daniel Jasper <djasper@google.com> | 2014-11-18 23:48:01 +0000 |
|---|---|---|
| committer | Daniel Jasper <djasper@google.com> | 2014-11-18 23:48:01 +0000 |
| commit | 6761b42b90f931aa59b19b31d014e762dc23dc93 (patch) | |
| tree | a3adaaf4867c3111fad762ebb5c1c6c1bc04e396 | |
| parent | e15f86cb1250e3dd3b102d536bf6a17ba8a18231 (diff) | |
| download | bcm5719-llvm-6761b42b90f931aa59b19b31d014e762dc23dc93.tar.gz bcm5719-llvm-6761b42b90f931aa59b19b31d014e762dc23dc93.zip | |
clang-format: Fix space between generic type parameter and square
bracket
Before:
public Foo<X, Y> [] foos;
After:
public Foo<X, Y>[] foos;
Patch by Harry Terkelsen. Thank you!
llvm-svn: 222283
| -rw-r--r-- | clang/lib/Format/TokenAnnotator.cpp | 2 | ||||
| -rw-r--r-- | clang/unittests/Format/FormatTestJava.cpp | 3 |
2 files changed, 5 insertions, 0 deletions
diff --git a/clang/lib/Format/TokenAnnotator.cpp b/clang/lib/Format/TokenAnnotator.cpp index dfd880aa997..fdb1179b579 100644 --- a/clang/lib/Format/TokenAnnotator.cpp +++ b/clang/lib/Format/TokenAnnotator.cpp @@ -1677,6 +1677,8 @@ bool TokenAnnotator::spaceRequiredBetween(const AnnotatedLine &Line, Left.MatchingParen->Previous->is(tok::period)) // A.<B>DoSomething(); return false; + if (Left.Type == TT_TemplateCloser && Right.is(tok::l_square)) + return false; return true; } diff --git a/clang/unittests/Format/FormatTestJava.cpp b/clang/unittests/Format/FormatTestJava.cpp index eecac0f3fcd..d60ab965b9d 100644 --- a/clang/unittests/Format/FormatTestJava.cpp +++ b/clang/unittests/Format/FormatTestJava.cpp @@ -217,6 +217,9 @@ TEST_F(FormatTestJava, Generics) { verifyFormat("public static <R> ArrayList<R> get() {\n}"); verifyFormat("<T extends B> T getInstance(Class<T> type);"); verifyFormat("Function<F, ? extends T> function;"); + + verifyFormat("private Foo<X, Y>[] foos;"); + verifyFormat("Foo<X, Y>[] foos = this.foos;"); } TEST_F(FormatTestJava, StringConcatenation) { |

