diff options
author | Richard Mitton <richard@codersnotes.com> | 2013-10-17 22:36:28 +0000 |
---|---|---|
committer | Richard Mitton <richard@codersnotes.com> | 2013-10-17 22:36:28 +0000 |
commit | 665068b379fd4be0b0bc11539616dc0b37064639 (patch) | |
tree | cdfaaf939ec27afcd9e0389f97c5cd5332b9f745 | |
parent | 52b4b6cddc1eebae2e9ffa2fcc8db2a382dc5277 (diff) | |
download | bcm5719-llvm-665068b379fd4be0b0bc11539616dc0b37064639.tar.gz bcm5719-llvm-665068b379fd4be0b0bc11539616dc0b37064639.zip |
Removed unnecessary call to OpenFirstAvailableMaster.
::Fork already does this internally, so this was simply leaking file handles.
This fixes the problem where the test suite would occasionally run out of file handles.
llvm-svn: 192929
-rw-r--r-- | lldb/source/Plugins/Process/FreeBSD/ProcessMonitor.cpp | 8 | ||||
-rw-r--r-- | lldb/source/Plugins/Process/Linux/ProcessMonitor.cpp | 8 |
2 files changed, 0 insertions, 16 deletions
diff --git a/lldb/source/Plugins/Process/FreeBSD/ProcessMonitor.cpp b/lldb/source/Plugins/Process/FreeBSD/ProcessMonitor.cpp index c0fe3cbb971..12ae4712d53 100644 --- a/lldb/source/Plugins/Process/FreeBSD/ProcessMonitor.cpp +++ b/lldb/source/Plugins/Process/FreeBSD/ProcessMonitor.cpp @@ -857,14 +857,6 @@ ProcessMonitor::Launch(LaunchArgs *args) if (envp == NULL || envp[0] == NULL) envp = const_cast<const char **>(environ); - // Pseudo terminal setup. - if (!terminal.OpenFirstAvailableMaster(O_RDWR | O_NOCTTY, err_str, err_len)) - { - args->m_error.SetErrorToGenericError(); - args->m_error.SetErrorString("Could not open controlling TTY."); - goto FINISH; - } - if ((pid = terminal.Fork(err_str, err_len)) == -1) { args->m_error.SetErrorToGenericError(); diff --git a/lldb/source/Plugins/Process/Linux/ProcessMonitor.cpp b/lldb/source/Plugins/Process/Linux/ProcessMonitor.cpp index bda0cb33097..0f79034bb7c 100644 --- a/lldb/source/Plugins/Process/Linux/ProcessMonitor.cpp +++ b/lldb/source/Plugins/Process/Linux/ProcessMonitor.cpp @@ -1171,14 +1171,6 @@ ProcessMonitor::Launch(LaunchArgs *args) if (envp == NULL || envp[0] == NULL) envp = const_cast<const char **>(environ); - // Pseudo terminal setup. - if (!terminal.OpenFirstAvailableMaster(O_RDWR | O_NOCTTY, err_str, err_len)) - { - args->m_error.SetErrorToGenericError(); - args->m_error.SetErrorString("Could not open controlling TTY."); - goto FINISH; - } - if ((pid = terminal.Fork(err_str, err_len)) == -1) { args->m_error.SetErrorToGenericError(); |