summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorFangrui Song <maskray@google.com>2019-11-18 09:06:14 -0800
committerFangrui Song <maskray@google.com>2019-11-18 09:06:14 -0800
commit63f0f54c89fba0dec12d4e169313d4b527348b52 (patch)
tree123b570cbfbe3dc9ad6364f35227e7cea2261111
parentc85fa79d3663ecb3117e178b2a79ffa721d18e32 (diff)
downloadbcm5719-llvm-63f0f54c89fba0dec12d4e169313d4b527348b52.tar.gz
bcm5719-llvm-63f0f54c89fba0dec12d4e169313d4b527348b52.zip
[yaml2obj][test] Move tests to binary format specific subdirectories
Create COFF/, ELF/, and Minidump and move tests there. Also * Rename `*.test` to `*.yaml` * For yaml2obj RUN lines, use `-o %t` instead of `> %t` for consistency. We still have tests that check stdout is the default output, e.g. multi-doc.test * Update tests to consistently use `##` for comments. `#` is for RUN and CHECK lines. * Merge symboless-relocation.yaml and invalid-symboless-relocation.yaml to ELF/relocation-implicit-symbol-index.test Reviewed By: grimar, jhenderson Differential Revision: https://reviews.llvm.org/D70264
-rw-r--r--llvm/test/tools/yaml2obj/COFF/basic-arm64.yaml (renamed from llvm/test/tools/yaml2obj/coff-arm64.yaml)36
-rw-r--r--llvm/test/tools/yaml2obj/COFF/invalid-alignment.yaml (renamed from llvm/test/tools/yaml2obj/coff-invalid-alignment.test)2
-rw-r--r--llvm/test/tools/yaml2obj/COFF/symbol-index.yaml (renamed from llvm/test/tools/yaml2obj/coff-symbol-index.yaml)16
-rw-r--r--llvm/test/tools/yaml2obj/ELF/abiversion.yaml (renamed from llvm/test/tools/yaml2obj/elf-abiversion.yaml)4
-rw-r--r--llvm/test/tools/yaml2obj/ELF/class-endianness.yaml (renamed from llvm/test/tools/yaml2obj/elf-class-endianness.test)0
-rw-r--r--llvm/test/tools/yaml2obj/ELF/comdat-broken-info.yaml (renamed from llvm/test/tools/yaml2obj/elf-comdat-broken-info.yaml)0
-rw-r--r--llvm/test/tools/yaml2obj/ELF/comdat-broken-members.yaml (renamed from llvm/test/tools/yaml2obj/elf-comdat-broken-members.yaml)0
-rw-r--r--llvm/test/tools/yaml2obj/ELF/comdat-broken.yaml (renamed from llvm/test/tools/yaml2obj/elf-comdat-broken.yaml)0
-rw-r--r--llvm/test/tools/yaml2obj/ELF/custom-fill.yaml (renamed from llvm/test/tools/yaml2obj/custom-fill.yaml)0
-rw-r--r--llvm/test/tools/yaml2obj/ELF/custom-null-section.yaml (renamed from llvm/test/tools/yaml2obj/elf-custom-null-section.yaml)0
-rw-r--r--llvm/test/tools/yaml2obj/ELF/duplicate-section-names.yaml (renamed from llvm/test/tools/yaml2obj/duplicate-section-names.test)2
-rw-r--r--llvm/test/tools/yaml2obj/ELF/duplicate-symbol-names.yaml (renamed from llvm/test/tools/yaml2obj/duplicate-symbol-names.test)0
-rw-r--r--llvm/test/tools/yaml2obj/ELF/dynamic-relocations.yaml (renamed from llvm/test/tools/yaml2obj/dynamic-relocations.yaml)0
-rw-r--r--llvm/test/tools/yaml2obj/ELF/dynamic-section-i386.yaml (renamed from llvm/test/tools/yaml2obj/dynamic-section-i386.test)0
-rw-r--r--llvm/test/tools/yaml2obj/ELF/dynamic-section-raw-content.yaml (renamed from llvm/test/tools/yaml2obj/dynamic-section-raw-content.yaml)4
-rw-r--r--llvm/test/tools/yaml2obj/ELF/dynamic-section.yaml (renamed from llvm/test/tools/yaml2obj/dynamic-section.yaml)3
-rw-r--r--llvm/test/tools/yaml2obj/ELF/dynamic-symbols.yaml (renamed from llvm/test/tools/yaml2obj/dynamic-symbols.yaml)4
-rw-r--r--llvm/test/tools/yaml2obj/ELF/dynsymtab-implicit-sections-size-content.yaml (renamed from llvm/test/tools/yaml2obj/dynsymtab-implicit-sections-size-content.yaml)0
-rw-r--r--llvm/test/tools/yaml2obj/ELF/dynsymtab-shlink.yaml (renamed from llvm/test/tools/yaml2obj/dynsymtab-shlink.yaml)0
-rw-r--r--llvm/test/tools/yaml2obj/ELF/emachine.yaml (renamed from llvm/test/tools/yaml2obj/elf-emachine.yaml)0
-rw-r--r--llvm/test/tools/yaml2obj/ELF/empty-symbols.yaml12
-rw-r--r--llvm/test/tools/yaml2obj/ELF/ent-size.yaml (renamed from llvm/test/tools/yaml2obj/elf-ent-size.yaml)0
-rw-r--r--llvm/test/tools/yaml2obj/ELF/explicit-dynsym-no-dynstr.yaml (renamed from llvm/test/tools/yaml2obj/explicit-dynsym-no-dynstr.yaml)0
-rw-r--r--llvm/test/tools/yaml2obj/ELF/gnu-hash-section.yaml (renamed from llvm/test/tools/yaml2obj/elf-gnu-hash-section.yaml)0
-rw-r--r--llvm/test/tools/yaml2obj/ELF/gnu-unique-symbols.yaml (renamed from llvm/test/tools/yaml2obj/elf-gnu-unique-symbols.yaml)0
-rw-r--r--llvm/test/tools/yaml2obj/ELF/hash-section.yaml (renamed from llvm/test/tools/yaml2obj/elf-hash-section.yaml)0
-rw-r--r--llvm/test/tools/yaml2obj/ELF/header-elfdatanone.yaml (renamed from llvm/test/tools/yaml2obj/elf-header-elfdatanone.yaml)0
-rw-r--r--llvm/test/tools/yaml2obj/ELF/header-sh-fields.yaml (renamed from llvm/test/tools/yaml2obj/elf-header-sh-fields.yaml)0
-rw-r--r--llvm/test/tools/yaml2obj/ELF/implicit-sections-addr.yaml (renamed from llvm/test/tools/yaml2obj/implicit-sections-addr.yaml)0
-rw-r--r--llvm/test/tools/yaml2obj/ELF/implicit-sections-info.yaml (renamed from llvm/test/tools/yaml2obj/implicit-sections-info.yaml)0
-rw-r--r--llvm/test/tools/yaml2obj/ELF/implicit-sections-types.yaml (renamed from llvm/test/tools/yaml2obj/implicit-sections-types.test)0
-rw-r--r--llvm/test/tools/yaml2obj/ELF/implicit-sections.yaml (renamed from llvm/test/tools/yaml2obj/implicit-sections.test)0
-rw-r--r--llvm/test/tools/yaml2obj/ELF/invalid-docnum.yaml (renamed from llvm/test/tools/yaml2obj/invalid-docnum.test)0
-rw-r--r--llvm/test/tools/yaml2obj/ELF/linker-options.yaml (renamed from llvm/test/tools/yaml2obj/linker-options.yaml)2
-rw-r--r--llvm/test/tools/yaml2obj/ELF/llvm-addrsig-section.yaml (renamed from llvm/test/tools/yaml2obj/elf-llvm-addrsig-section.yaml)0
-rw-r--r--llvm/test/tools/yaml2obj/ELF/local-symbols.yaml (renamed from llvm/test/tools/yaml2obj/local-symbols.yaml)6
-rw-r--r--llvm/test/tools/yaml2obj/ELF/no-phdrs.yaml (renamed from llvm/test/tools/yaml2obj/elf-no-phdrs.yaml)0
-rw-r--r--llvm/test/tools/yaml2obj/ELF/override-shname.yaml (renamed from llvm/test/tools/yaml2obj/elf-override-shname.yaml)0
-rw-r--r--llvm/test/tools/yaml2obj/ELF/override-shoffset.yaml (renamed from llvm/test/tools/yaml2obj/elf-override-shoffset.yaml)0
-rw-r--r--llvm/test/tools/yaml2obj/ELF/override-shsize.yaml (renamed from llvm/test/tools/yaml2obj/elf-override-shsize.yaml)2
-rw-r--r--llvm/test/tools/yaml2obj/ELF/program-header-align.yaml (renamed from llvm/test/tools/yaml2obj/program-header-align.yaml)0
-rw-r--r--llvm/test/tools/yaml2obj/ELF/program-header-nobits.yaml (renamed from llvm/test/tools/yaml2obj/program-header-nobits.yaml)0
-rw-r--r--llvm/test/tools/yaml2obj/ELF/program-header-size-offset.yaml (renamed from llvm/test/tools/yaml2obj/program-header-size-offset.yaml)4
-rw-r--r--llvm/test/tools/yaml2obj/ELF/program-header.yaml (renamed from llvm/test/tools/yaml2obj/program-header.yaml)0
-rw-r--r--llvm/test/tools/yaml2obj/ELF/reloc-sec-info.yaml (renamed from llvm/test/tools/yaml2obj/reloc-sec-info.yaml)0
-rw-r--r--llvm/test/tools/yaml2obj/ELF/relocation-explicit-symbol-index.yaml (renamed from llvm/test/tools/yaml2obj/relocation-explicit-symbol-index.yaml)9
-rw-r--r--llvm/test/tools/yaml2obj/ELF/relocation-implicit-symbol-index.yaml (renamed from llvm/test/tools/yaml2obj/invalid-symboless-relocation.yaml)22
-rw-r--r--llvm/test/tools/yaml2obj/ELF/relocation-missing-symbol.yaml (renamed from llvm/test/tools/yaml2obj/relocation-missing-symbol.yaml)0
-rw-r--r--llvm/test/tools/yaml2obj/ELF/relocation-unsupported-machine.yaml (renamed from llvm/test/tools/yaml2obj/relocation-unsupported-machine.yaml)0
-rw-r--r--llvm/test/tools/yaml2obj/ELF/section-link.yaml (renamed from llvm/test/tools/yaml2obj/section-link.yaml)0
-rw-r--r--llvm/test/tools/yaml2obj/ELF/section-ordering.yaml (renamed from llvm/test/tools/yaml2obj/section-ordering.yaml)3
-rw-r--r--llvm/test/tools/yaml2obj/ELF/section-size-content.yaml (renamed from llvm/test/tools/yaml2obj/section-size-content.yaml)0
-rw-r--r--llvm/test/tools/yaml2obj/ELF/section-type.yaml (renamed from llvm/test/tools/yaml2obj/section-type.yaml)0
-rw-r--r--llvm/test/tools/yaml2obj/ELF/section-unnamed.yaml (renamed from llvm/test/tools/yaml2obj/unnamed-section.yaml)3
-rw-r--r--llvm/test/tools/yaml2obj/ELF/sh-addralign.yaml (renamed from llvm/test/tools/yaml2obj/elf-sh-addralign.yaml)2
-rw-r--r--llvm/test/tools/yaml2obj/ELF/sht-symtab-shndx.yaml (renamed from llvm/test/tools/yaml2obj/elf-sht-symtab-shndx.yaml)2
-rw-r--r--llvm/test/tools/yaml2obj/ELF/stack-sizes.yaml (renamed from llvm/test/tools/yaml2obj/elf-stack-sizes.yaml)0
-rw-r--r--llvm/test/tools/yaml2obj/ELF/strtab-implicit-sections-flags.yaml (renamed from llvm/test/tools/yaml2obj/strtab-implicit-sections-flags.yaml)0
-rw-r--r--llvm/test/tools/yaml2obj/ELF/strtab-implicit-sections-size-content.yaml (renamed from llvm/test/tools/yaml2obj/strtab-implicit-sections-size-content.yaml)0
-rw-r--r--llvm/test/tools/yaml2obj/ELF/symbol-binding.yaml (renamed from llvm/test/tools/yaml2obj/elf-symbol-binding.yaml)0
-rw-r--r--llvm/test/tools/yaml2obj/ELF/symbol-index-invalid.yaml (renamed from llvm/test/tools/yaml2obj/symbol-index-invalid.yaml)3
-rw-r--r--llvm/test/tools/yaml2obj/ELF/symbol-index.yaml (renamed from llvm/test/tools/yaml2obj/symbol-index.yaml)6
-rw-r--r--llvm/test/tools/yaml2obj/ELF/symbol-name.yaml (renamed from llvm/test/tools/yaml2obj/symbol-name.yaml)0
-rw-r--r--llvm/test/tools/yaml2obj/ELF/symbol-stother.yaml (renamed from llvm/test/tools/yaml2obj/elf-symbol-stother.yaml)0
-rw-r--r--llvm/test/tools/yaml2obj/ELF/symbol-type.yaml (renamed from llvm/test/tools/yaml2obj/symbol-type.yaml)4
-rw-r--r--llvm/test/tools/yaml2obj/ELF/symbol-visibility.yaml (renamed from llvm/test/tools/yaml2obj/elf-symbol-visibility.yaml)0
-rw-r--r--llvm/test/tools/yaml2obj/ELF/symbols-binding-order.yaml (renamed from llvm/test/tools/yaml2obj/elf-symbols-binding-order.yaml)0
-rw-r--r--llvm/test/tools/yaml2obj/ELF/symtab-implicit-sections-flags.yaml (renamed from llvm/test/tools/yaml2obj/symtab-implicit-sections-flags.yaml)0
-rw-r--r--llvm/test/tools/yaml2obj/ELF/symtab-implicit-sections-size-content.yaml (renamed from llvm/test/tools/yaml2obj/symtab-implicit-sections-size-content.yaml)0
-rw-r--r--llvm/test/tools/yaml2obj/ELF/symtab-shinfo.yaml (renamed from llvm/test/tools/yaml2obj/elf-symtab-shinfo.yaml)2
-rw-r--r--llvm/test/tools/yaml2obj/ELF/symtab-shlink.yaml (renamed from llvm/test/tools/yaml2obj/symtab-shlink.yaml)0
-rw-r--r--llvm/test/tools/yaml2obj/ELF/symtab-shtype.yaml (renamed from llvm/test/tools/yaml2obj/elf-symtab-shtype.yaml)0
-rw-r--r--llvm/test/tools/yaml2obj/ELF/verdef-section.yaml (renamed from llvm/test/tools/yaml2obj/verdef-section.yaml)4
-rw-r--r--llvm/test/tools/yaml2obj/ELF/verneed-section.yaml (renamed from llvm/test/tools/yaml2obj/verneed-section.yaml)4
-rw-r--r--llvm/test/tools/yaml2obj/ELF/versym-section.yaml (renamed from llvm/test/tools/yaml2obj/versym-section.yaml)2
-rw-r--r--llvm/test/tools/yaml2obj/Minidump/exception-missing-parameter.yaml (renamed from llvm/test/tools/yaml2obj/minidump-exception-missing-parameter.yaml)0
-rw-r--r--llvm/test/tools/yaml2obj/Minidump/raw-stream-small-size.yaml (renamed from llvm/test/tools/yaml2obj/minidump-raw-stream-small-size.yaml)0
-rw-r--r--llvm/test/tools/yaml2obj/Minidump/systeminfo-other-long.yaml (renamed from llvm/test/tools/yaml2obj/minidump-systeminfo-other-long.yaml)0
-rw-r--r--llvm/test/tools/yaml2obj/Minidump/systeminfo-other-not-hex.yaml (renamed from llvm/test/tools/yaml2obj/minidump-systeminfo-other-not-hex.yaml)0
-rw-r--r--llvm/test/tools/yaml2obj/Minidump/systeminfo-other-short.yaml (renamed from llvm/test/tools/yaml2obj/minidump-systeminfo-other-short.yaml)0
-rw-r--r--llvm/test/tools/yaml2obj/Minidump/systeminfo-x86-long.yaml (renamed from llvm/test/tools/yaml2obj/minidump-systeminfo-x86-long.yaml)0
-rw-r--r--llvm/test/tools/yaml2obj/Minidump/systeminfo-x86-short.yaml (renamed from llvm/test/tools/yaml2obj/minidump-systeminfo-x86-short.yaml)0
-rw-r--r--llvm/test/tools/yaml2obj/empty-symbols.yaml10
-rw-r--r--llvm/test/tools/yaml2obj/invalid-output-file.yaml (renamed from llvm/test/tools/yaml2obj/invalid_output_file.test)2
-rw-r--r--llvm/test/tools/yaml2obj/multi-doc.yaml (renamed from llvm/test/tools/yaml2obj/multi-doc.test)0
-rw-r--r--llvm/test/tools/yaml2obj/symboless-relocation.yaml20
86 files changed, 93 insertions, 102 deletions
diff --git a/llvm/test/tools/yaml2obj/coff-arm64.yaml b/llvm/test/tools/yaml2obj/COFF/basic-arm64.yaml
index 5bb9939f1fc..c6889777fd4 100644
--- a/llvm/test/tools/yaml2obj/coff-arm64.yaml
+++ b/llvm/test/tools/yaml2obj/COFF/basic-arm64.yaml
@@ -9,7 +9,7 @@
# ROUNDTRIP: VirtualAddress: 12288
--- !COFF
-OptionalHeader:
+OptionalHeader:
AddressOfEntryPoint: 4096
ImageBase: 1073741824
SectionAlignment: 4096
@@ -26,55 +26,55 @@ OptionalHeader:
SizeOfStackCommit: 4096
SizeOfHeapReserve: 1048576
SizeOfHeapCommit: 4096
- ExportTable:
+ ExportTable:
RelativeVirtualAddress: 0
Size: 0
- ImportTable:
+ ImportTable:
RelativeVirtualAddress: 0
Size: 0
- ResourceTable:
+ ResourceTable:
RelativeVirtualAddress: 0
Size: 0
- ExceptionTable:
+ ExceptionTable:
RelativeVirtualAddress: 12288
Size: 8
- CertificateTable:
+ CertificateTable:
RelativeVirtualAddress: 0
Size: 0
- BaseRelocationTable:
+ BaseRelocationTable:
RelativeVirtualAddress: 0
Size: 0
- Debug:
+ Debug:
RelativeVirtualAddress: 0
Size: 0
- Architecture:
+ Architecture:
RelativeVirtualAddress: 0
Size: 0
- GlobalPtr:
+ GlobalPtr:
RelativeVirtualAddress: 0
Size: 0
- TlsTable:
+ TlsTable:
RelativeVirtualAddress: 0
Size: 0
- LoadConfigTable:
+ LoadConfigTable:
RelativeVirtualAddress: 0
Size: 0
- BoundImport:
+ BoundImport:
RelativeVirtualAddress: 0
Size: 0
- IAT:
+ IAT:
RelativeVirtualAddress: 0
Size: 0
- DelayImportDescriptor:
+ DelayImportDescriptor:
RelativeVirtualAddress: 0
Size: 0
- ClrRuntimeHeader:
+ ClrRuntimeHeader:
RelativeVirtualAddress: 0
Size: 0
-header:
+header:
Machine: IMAGE_FILE_MACHINE_ARM64
Characteristics: [ IMAGE_FILE_EXECUTABLE_IMAGE, IMAGE_FILE_LARGE_ADDRESS_AWARE ]
-sections:
+sections:
- Name: .text
Characteristics: [ IMAGE_SCN_CNT_CODE, IMAGE_SCN_MEM_EXECUTE, IMAGE_SCN_MEM_READ ]
VirtualAddress: 4096
diff --git a/llvm/test/tools/yaml2obj/coff-invalid-alignment.test b/llvm/test/tools/yaml2obj/COFF/invalid-alignment.yaml
index 3a3d8a84ad1..213d5adf1d9 100644
--- a/llvm/test/tools/yaml2obj/coff-invalid-alignment.test
+++ b/llvm/test/tools/yaml2obj/COFF/invalid-alignment.yaml
@@ -11,4 +11,4 @@ sections:
Characteristics: []
SectionData: 00
Alignment: 16384
-symbols:
+symbols: []
diff --git a/llvm/test/tools/yaml2obj/coff-symbol-index.yaml b/llvm/test/tools/yaml2obj/COFF/symbol-index.yaml
index 7973b2558c5..39d41f36500 100644
--- a/llvm/test/tools/yaml2obj/coff-symbol-index.yaml
+++ b/llvm/test/tools/yaml2obj/COFF/symbol-index.yaml
@@ -10,11 +10,11 @@
# RELOCS-NEXT: }
# RELOCS-NEXT: ]
-# Check that we usually output relocations with SymbolName.
-# For relocations with a non-unique symbol name, output
-# SymbolTableIndex instead.
+## Check that we usually output relocations with SymbolName.
+## For relocations with a non-unique symbol name, output
+## SymbolTableIndex instead.
-# YAML: Relocations:
+# YAML: Relocations:
# YAML-NEXT: - VirtualAddress: 3
# YAML-NEXT: SymbolTableIndex: 0
# YAML-NEXT: Type: IMAGE_REL_AMD64_REL32
@@ -26,15 +26,15 @@
# YAML-NEXT: Type: IMAGE_REL_AMD64_REL32
--- !COFF
-header:
+header:
Machine: IMAGE_FILE_MACHINE_AMD64
Characteristics: [ ]
-sections:
+sections:
- Name: .text
Characteristics: [ ]
Alignment: 4
SectionData: 488B0500000000488B0500000000488B0500000000
- Relocations:
+ Relocations:
- VirtualAddress: 3
SymbolTableIndex: 0
Type: IMAGE_REL_AMD64_REL32
@@ -52,7 +52,7 @@ sections:
Characteristics: [ ]
Alignment: 1
SectionData: '01'
-symbols:
+symbols:
- Name: .rdata
Value: 0
SectionNumber: 2
diff --git a/llvm/test/tools/yaml2obj/elf-abiversion.yaml b/llvm/test/tools/yaml2obj/ELF/abiversion.yaml
index 0aab621d257..b7ffcd379d5 100644
--- a/llvm/test/tools/yaml2obj/elf-abiversion.yaml
+++ b/llvm/test/tools/yaml2obj/ELF/abiversion.yaml
@@ -1,9 +1,9 @@
+## Check we are able to parse/emit the ABI version with yaml2obj/obj2yaml.
+
# RUN: yaml2obj %s -o %t
# RUN: llvm-readobj --file-headers %t | FileCheck %s --check-prefix=FROMYAML
# RUN: obj2yaml %t | FileCheck %s --check-prefix=TOYAML
-## Check we are able to parse/emit the ABI version with yaml2obj/obj2yaml.
-
# FROMYAML: ABIVersion: 5
# TOYAML: ABIVersion: 0x05
diff --git a/llvm/test/tools/yaml2obj/elf-class-endianness.test b/llvm/test/tools/yaml2obj/ELF/class-endianness.yaml
index f18ffc4c994..f18ffc4c994 100644
--- a/llvm/test/tools/yaml2obj/elf-class-endianness.test
+++ b/llvm/test/tools/yaml2obj/ELF/class-endianness.yaml
diff --git a/llvm/test/tools/yaml2obj/elf-comdat-broken-info.yaml b/llvm/test/tools/yaml2obj/ELF/comdat-broken-info.yaml
index d79b250ccc9..d79b250ccc9 100644
--- a/llvm/test/tools/yaml2obj/elf-comdat-broken-info.yaml
+++ b/llvm/test/tools/yaml2obj/ELF/comdat-broken-info.yaml
diff --git a/llvm/test/tools/yaml2obj/elf-comdat-broken-members.yaml b/llvm/test/tools/yaml2obj/ELF/comdat-broken-members.yaml
index 9ebcf02c929..9ebcf02c929 100644
--- a/llvm/test/tools/yaml2obj/elf-comdat-broken-members.yaml
+++ b/llvm/test/tools/yaml2obj/ELF/comdat-broken-members.yaml
diff --git a/llvm/test/tools/yaml2obj/elf-comdat-broken.yaml b/llvm/test/tools/yaml2obj/ELF/comdat-broken.yaml
index 88ed3c315c5..88ed3c315c5 100644
--- a/llvm/test/tools/yaml2obj/elf-comdat-broken.yaml
+++ b/llvm/test/tools/yaml2obj/ELF/comdat-broken.yaml
diff --git a/llvm/test/tools/yaml2obj/custom-fill.yaml b/llvm/test/tools/yaml2obj/ELF/custom-fill.yaml
index 8dfc2fdae3c..8dfc2fdae3c 100644
--- a/llvm/test/tools/yaml2obj/custom-fill.yaml
+++ b/llvm/test/tools/yaml2obj/ELF/custom-fill.yaml
diff --git a/llvm/test/tools/yaml2obj/elf-custom-null-section.yaml b/llvm/test/tools/yaml2obj/ELF/custom-null-section.yaml
index e8cbb4edb63..e8cbb4edb63 100644
--- a/llvm/test/tools/yaml2obj/elf-custom-null-section.yaml
+++ b/llvm/test/tools/yaml2obj/ELF/custom-null-section.yaml
diff --git a/llvm/test/tools/yaml2obj/duplicate-section-names.test b/llvm/test/tools/yaml2obj/ELF/duplicate-section-names.yaml
index 8b21511a281..e681ff1d1a4 100644
--- a/llvm/test/tools/yaml2obj/duplicate-section-names.test
+++ b/llvm/test/tools/yaml2obj/ELF/duplicate-section-names.yaml
@@ -159,7 +159,7 @@ Sections:
- Name: '.group [1]'
Type: SHT_GROUP
Info: 'foo [1]'
- Members:
+ Members:
- SectionOrType: GRP_COMDAT
- SectionOrType: '.text.foo [1]'
- Name: '.text.foo [1]'
diff --git a/llvm/test/tools/yaml2obj/duplicate-symbol-names.test b/llvm/test/tools/yaml2obj/ELF/duplicate-symbol-names.yaml
index 0e50042a6c3..0e50042a6c3 100644
--- a/llvm/test/tools/yaml2obj/duplicate-symbol-names.test
+++ b/llvm/test/tools/yaml2obj/ELF/duplicate-symbol-names.yaml
diff --git a/llvm/test/tools/yaml2obj/dynamic-relocations.yaml b/llvm/test/tools/yaml2obj/ELF/dynamic-relocations.yaml
index 2e2d3801f63..2e2d3801f63 100644
--- a/llvm/test/tools/yaml2obj/dynamic-relocations.yaml
+++ b/llvm/test/tools/yaml2obj/ELF/dynamic-relocations.yaml
diff --git a/llvm/test/tools/yaml2obj/dynamic-section-i386.test b/llvm/test/tools/yaml2obj/ELF/dynamic-section-i386.yaml
index 89f7de6fd76..89f7de6fd76 100644
--- a/llvm/test/tools/yaml2obj/dynamic-section-i386.test
+++ b/llvm/test/tools/yaml2obj/ELF/dynamic-section-i386.yaml
diff --git a/llvm/test/tools/yaml2obj/dynamic-section-raw-content.yaml b/llvm/test/tools/yaml2obj/ELF/dynamic-section-raw-content.yaml
index b7f9b777484..feb979df949 100644
--- a/llvm/test/tools/yaml2obj/dynamic-section-raw-content.yaml
+++ b/llvm/test/tools/yaml2obj/ELF/dynamic-section-raw-content.yaml
@@ -1,5 +1,5 @@
-# Show that yaml2obj can handle a dynamic section with raw content instead of
-# entries. Also show that it rejects raw content when entries are also provided.
+## Show that yaml2obj can handle a dynamic section with raw content instead of
+## entries. Also show that it rejects raw content when entries are also provided.
# RUN: yaml2obj --docnum=1 %s -o %t1
# RUN: llvm-readobj -x .dynamic --sections %t1 | FileCheck %s --check-prefix=RAW
diff --git a/llvm/test/tools/yaml2obj/dynamic-section.yaml b/llvm/test/tools/yaml2obj/ELF/dynamic-section.yaml
index 2480810d33b..035d97094df 100644
--- a/llvm/test/tools/yaml2obj/dynamic-section.yaml
+++ b/llvm/test/tools/yaml2obj/ELF/dynamic-section.yaml
@@ -1,4 +1,5 @@
-# Ensures that dynamic section has sh_entsize correctly set
+## Ensures that dynamic section has sh_entsize correctly set.
+
# RUN: yaml2obj %s -o %t
# RUN: llvm-readobj --sections %t | FileCheck %s --check-prefix=SECTION
diff --git a/llvm/test/tools/yaml2obj/dynamic-symbols.yaml b/llvm/test/tools/yaml2obj/ELF/dynamic-symbols.yaml
index c088a1199be..e42ff1e66ee 100644
--- a/llvm/test/tools/yaml2obj/dynamic-symbols.yaml
+++ b/llvm/test/tools/yaml2obj/ELF/dynamic-symbols.yaml
@@ -51,12 +51,12 @@ DynamicSymbols:
# NUM-SAME: .data (0x1)
# NUM: Name: bar
-# NUM: Section:
+# NUM: Section:
# NUM-SAME: .strtab (0x2)
# NUM: Name: zed
# NUM: warning: '[[FILE]]': invalid section index: 255
-# NUM: Section:
+# NUM: Section:
# NUM-SAME: <?> (0xFF)
--- !ELF
diff --git a/llvm/test/tools/yaml2obj/dynsymtab-implicit-sections-size-content.yaml b/llvm/test/tools/yaml2obj/ELF/dynsymtab-implicit-sections-size-content.yaml
index bd3d1629534..bd3d1629534 100644
--- a/llvm/test/tools/yaml2obj/dynsymtab-implicit-sections-size-content.yaml
+++ b/llvm/test/tools/yaml2obj/ELF/dynsymtab-implicit-sections-size-content.yaml
diff --git a/llvm/test/tools/yaml2obj/dynsymtab-shlink.yaml b/llvm/test/tools/yaml2obj/ELF/dynsymtab-shlink.yaml
index 76c079f6d50..76c079f6d50 100644
--- a/llvm/test/tools/yaml2obj/dynsymtab-shlink.yaml
+++ b/llvm/test/tools/yaml2obj/ELF/dynsymtab-shlink.yaml
diff --git a/llvm/test/tools/yaml2obj/elf-emachine.yaml b/llvm/test/tools/yaml2obj/ELF/emachine.yaml
index 206be42c7dc..206be42c7dc 100644
--- a/llvm/test/tools/yaml2obj/elf-emachine.yaml
+++ b/llvm/test/tools/yaml2obj/ELF/emachine.yaml
diff --git a/llvm/test/tools/yaml2obj/ELF/empty-symbols.yaml b/llvm/test/tools/yaml2obj/ELF/empty-symbols.yaml
new file mode 100644
index 00000000000..00c16f62c6c
--- /dev/null
+++ b/llvm/test/tools/yaml2obj/ELF/empty-symbols.yaml
@@ -0,0 +1,12 @@
+## Ensure yaml2obj doesn't error on empty optional mappings, such as Symbols
+# RUN: yaml2obj %s -o /dev/null
+
+!ELF
+FileHeader:
+ Class: ELFCLASS64
+ Data: ELFDATA2LSB
+ Type: ET_DYN
+ Machine: EM_X86_64
+## We usually express this as `Symbols: []`, but here we show that the value
+## can be omitted.
+Symbols:
diff --git a/llvm/test/tools/yaml2obj/elf-ent-size.yaml b/llvm/test/tools/yaml2obj/ELF/ent-size.yaml
index 06b989945db..06b989945db 100644
--- a/llvm/test/tools/yaml2obj/elf-ent-size.yaml
+++ b/llvm/test/tools/yaml2obj/ELF/ent-size.yaml
diff --git a/llvm/test/tools/yaml2obj/explicit-dynsym-no-dynstr.yaml b/llvm/test/tools/yaml2obj/ELF/explicit-dynsym-no-dynstr.yaml
index 9624dd7ff5b..9624dd7ff5b 100644
--- a/llvm/test/tools/yaml2obj/explicit-dynsym-no-dynstr.yaml
+++ b/llvm/test/tools/yaml2obj/ELF/explicit-dynsym-no-dynstr.yaml
diff --git a/llvm/test/tools/yaml2obj/elf-gnu-hash-section.yaml b/llvm/test/tools/yaml2obj/ELF/gnu-hash-section.yaml
index fff9a341910..fff9a341910 100644
--- a/llvm/test/tools/yaml2obj/elf-gnu-hash-section.yaml
+++ b/llvm/test/tools/yaml2obj/ELF/gnu-hash-section.yaml
diff --git a/llvm/test/tools/yaml2obj/elf-gnu-unique-symbols.yaml b/llvm/test/tools/yaml2obj/ELF/gnu-unique-symbols.yaml
index e045b52c202..e045b52c202 100644
--- a/llvm/test/tools/yaml2obj/elf-gnu-unique-symbols.yaml
+++ b/llvm/test/tools/yaml2obj/ELF/gnu-unique-symbols.yaml
diff --git a/llvm/test/tools/yaml2obj/elf-hash-section.yaml b/llvm/test/tools/yaml2obj/ELF/hash-section.yaml
index 4aad9c11fd5..4aad9c11fd5 100644
--- a/llvm/test/tools/yaml2obj/elf-hash-section.yaml
+++ b/llvm/test/tools/yaml2obj/ELF/hash-section.yaml
diff --git a/llvm/test/tools/yaml2obj/elf-header-elfdatanone.yaml b/llvm/test/tools/yaml2obj/ELF/header-elfdatanone.yaml
index 0e1d065ddcf..0e1d065ddcf 100644
--- a/llvm/test/tools/yaml2obj/elf-header-elfdatanone.yaml
+++ b/llvm/test/tools/yaml2obj/ELF/header-elfdatanone.yaml
diff --git a/llvm/test/tools/yaml2obj/elf-header-sh-fields.yaml b/llvm/test/tools/yaml2obj/ELF/header-sh-fields.yaml
index 821b7741885..821b7741885 100644
--- a/llvm/test/tools/yaml2obj/elf-header-sh-fields.yaml
+++ b/llvm/test/tools/yaml2obj/ELF/header-sh-fields.yaml
diff --git a/llvm/test/tools/yaml2obj/implicit-sections-addr.yaml b/llvm/test/tools/yaml2obj/ELF/implicit-sections-addr.yaml
index 8151daed1d6..8151daed1d6 100644
--- a/llvm/test/tools/yaml2obj/implicit-sections-addr.yaml
+++ b/llvm/test/tools/yaml2obj/ELF/implicit-sections-addr.yaml
diff --git a/llvm/test/tools/yaml2obj/implicit-sections-info.yaml b/llvm/test/tools/yaml2obj/ELF/implicit-sections-info.yaml
index d7d530d3960..d7d530d3960 100644
--- a/llvm/test/tools/yaml2obj/implicit-sections-info.yaml
+++ b/llvm/test/tools/yaml2obj/ELF/implicit-sections-info.yaml
diff --git a/llvm/test/tools/yaml2obj/implicit-sections-types.test b/llvm/test/tools/yaml2obj/ELF/implicit-sections-types.yaml
index 4d22dea62cc..4d22dea62cc 100644
--- a/llvm/test/tools/yaml2obj/implicit-sections-types.test
+++ b/llvm/test/tools/yaml2obj/ELF/implicit-sections-types.yaml
diff --git a/llvm/test/tools/yaml2obj/implicit-sections.test b/llvm/test/tools/yaml2obj/ELF/implicit-sections.yaml
index cde17c23287..cde17c23287 100644
--- a/llvm/test/tools/yaml2obj/implicit-sections.test
+++ b/llvm/test/tools/yaml2obj/ELF/implicit-sections.yaml
diff --git a/llvm/test/tools/yaml2obj/invalid-docnum.test b/llvm/test/tools/yaml2obj/ELF/invalid-docnum.yaml
index e25a033b638..e25a033b638 100644
--- a/llvm/test/tools/yaml2obj/invalid-docnum.test
+++ b/llvm/test/tools/yaml2obj/ELF/invalid-docnum.yaml
diff --git a/llvm/test/tools/yaml2obj/linker-options.yaml b/llvm/test/tools/yaml2obj/ELF/linker-options.yaml
index 2082e494534..79a645c2aaa 100644
--- a/llvm/test/tools/yaml2obj/linker-options.yaml
+++ b/llvm/test/tools/yaml2obj/ELF/linker-options.yaml
@@ -86,7 +86,7 @@ Sections:
# RUN: not yaml2obj %s --docnum=4 2>&1 | FileCheck %s --check-prefix=BOTH
# BOTH: error: "Options" and "Content" can't be used together
-
+
--- !ELF
FileHeader:
Class: ELFCLASS64
diff --git a/llvm/test/tools/yaml2obj/elf-llvm-addrsig-section.yaml b/llvm/test/tools/yaml2obj/ELF/llvm-addrsig-section.yaml
index 1433d6dbc13..1433d6dbc13 100644
--- a/llvm/test/tools/yaml2obj/elf-llvm-addrsig-section.yaml
+++ b/llvm/test/tools/yaml2obj/ELF/llvm-addrsig-section.yaml
diff --git a/llvm/test/tools/yaml2obj/local-symbols.yaml b/llvm/test/tools/yaml2obj/ELF/local-symbols.yaml
index fa82a90923d..4c1800ea4c1 100644
--- a/llvm/test/tools/yaml2obj/local-symbols.yaml
+++ b/llvm/test/tools/yaml2obj/ELF/local-symbols.yaml
@@ -1,6 +1,6 @@
-# Check we correctly set the sh_info field of .symtab section.
-# A symbol table section's sh_info section header member holds
-# the symbol table index for the first non-local symbol.
+## Check we correctly set the sh_info field of .symtab section.
+## A symbol table section's sh_info section header member holds
+## the symbol table index for the first non-local symbol.
# RUN: yaml2obj -docnum=1 %s -o %t
# RUN: llvm-readobj --sections %t | FileCheck %s --check-prefix=ONE
diff --git a/llvm/test/tools/yaml2obj/elf-no-phdrs.yaml b/llvm/test/tools/yaml2obj/ELF/no-phdrs.yaml
index e056b808e2f..e056b808e2f 100644
--- a/llvm/test/tools/yaml2obj/elf-no-phdrs.yaml
+++ b/llvm/test/tools/yaml2obj/ELF/no-phdrs.yaml
diff --git a/llvm/test/tools/yaml2obj/elf-override-shname.yaml b/llvm/test/tools/yaml2obj/ELF/override-shname.yaml
index 4698bc0eb49..4698bc0eb49 100644
--- a/llvm/test/tools/yaml2obj/elf-override-shname.yaml
+++ b/llvm/test/tools/yaml2obj/ELF/override-shname.yaml
diff --git a/llvm/test/tools/yaml2obj/elf-override-shoffset.yaml b/llvm/test/tools/yaml2obj/ELF/override-shoffset.yaml
index 9fe5ef01fa1..9fe5ef01fa1 100644
--- a/llvm/test/tools/yaml2obj/elf-override-shoffset.yaml
+++ b/llvm/test/tools/yaml2obj/ELF/override-shoffset.yaml
diff --git a/llvm/test/tools/yaml2obj/elf-override-shsize.yaml b/llvm/test/tools/yaml2obj/ELF/override-shsize.yaml
index 4470ae22002..ebbb3c3d24e 100644
--- a/llvm/test/tools/yaml2obj/elf-override-shsize.yaml
+++ b/llvm/test/tools/yaml2obj/ELF/override-shsize.yaml
@@ -5,7 +5,7 @@
# RUN: llvm-readelf --sections %t1 | FileCheck %s --check-prefix=CASE1
# CASE1: Section Headers:
-# CASE1-NEXT: [Nr] Name Type Address Off Size
+# CASE1-NEXT: [Nr] Name Type Address Off Size
# CASE1-NEXT: [ 0] NULL 0000000000000000 000000 000000
# CASE1-NEXT: [ 1] .dynsym DYNSYM 0000000000000000 000040 000001
# CASE1-NEXT: [ 2] .symtab SYMTAB 0000000000000000 000058 000002
diff --git a/llvm/test/tools/yaml2obj/program-header-align.yaml b/llvm/test/tools/yaml2obj/ELF/program-header-align.yaml
index 98e81a43cae..98e81a43cae 100644
--- a/llvm/test/tools/yaml2obj/program-header-align.yaml
+++ b/llvm/test/tools/yaml2obj/ELF/program-header-align.yaml
diff --git a/llvm/test/tools/yaml2obj/program-header-nobits.yaml b/llvm/test/tools/yaml2obj/ELF/program-header-nobits.yaml
index 81fdb937228..81fdb937228 100644
--- a/llvm/test/tools/yaml2obj/program-header-nobits.yaml
+++ b/llvm/test/tools/yaml2obj/ELF/program-header-nobits.yaml
diff --git a/llvm/test/tools/yaml2obj/program-header-size-offset.yaml b/llvm/test/tools/yaml2obj/ELF/program-header-size-offset.yaml
index 2cfddd2daa6..a2f727dab5f 100644
--- a/llvm/test/tools/yaml2obj/program-header-size-offset.yaml
+++ b/llvm/test/tools/yaml2obj/ELF/program-header-size-offset.yaml
@@ -1,5 +1,5 @@
-# Show that yaml2obj properly emits program headers with explicit file size,
-# memory size and offset parameters.
+## Show that yaml2obj properly emits program headers with explicit file size,
+## memory size and offset parameters.
# RUN: yaml2obj %s -o %t
# RUN: llvm-readobj %t --program-headers | FileCheck %s
diff --git a/llvm/test/tools/yaml2obj/program-header.yaml b/llvm/test/tools/yaml2obj/ELF/program-header.yaml
index dbffafc465f..dbffafc465f 100644
--- a/llvm/test/tools/yaml2obj/program-header.yaml
+++ b/llvm/test/tools/yaml2obj/ELF/program-header.yaml
diff --git a/llvm/test/tools/yaml2obj/reloc-sec-info.yaml b/llvm/test/tools/yaml2obj/ELF/reloc-sec-info.yaml
index bbbdc859d54..bbbdc859d54 100644
--- a/llvm/test/tools/yaml2obj/reloc-sec-info.yaml
+++ b/llvm/test/tools/yaml2obj/ELF/reloc-sec-info.yaml
diff --git a/llvm/test/tools/yaml2obj/relocation-explicit-symbol-index.yaml b/llvm/test/tools/yaml2obj/ELF/relocation-explicit-symbol-index.yaml
index 1a3470fe098..f4078dfc0ad 100644
--- a/llvm/test/tools/yaml2obj/relocation-explicit-symbol-index.yaml
+++ b/llvm/test/tools/yaml2obj/ELF/relocation-explicit-symbol-index.yaml
@@ -1,7 +1,8 @@
-# Test that a relocation's symbol can be an integer.
-# RUN: yaml2obj %s > %t
-# LLVM tools (both llvm-readobj and llvm-objdump) reject relocations with
-# invalid symbol indexes, so inspect the hex contents instead.
+## Test that a relocation's symbol can be an integer (symbol index).
+
+# RUN: yaml2obj %s -o %t
+## LLVM tools (both llvm-readobj and llvm-objdump) reject relocations with
+## invalid symbol indexes, so inspect the hex contents instead.
# RUN: llvm-readobj -x .rela.text %t | FileCheck %s
# CHECK: Hex dump of section '.rela.text':
diff --git a/llvm/test/tools/yaml2obj/invalid-symboless-relocation.yaml b/llvm/test/tools/yaml2obj/ELF/relocation-implicit-symbol-index.yaml
index 9ec956fcf8c..b8e7c6d0c40 100644
--- a/llvm/test/tools/yaml2obj/invalid-symboless-relocation.yaml
+++ b/llvm/test/tools/yaml2obj/ELF/relocation-implicit-symbol-index.yaml
@@ -1,8 +1,15 @@
-# This test succeeds but produces an invalid relocation. This test
-# documents this behavoir.
-# RUN: yaml2obj %s > %t
+## If "Symbol" is not specified for a relocation, the symbol index is assumed to be 0.
+
+# RUN: yaml2obj %s -o %t
# RUN: llvm-readobj -r %t | FileCheck %s
+# CHECK: Relocations [
+# CHECK-NEXT: Section (2) .rel.text {
+# CHECK-NEXT: 0x1000 R_X86_64_RELATIVE - 0x0
+# CHECK-NEXT: 0x1001 R_X86_64_PC32 - 0x0
+# CHECK-NEXT: }
+# CHECK-NEXT:]
+
!ELF
FileHeader:
Class: ELFCLASS64
@@ -19,10 +26,7 @@ Sections:
Info: .text
Relocations:
- Offset: 0x1000
+ Type: R_X86_64_RELATIVE
+ ## R_X86_64_PC32 should have a non-zero symbol index but we don't error.
+ - Offset: 0x1001
Type: R_X86_64_PC32
-
-#CHECK: Relocations [
-#CHECK-NEXT: Section (2) .rel.text {
-#CHECK-NEXT: 0x1000 R_X86_64_PC32 - 0x0
-#CHECK-NEXT: }
-#CHECK-NEXT:]
diff --git a/llvm/test/tools/yaml2obj/relocation-missing-symbol.yaml b/llvm/test/tools/yaml2obj/ELF/relocation-missing-symbol.yaml
index 6a785983c8f..6a785983c8f 100644
--- a/llvm/test/tools/yaml2obj/relocation-missing-symbol.yaml
+++ b/llvm/test/tools/yaml2obj/ELF/relocation-missing-symbol.yaml
diff --git a/llvm/test/tools/yaml2obj/relocation-unsupported-machine.yaml b/llvm/test/tools/yaml2obj/ELF/relocation-unsupported-machine.yaml
index 3943e64d14e..3943e64d14e 100644
--- a/llvm/test/tools/yaml2obj/relocation-unsupported-machine.yaml
+++ b/llvm/test/tools/yaml2obj/ELF/relocation-unsupported-machine.yaml
diff --git a/llvm/test/tools/yaml2obj/section-link.yaml b/llvm/test/tools/yaml2obj/ELF/section-link.yaml
index efe4d3fea74..efe4d3fea74 100644
--- a/llvm/test/tools/yaml2obj/section-link.yaml
+++ b/llvm/test/tools/yaml2obj/ELF/section-link.yaml
diff --git a/llvm/test/tools/yaml2obj/section-ordering.yaml b/llvm/test/tools/yaml2obj/ELF/section-ordering.yaml
index 5595f9379e9..47d87af347c 100644
--- a/llvm/test/tools/yaml2obj/section-ordering.yaml
+++ b/llvm/test/tools/yaml2obj/ELF/section-ordering.yaml
@@ -1,4 +1,5 @@
-# Ensures that implicitly added sections can be ordered within Sections.
+## Ensures that implicitly added sections can be ordered within Sections.
+
# RUN: yaml2obj %s -o %t
# RUN: llvm-readobj --sections %t | FileCheck %s
diff --git a/llvm/test/tools/yaml2obj/section-size-content.yaml b/llvm/test/tools/yaml2obj/ELF/section-size-content.yaml
index 16b4b37dd42..16b4b37dd42 100644
--- a/llvm/test/tools/yaml2obj/section-size-content.yaml
+++ b/llvm/test/tools/yaml2obj/ELF/section-size-content.yaml
diff --git a/llvm/test/tools/yaml2obj/section-type.yaml b/llvm/test/tools/yaml2obj/ELF/section-type.yaml
index ad2edd942cc..ad2edd942cc 100644
--- a/llvm/test/tools/yaml2obj/section-type.yaml
+++ b/llvm/test/tools/yaml2obj/ELF/section-type.yaml
diff --git a/llvm/test/tools/yaml2obj/unnamed-section.yaml b/llvm/test/tools/yaml2obj/ELF/section-unnamed.yaml
index e0d664e06d4..ae5f2d29cf2 100644
--- a/llvm/test/tools/yaml2obj/unnamed-section.yaml
+++ b/llvm/test/tools/yaml2obj/ELF/section-unnamed.yaml
@@ -1,4 +1,5 @@
-# Ensure yaml2obj doesn't crash on unnamed sections
+## Check that "Name" defaults to an empty string.
+
# RUN: yaml2obj %s -o %t
# RUN: llvm-readobj --sections %t | FileCheck %s
diff --git a/llvm/test/tools/yaml2obj/elf-sh-addralign.yaml b/llvm/test/tools/yaml2obj/ELF/sh-addralign.yaml
index fa057ecf411..100155e3068 100644
--- a/llvm/test/tools/yaml2obj/elf-sh-addralign.yaml
+++ b/llvm/test/tools/yaml2obj/ELF/sh-addralign.yaml
@@ -1,6 +1,6 @@
## Check that yaml2obj takes in account section AddressAlign field.
-# RUN: yaml2obj %s > %t
+# RUN: yaml2obj %s -o %t
# RUN: llvm-readobj -S %t | FileCheck %s
# CHECK: Section {
diff --git a/llvm/test/tools/yaml2obj/elf-sht-symtab-shndx.yaml b/llvm/test/tools/yaml2obj/ELF/sht-symtab-shndx.yaml
index 7175f465a66..9e74a9b0cf5 100644
--- a/llvm/test/tools/yaml2obj/elf-sht-symtab-shndx.yaml
+++ b/llvm/test/tools/yaml2obj/ELF/sht-symtab-shndx.yaml
@@ -21,7 +21,7 @@ Symbols:
Index: SHN_XINDEX
## Check that yaml2obj keeps the SHT_SYMTAB_SHNDX section in the output
-## even when symbol's section index value is low enough to not require the extended symtab.
+## even when symbol's section index value is low enough to not require the extended symtab.
## Also, check that symbols in .symtab still have the SHN_XINDEX index.
# RUN: yaml2obj --docnum=2 %s -o %t2
diff --git a/llvm/test/tools/yaml2obj/elf-stack-sizes.yaml b/llvm/test/tools/yaml2obj/ELF/stack-sizes.yaml
index e05a3def6a4..e05a3def6a4 100644
--- a/llvm/test/tools/yaml2obj/elf-stack-sizes.yaml
+++ b/llvm/test/tools/yaml2obj/ELF/stack-sizes.yaml
diff --git a/llvm/test/tools/yaml2obj/strtab-implicit-sections-flags.yaml b/llvm/test/tools/yaml2obj/ELF/strtab-implicit-sections-flags.yaml
index 2697145d1d0..2697145d1d0 100644
--- a/llvm/test/tools/yaml2obj/strtab-implicit-sections-flags.yaml
+++ b/llvm/test/tools/yaml2obj/ELF/strtab-implicit-sections-flags.yaml
diff --git a/llvm/test/tools/yaml2obj/strtab-implicit-sections-size-content.yaml b/llvm/test/tools/yaml2obj/ELF/strtab-implicit-sections-size-content.yaml
index a2be271d728..a2be271d728 100644
--- a/llvm/test/tools/yaml2obj/strtab-implicit-sections-size-content.yaml
+++ b/llvm/test/tools/yaml2obj/ELF/strtab-implicit-sections-size-content.yaml
diff --git a/llvm/test/tools/yaml2obj/elf-symbol-binding.yaml b/llvm/test/tools/yaml2obj/ELF/symbol-binding.yaml
index 185f8155bca..185f8155bca 100644
--- a/llvm/test/tools/yaml2obj/elf-symbol-binding.yaml
+++ b/llvm/test/tools/yaml2obj/ELF/symbol-binding.yaml
diff --git a/llvm/test/tools/yaml2obj/symbol-index-invalid.yaml b/llvm/test/tools/yaml2obj/ELF/symbol-index-invalid.yaml
index 06ef1b51a26..5072623624e 100644
--- a/llvm/test/tools/yaml2obj/symbol-index-invalid.yaml
+++ b/llvm/test/tools/yaml2obj/ELF/symbol-index-invalid.yaml
@@ -1,4 +1,5 @@
-# This test insures that the user cannot have both an Index and a Section field.
+## Check that "Index" and "Section" cannot be used together in a symbol.
+
# RUN: not yaml2obj %s
!ELF
diff --git a/llvm/test/tools/yaml2obj/symbol-index.yaml b/llvm/test/tools/yaml2obj/ELF/symbol-index.yaml
index 0530fa43a39..a053c94dd24 100644
--- a/llvm/test/tools/yaml2obj/symbol-index.yaml
+++ b/llvm/test/tools/yaml2obj/ELF/symbol-index.yaml
@@ -1,4 +1,4 @@
-# RUN: yaml2obj %s > %t
+# RUN: yaml2obj %s -o %t
# RUN: llvm-readelf -s %t | FileCheck %s
!ELF
@@ -21,10 +21,10 @@ Symbols:
Binding: STB_GLOBAL
- Name: common1
Index: SHN_COMMON
- Binding: STB_GLOBAL
+ Binding: STB_GLOBAL
- Name: common2
Index: 0xfff2
- Binding: STB_GLOBAL
+ Binding: STB_GLOBAL
- Name: good
Index: 0x1
Binding: STB_GLOBAL
diff --git a/llvm/test/tools/yaml2obj/symbol-name.yaml b/llvm/test/tools/yaml2obj/ELF/symbol-name.yaml
index 06815b4634d..06815b4634d 100644
--- a/llvm/test/tools/yaml2obj/symbol-name.yaml
+++ b/llvm/test/tools/yaml2obj/ELF/symbol-name.yaml
diff --git a/llvm/test/tools/yaml2obj/elf-symbol-stother.yaml b/llvm/test/tools/yaml2obj/ELF/symbol-stother.yaml
index 997a4b0be55..997a4b0be55 100644
--- a/llvm/test/tools/yaml2obj/elf-symbol-stother.yaml
+++ b/llvm/test/tools/yaml2obj/ELF/symbol-stother.yaml
diff --git a/llvm/test/tools/yaml2obj/symbol-type.yaml b/llvm/test/tools/yaml2obj/ELF/symbol-type.yaml
index 2eec6a46fd8..d74b1cbf787 100644
--- a/llvm/test/tools/yaml2obj/symbol-type.yaml
+++ b/llvm/test/tools/yaml2obj/ELF/symbol-type.yaml
@@ -1,4 +1,4 @@
-# RUN: yaml2obj %s > %t
+# RUN: yaml2obj %s -o %t
# RUN: llvm-readobj --symbols %t | FileCheck %s
# CHECK: Name: notype
@@ -30,7 +30,7 @@ Sections:
Symbols:
- Name: notype
Type: STT_NOTYPE
- Binding: STB_GLOBAL
+ Binding: STB_GLOBAL
- Name: normal_type
Type: STT_OBJECT
Binding: STB_GLOBAL
diff --git a/llvm/test/tools/yaml2obj/elf-symbol-visibility.yaml b/llvm/test/tools/yaml2obj/ELF/symbol-visibility.yaml
index b4d258b2df1..b4d258b2df1 100644
--- a/llvm/test/tools/yaml2obj/elf-symbol-visibility.yaml
+++ b/llvm/test/tools/yaml2obj/ELF/symbol-visibility.yaml
diff --git a/llvm/test/tools/yaml2obj/elf-symbols-binding-order.yaml b/llvm/test/tools/yaml2obj/ELF/symbols-binding-order.yaml
index 0c79f0e716e..0c79f0e716e 100644
--- a/llvm/test/tools/yaml2obj/elf-symbols-binding-order.yaml
+++ b/llvm/test/tools/yaml2obj/ELF/symbols-binding-order.yaml
diff --git a/llvm/test/tools/yaml2obj/symtab-implicit-sections-flags.yaml b/llvm/test/tools/yaml2obj/ELF/symtab-implicit-sections-flags.yaml
index d56c0dafd15..d56c0dafd15 100644
--- a/llvm/test/tools/yaml2obj/symtab-implicit-sections-flags.yaml
+++ b/llvm/test/tools/yaml2obj/ELF/symtab-implicit-sections-flags.yaml
diff --git a/llvm/test/tools/yaml2obj/symtab-implicit-sections-size-content.yaml b/llvm/test/tools/yaml2obj/ELF/symtab-implicit-sections-size-content.yaml
index 81758bd88e2..81758bd88e2 100644
--- a/llvm/test/tools/yaml2obj/symtab-implicit-sections-size-content.yaml
+++ b/llvm/test/tools/yaml2obj/ELF/symtab-implicit-sections-size-content.yaml
diff --git a/llvm/test/tools/yaml2obj/elf-symtab-shinfo.yaml b/llvm/test/tools/yaml2obj/ELF/symtab-shinfo.yaml
index 98ab4ac30db..fadc19686bb 100644
--- a/llvm/test/tools/yaml2obj/elf-symtab-shinfo.yaml
+++ b/llvm/test/tools/yaml2obj/ELF/symtab-shinfo.yaml
@@ -21,7 +21,7 @@
# CHECK-NEXT: Size:
# CHECK-NEXT: Link:
# CHECK-NEXT: Info: 26
-
+
--- !ELF
FileHeader:
Class: ELFCLASS64
diff --git a/llvm/test/tools/yaml2obj/symtab-shlink.yaml b/llvm/test/tools/yaml2obj/ELF/symtab-shlink.yaml
index 116c2dad77d..116c2dad77d 100644
--- a/llvm/test/tools/yaml2obj/symtab-shlink.yaml
+++ b/llvm/test/tools/yaml2obj/ELF/symtab-shlink.yaml
diff --git a/llvm/test/tools/yaml2obj/elf-symtab-shtype.yaml b/llvm/test/tools/yaml2obj/ELF/symtab-shtype.yaml
index fff18607dca..fff18607dca 100644
--- a/llvm/test/tools/yaml2obj/elf-symtab-shtype.yaml
+++ b/llvm/test/tools/yaml2obj/ELF/symtab-shtype.yaml
diff --git a/llvm/test/tools/yaml2obj/verdef-section.yaml b/llvm/test/tools/yaml2obj/ELF/verdef-section.yaml
index f26e7d168e8..f6ddbf3d25d 100644
--- a/llvm/test/tools/yaml2obj/verdef-section.yaml
+++ b/llvm/test/tools/yaml2obj/ELF/verdef-section.yaml
@@ -1,8 +1,8 @@
+## Check we are able to handle SHT_GNU_verdef sections.
+
# RUN: yaml2obj %s -o %t
# RUN: llvm-readobj -V %t | FileCheck %s
-# Check we are able to handle the SHT_GNU_verdef sections.
-
# CHECK: VersionDefinitions [
# CHECK-NEXT: Definition {
# CHECK-NEXT: Version: 1
diff --git a/llvm/test/tools/yaml2obj/verneed-section.yaml b/llvm/test/tools/yaml2obj/ELF/verneed-section.yaml
index 9d7d722a9c2..e9dbe1c65fd 100644
--- a/llvm/test/tools/yaml2obj/verneed-section.yaml
+++ b/llvm/test/tools/yaml2obj/ELF/verneed-section.yaml
@@ -1,8 +1,8 @@
+## Check we are able to handle SHT_GNU_verneed sections.
+
# RUN: yaml2obj %s -o %t
# RUN: llvm-readobj -V %t | FileCheck %s
-# Check we are able to handle the SHT_GNU_verneed sections.
-
# CHECK: VersionRequirements [
# CHECK-NEXT: Dependency {
# CHECK-NEXT: Version: 1
diff --git a/llvm/test/tools/yaml2obj/versym-section.yaml b/llvm/test/tools/yaml2obj/ELF/versym-section.yaml
index 7c7c6513419..fa5f5c9a8b3 100644
--- a/llvm/test/tools/yaml2obj/versym-section.yaml
+++ b/llvm/test/tools/yaml2obj/ELF/versym-section.yaml
@@ -68,7 +68,7 @@ Sections:
Dependencies:
- Version: 1
File: dso.so.0
- Entries:
+ Entries:
- Name: v1
Hash: 1937
Flags: 0
diff --git a/llvm/test/tools/yaml2obj/minidump-exception-missing-parameter.yaml b/llvm/test/tools/yaml2obj/Minidump/exception-missing-parameter.yaml
index 1519f81734b..1519f81734b 100644
--- a/llvm/test/tools/yaml2obj/minidump-exception-missing-parameter.yaml
+++ b/llvm/test/tools/yaml2obj/Minidump/exception-missing-parameter.yaml
diff --git a/llvm/test/tools/yaml2obj/minidump-raw-stream-small-size.yaml b/llvm/test/tools/yaml2obj/Minidump/raw-stream-small-size.yaml
index bb7a4545347..bb7a4545347 100644
--- a/llvm/test/tools/yaml2obj/minidump-raw-stream-small-size.yaml
+++ b/llvm/test/tools/yaml2obj/Minidump/raw-stream-small-size.yaml
diff --git a/llvm/test/tools/yaml2obj/minidump-systeminfo-other-long.yaml b/llvm/test/tools/yaml2obj/Minidump/systeminfo-other-long.yaml
index 29d8efbd772..29d8efbd772 100644
--- a/llvm/test/tools/yaml2obj/minidump-systeminfo-other-long.yaml
+++ b/llvm/test/tools/yaml2obj/Minidump/systeminfo-other-long.yaml
diff --git a/llvm/test/tools/yaml2obj/minidump-systeminfo-other-not-hex.yaml b/llvm/test/tools/yaml2obj/Minidump/systeminfo-other-not-hex.yaml
index 17769570c5b..17769570c5b 100644
--- a/llvm/test/tools/yaml2obj/minidump-systeminfo-other-not-hex.yaml
+++ b/llvm/test/tools/yaml2obj/Minidump/systeminfo-other-not-hex.yaml
diff --git a/llvm/test/tools/yaml2obj/minidump-systeminfo-other-short.yaml b/llvm/test/tools/yaml2obj/Minidump/systeminfo-other-short.yaml
index 367941b1305..367941b1305 100644
--- a/llvm/test/tools/yaml2obj/minidump-systeminfo-other-short.yaml
+++ b/llvm/test/tools/yaml2obj/Minidump/systeminfo-other-short.yaml
diff --git a/llvm/test/tools/yaml2obj/minidump-systeminfo-x86-long.yaml b/llvm/test/tools/yaml2obj/Minidump/systeminfo-x86-long.yaml
index 7083743fdf0..7083743fdf0 100644
--- a/llvm/test/tools/yaml2obj/minidump-systeminfo-x86-long.yaml
+++ b/llvm/test/tools/yaml2obj/Minidump/systeminfo-x86-long.yaml
diff --git a/llvm/test/tools/yaml2obj/minidump-systeminfo-x86-short.yaml b/llvm/test/tools/yaml2obj/Minidump/systeminfo-x86-short.yaml
index 6c86288387c..6c86288387c 100644
--- a/llvm/test/tools/yaml2obj/minidump-systeminfo-x86-short.yaml
+++ b/llvm/test/tools/yaml2obj/Minidump/systeminfo-x86-short.yaml
diff --git a/llvm/test/tools/yaml2obj/empty-symbols.yaml b/llvm/test/tools/yaml2obj/empty-symbols.yaml
deleted file mode 100644
index 1ba37add3c0..00000000000
--- a/llvm/test/tools/yaml2obj/empty-symbols.yaml
+++ /dev/null
@@ -1,10 +0,0 @@
-# Ensure yaml2obj doesn't error on empty optional mappings, such as Symbols
-# RUN: yaml2obj %s -o %t
-
-!ELF
-FileHeader:
- Class: ELFCLASS64
- Data: ELFDATA2LSB
- Type: ET_DYN
- Machine: EM_X86_64
-Symbols:
diff --git a/llvm/test/tools/yaml2obj/invalid_output_file.test b/llvm/test/tools/yaml2obj/invalid-output-file.yaml
index 1124b49d18c..7b76fe1c1a0 100644
--- a/llvm/test/tools/yaml2obj/invalid_output_file.test
+++ b/llvm/test/tools/yaml2obj/invalid-output-file.yaml
@@ -1,4 +1,4 @@
# RUN: not yaml2obj -o %p/path/does/not/exist 2>&1 | FileCheck %s
-# Don't check the OS-dependent message "No such file or directory".
+## Don't check the OS-dependent message "No such file or directory".
# CHECK: yaml2obj: error: failed to open '{{.*}}/path/does/not/exist': {{.*}}
diff --git a/llvm/test/tools/yaml2obj/multi-doc.test b/llvm/test/tools/yaml2obj/multi-doc.yaml
index 327d625bfb3..327d625bfb3 100644
--- a/llvm/test/tools/yaml2obj/multi-doc.test
+++ b/llvm/test/tools/yaml2obj/multi-doc.yaml
diff --git a/llvm/test/tools/yaml2obj/symboless-relocation.yaml b/llvm/test/tools/yaml2obj/symboless-relocation.yaml
deleted file mode 100644
index 680e03e5c14..00000000000
--- a/llvm/test/tools/yaml2obj/symboless-relocation.yaml
+++ /dev/null
@@ -1,20 +0,0 @@
-# Just make sure this isn't an error even though it has no Symbol
-# RUN: yaml2obj %s
-
-!ELF
-FileHeader:
- Class: ELFCLASS64
- Data: ELFDATA2LSB
- Type: ET_EXEC
- Machine: EM_X86_64
-Sections:
- - Name: .text
- Type: SHT_PROGBITS
- Flags: [ SHF_ALLOC, SHF_EXECINSTR ]
- Content: "00000000"
- - Name: .rel.text
- Type: SHT_REL
- Info: .text
- Relocations:
- - Offset: 0x1000
- Type: R_X86_64_RELATIVE
OpenPOWER on IntegriCloud