diff options
author | Artem Dergachev <artem.dergachev@gmail.com> | 2016-10-05 08:47:31 +0000 |
---|---|---|
committer | Artem Dergachev <artem.dergachev@gmail.com> | 2016-10-05 08:47:31 +0000 |
commit | 602e625622c1da7510c65b1d2744e8f20504d435 (patch) | |
tree | a300fc3e73085fa90cd1d291230b6cc3f824d51c | |
parent | 9cb5614c29ec4e53191af3ec0f212a66f9dfd788 (diff) | |
download | bcm5719-llvm-602e625622c1da7510c65b1d2744e8f20504d435.tar.gz bcm5719-llvm-602e625622c1da7510c65b1d2744e8f20504d435.zip |
[analyzer] Squash a compile error in r283301.
The constexpr string literal trick isn't supported in MSVC2013.
llvm-svn: 283303
-rw-r--r-- | clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporterVisitor.h | 7 | ||||
-rw-r--r-- | clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp | 5 |
2 files changed, 8 insertions, 4 deletions
diff --git a/clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporterVisitor.h b/clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporterVisitor.h index c2982a70799..fdff74792f5 100644 --- a/clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporterVisitor.h +++ b/clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporterVisitor.h @@ -186,10 +186,9 @@ public: class ConditionBRVisitor final : public BugReporterVisitorImpl<ConditionBRVisitor> { - static constexpr const char *const GenericTrueMessage = - "Assuming the condition is true"; - static constexpr const char *const GenericFalseMessage = - "Assuming the condition is false"; + // FIXME: constexpr initialization isn't supported by MSVC2013. + static const char *const GenericTrueMessage; + static const char *const GenericFalseMessage; public: void Profile(llvm::FoldingSetNodeID &ID) const override { diff --git a/clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp b/clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp index 08f636df7f9..7045d8bb94c 100644 --- a/clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp +++ b/clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp @@ -1603,6 +1603,11 @@ ConditionBRVisitor::VisitTrueTest(const Expr *Cond, return event; } +const char *const ConditionBRVisitor::GenericTrueMessage = + "Assuming the condition is true"; +const char *const ConditionBRVisitor::GenericFalseMessage = + "Assuming the condition is false"; + bool ConditionBRVisitor::isPieceMessageGeneric( const PathDiagnosticPiece *Piece) { return Piece->getString() == GenericTrueMessage || |