summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorBrian Gesiak <modocache@gmail.com>2017-07-26 15:02:05 +0000
committerBrian Gesiak <modocache@gmail.com>2017-07-26 15:02:05 +0000
commit5e7c089b8afea6bc934d6408f0ccb6b02d4c1c76 (patch)
tree574bd66ca7ac8ff408734a113a823a05dde9a651
parente90d0153ca51bcb5f131dd7c93abae6f2399f5c5 (diff)
downloadbcm5719-llvm-5e7c089b8afea6bc934d6408f0ccb6b02d4c1c76.tar.gz
bcm5719-llvm-5e7c089b8afea6bc934d6408f0ccb6b02d4c1c76.zip
[lit] Fix type error for parallelism groups
Summary: Whereas rL299560 and rL309071 call `parallelism_groups.items()`, under the assumption that `parallelism_groups` is a `dict` type, the default parameter for that attribute is a `list`. Change the default to a `dict` for type correctness. This regression in the unit tests would have been caught if the unit tests were being run continously. It also would have been caught if the lit project used a Python type checker such as `mypy`. Test Plan: As per the instructions in `utils/lit/README.txt`, run the lit unit test suite: ``` utils/lit/lit.py \ --path /path/to/your/llvm/build/bin \ utils/lit/tests ``` Verify that the test `lit :: unit/TestRunner.py` fails before applying this patch, but passes once this patch is applied. Reviewers: mgorny, rnk, rafael Reviewed By: mgorny Subscribers: llvm-commits Differential Revision: https://reviews.llvm.org/D35878 llvm-svn: 309122
-rw-r--r--llvm/utils/lit/lit/LitConfig.py2
1 files changed, 1 insertions, 1 deletions
diff --git a/llvm/utils/lit/lit/LitConfig.py b/llvm/utils/lit/lit/LitConfig.py
index 2ef0a8f77ec..3351ebed54b 100644
--- a/llvm/utils/lit/lit/LitConfig.py
+++ b/llvm/utils/lit/lit/LitConfig.py
@@ -25,7 +25,7 @@ class LitConfig(object):
params, config_prefix = None,
maxIndividualTestTime = 0,
maxFailures = None,
- parallelism_groups = [],
+ parallelism_groups = {},
echo_all_commands = False):
# The name of the test runner.
self.progname = progname
OpenPOWER on IntegriCloud