diff options
| author | George Rimar <grimar@accesssoftek.com> | 2019-06-05 15:29:50 +0000 |
|---|---|---|
| committer | George Rimar <grimar@accesssoftek.com> | 2019-06-05 15:29:50 +0000 |
| commit | 5da702308c520c3c3e037c21a05a8e5f8d36b85c (patch) | |
| tree | d0b2b636f0e05054fca89c88b40decd76e149e50 | |
| parent | 15c657d13d6f12ec4f9c77af8c5034caca9ba7d7 (diff) | |
| download | bcm5719-llvm-5da702308c520c3c3e037c21a05a8e5f8d36b85c.tar.gz bcm5719-llvm-5da702308c520c3c3e037c21a05a8e5f8d36b85c.zip | |
[llvm-readobj] - Remove TODOs from gnu-hash-symbols.test and demangle.test test cases.
We can remove this TODOs now.
Differential revision: https://reviews.llvm.org/D62846
llvm-svn: 362614
| -rw-r--r-- | llvm/test/tools/llvm-readobj/demangle.test | 14 | ||||
| -rw-r--r-- | llvm/test/tools/llvm-readobj/gnu-hash-symbols.test | 14 |
2 files changed, 6 insertions, 22 deletions
diff --git a/llvm/test/tools/llvm-readobj/demangle.test b/llvm/test/tools/llvm-readobj/demangle.test index fb6c64b8e9a..a1a881e6436 100644 --- a/llvm/test/tools/llvm-readobj/demangle.test +++ b/llvm/test/tools/llvm-readobj/demangle.test @@ -117,18 +117,11 @@ FileHeader: Type: ET_DYN Machine: EM_X86_64 Sections: - ## TODO: Replace the raw section contents with more meaningful dynamic - ## tags/symbols/etc, once yaml2obj supports it. - ## FIXME: yaml2obj does not currently allow custom addresses for .dynstr and - ## .dynsym if DynamicSymbols are specified. - ## See https://bugs.llvm.org/show_bug.cgi?id=40339 - Name: .dynstr Type: SHT_STRTAB Flags: [ SHF_ALLOC ] AddressAlign: 0x100 EntSize: 0x1 - ## "\0_Z3fooi\0" - Content: "005f5a33666f6f6900" - Name: .dynsym Type: SHT_DYNSYM Flags: [ SHF_ALLOC ] @@ -136,10 +129,6 @@ Sections: Address: 0x100 AddressAlign: 0x100 EntSize: 0x18 - ## Null symbol; - ## st_name: 1; st_info: Global | Func; st_other: 0; - ## st_shndx: .text.foo; st_value: 0x2000; st_size: 0 - Content: "000000000000000000000000000000000000000000000000010000001200050000200000000000000000000000000000" - Name: .rela.dyn Type: SHT_RELA Flags: [ SHF_ALLOC ] @@ -218,6 +207,9 @@ Symbols: Type: STT_FUNC Section: .text.foo Binding: STB_GLOBAL +DynamicSymbols: + - Name: _Z3fooi + Binding: STB_GLOBAL ProgramHeaders: - Type: PT_LOAD Flags: [ PF_R, PF_X ] diff --git a/llvm/test/tools/llvm-readobj/gnu-hash-symbols.test b/llvm/test/tools/llvm-readobj/gnu-hash-symbols.test index 8babac599c3..151ec23d1ec 100644 --- a/llvm/test/tools/llvm-readobj/gnu-hash-symbols.test +++ b/llvm/test/tools/llvm-readobj/gnu-hash-symbols.test @@ -47,18 +47,11 @@ FileHeader: Type: ET_DYN Machine: EM_X86_64 Sections: - ## TODO: Replace the raw section contents with more meaningful dynamic - ## tags/symbols/etc, once yaml2obj supports it. - ## FIXME: yaml2obj does not currently allow custom addresses for .dynstr and - ## .dynsym if DynamicSymbols are specified. - ## See https://bugs.llvm.org/show_bug.cgi?id=40339 - Name: .dynstr Type: SHT_STRTAB Flags: [ SHF_ALLOC ] AddressAlign: 0x100 EntSize: 0x1 - ## "\0_Z3fooi\0" - Content: "005f5a33666f6f6900" - Name: .dynsym Type: SHT_DYNSYM Flags: [ SHF_ALLOC ] @@ -66,10 +59,6 @@ Sections: Address: 0x100 AddressAlign: 0x100 EntSize: 0x18 - ## Null symbol; - ## st_name: 1; st_info: Global | Func; st_other: 0; - ## st_shndx: .text.foo; st_value: 0x2000; st_size: 0 - Content: "000000000000000000000000000000000000000000000000010000001200040000200000000000000000000000000000" - Name: .dynamic Type: SHT_DYNAMIC Flags: [ SHF_ALLOC ] @@ -94,6 +83,9 @@ Sections: Size: 0x40 Address: 0x2000 AddressAlign: 0x2000 +DynamicSymbols: + - Name: _Z3fooi + Binding: STB_GLOBAL ProgramHeaders: - Type: PT_LOAD Flags: [ PF_R, PF_X ] |
