summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorCraig Topper <craig.topper@intel.com>2018-10-25 17:28:57 +0000
committerCraig Topper <craig.topper@intel.com>2018-10-25 17:28:57 +0000
commit5d787ac4becc12659c0dbf50c2cbb54e17e738d2 (patch)
treec52264dde8193a87f309c0bea068afda07302591
parent511c7d0cbe679b176a50ebe41624d588f38f9b57 (diff)
downloadbcm5719-llvm-5d787ac4becc12659c0dbf50c2cbb54e17e738d2.tar.gz
bcm5719-llvm-5d787ac4becc12659c0dbf50c2cbb54e17e738d2.zip
[X86] Remove some uarch tuning flags from KNL that look to have been inherited from SNB/IVB incorrectly
KNL is based on a modified Silvermont core so I don't think these features apply. I think the LEA flag is probably also wrong, but I'm less sure as I barely understand the 3 LEA flags we have currently. Differential Revision: https://reviews.llvm.org/D53671 llvm-svn: 345285
-rw-r--r--llvm/lib/Target/X86/X86.td4
-rw-r--r--llvm/test/CodeGen/X86/avx512-select.ll4
2 files changed, 2 insertions, 6 deletions
diff --git a/llvm/lib/Target/X86/X86.td b/llvm/lib/Target/X86/X86.td
index 9a12a7237e4..100e192f181 100644
--- a/llvm/lib/Target/X86/X86.td
+++ b/llvm/lib/Target/X86/X86.td
@@ -823,11 +823,7 @@ def KNLFeatures : ProcessorFeatures<[], [
FeatureXSAVEOPT,
FeatureLAHFSAHF,
FeatureSlow3OpsLEA,
- FeatureFastScalarFSQRT,
- FeatureFastSHLDRotate,
FeatureSlowIncDec,
- FeatureMergeToThreeWayBranch,
- FeatureMacroFusion,
FeatureRDRAND,
FeatureF16C,
FeatureFSGSBase,
diff --git a/llvm/test/CodeGen/X86/avx512-select.ll b/llvm/test/CodeGen/X86/avx512-select.ll
index 2ad2251bc1a..008a3b44ce0 100644
--- a/llvm/test/CodeGen/X86/avx512-select.ll
+++ b/llvm/test/CodeGen/X86/avx512-select.ll
@@ -16,8 +16,8 @@ define <16 x i32> @select00(i32 %a, <16 x i32> %b) nounwind {
;
; X64-LABEL: select00:
; X64: # %bb.0:
-; X64-NEXT: vpxor %xmm1, %xmm1, %xmm1
; X64-NEXT: cmpl $255, %edi
+; X64-NEXT: vpxor %xmm1, %xmm1, %xmm1
; X64-NEXT: je .LBB0_2
; X64-NEXT: # %bb.1:
; X64-NEXT: vmovdqa64 %zmm0, %zmm1
@@ -44,8 +44,8 @@ define <8 x i64> @select01(i32 %a, <8 x i64> %b) nounwind {
;
; X64-LABEL: select01:
; X64: # %bb.0:
-; X64-NEXT: vpxor %xmm1, %xmm1, %xmm1
; X64-NEXT: cmpl $255, %edi
+; X64-NEXT: vpxor %xmm1, %xmm1, %xmm1
; X64-NEXT: je .LBB1_2
; X64-NEXT: # %bb.1:
; X64-NEXT: vmovdqa64 %zmm0, %zmm1
OpenPOWER on IntegriCloud