summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDouglas Gregor <dgregor@apple.com>2011-04-15 20:45:44 +0000
committerDouglas Gregor <dgregor@apple.com>2011-04-15 20:45:44 +0000
commit5d3d3fa33d44a2964b746cc0b8c286a5438ce6c8 (patch)
treef8c52913a807ced179da208ee9b551bd97a27665
parent0829b3065ad3144e6bf489bc9b3ff68eb1a0c65a (diff)
downloadbcm5719-llvm-5d3d3fa33d44a2964b746cc0b8c286a5438ce6c8.tar.gz
bcm5719-llvm-5d3d3fa33d44a2964b746cc0b8c286a5438ce6c8.zip
For the purposes of overload resolution, consider a conversion from an
Objective-C pointer to void* as a "conversion to void*". This allows us to prefer an Objective-C object pointer conversion to a superclass object pointer over an Objective-C object pointer conversion to cv-void*. Fixes PR9735. llvm-svn: 129603
-rw-r--r--clang/lib/Sema/SemaOverload.cpp2
-rw-r--r--clang/test/SemaObjCXX/overload.mm10
2 files changed, 11 insertions, 1 deletions
diff --git a/clang/lib/Sema/SemaOverload.cpp b/clang/lib/Sema/SemaOverload.cpp
index 57338f255ce..9caf6736017 100644
--- a/clang/lib/Sema/SemaOverload.cpp
+++ b/clang/lib/Sema/SemaOverload.cpp
@@ -240,7 +240,7 @@ isPointerConversionToVoidPointer(ASTContext& Context) const {
if (First == ICK_Array_To_Pointer)
FromType = Context.getArrayDecayedType(FromType);
- if (Second == ICK_Pointer_Conversion && FromType->isPointerType())
+ if (Second == ICK_Pointer_Conversion && FromType->isAnyPointerType())
if (const PointerType* ToPtrType = ToType->getAs<PointerType>())
return ToPtrType->getPointeeType()->isVoidType();
diff --git a/clang/test/SemaObjCXX/overload.mm b/clang/test/SemaObjCXX/overload.mm
index a40248e6cd2..09cd3ec45cd 100644
--- a/clang/test/SemaObjCXX/overload.mm
+++ b/clang/test/SemaObjCXX/overload.mm
@@ -149,3 +149,13 @@ namespace rdar8734046 {
f2(a);
}
}
+
+namespace PR9735 {
+ int &f3(const A*);
+ float &f3(const void*);
+
+ void test_f(B* b, const B* bc) {
+ int &ir1 = f3(b);
+ int &ir2 = f3(bc);
+ }
+}
OpenPOWER on IntegriCloud