diff options
| author | Eric Fiselier <eric@efcs.ca> | 2014-08-16 02:16:25 +0000 |
|---|---|---|
| committer | Eric Fiselier <eric@efcs.ca> | 2014-08-16 02:16:25 +0000 |
| commit | 5ccd9e029f2b57028913cf087c49fd529f8e8e52 (patch) | |
| tree | 5e37076bd4b98bc799f1a545c26f38f0e0f9acf4 | |
| parent | 12be8efc62de97adfe638d14bc50f6b6a7911873 (diff) | |
| download | bcm5719-llvm-5ccd9e029f2b57028913cf087c49fd529f8e8e52.tar.gz bcm5719-llvm-5ccd9e029f2b57028913cf087c49fd529f8e8e52.zip | |
[LIT] Move display of unsupported and xfail tests to summary.
Summary:
This patch changes the way xfail and unsupported tests are displayed.
This output is only displayed when the --show-unsupported/--show-xfail flags are passed to lit.
Currently xfail/unsupported tests are printed during the run of the test-suite. I think its better to display this information during the summary instead.
This patch removes the printing of these tests from when they are run to the summary.
Reviewers: ddunbar, EricWF
Reviewed By: EricWF
Subscribers: llvm-commits
Differential Revision: http://reviews.llvm.org/D4842
llvm-svn: 215809
| -rwxr-xr-x | llvm/utils/lit/lit/main.py | 11 |
1 files changed, 7 insertions, 4 deletions
diff --git a/llvm/utils/lit/lit/main.py b/llvm/utils/lit/lit/main.py index 2ec14e5e5df..7343d242cba 100755 --- a/llvm/utils/lit/lit/main.py +++ b/llvm/utils/lit/lit/main.py @@ -43,8 +43,6 @@ class TestingProgressDisplay(object): test.getFullName()) shouldShow = test.result.code.isFailure or \ - (self.opts.show_unsupported and test.result.code.name == 'UNSUPPORTED') or \ - (self.opts.show_xfail and test.result.code.name == 'XFAIL') or \ (not self.opts.quiet and not self.opts.succinct) if not shouldShow: return @@ -391,7 +389,12 @@ def main(builtinParameters = {}): # Print each test in any of the failing groups. for title,code in (('Unexpected Passing Tests', lit.Test.XPASS), ('Failing Tests', lit.Test.FAIL), - ('Unresolved Tests', lit.Test.UNRESOLVED)): + ('Unresolved Tests', lit.Test.UNRESOLVED), + ('Unsupported Tests', lit.Test.UNSUPPORTED), + ('Expected Failing Tests', lit.Test.XFAIL)): + if (lit.Test.XFAIL == code and not opts.show_xfail) or \ + (lit.Test.UNSUPPORTED == code and not opts.show_unsupported): + continue elts = byCode.get(code) if not elts: continue @@ -412,7 +415,7 @@ def main(builtinParameters = {}): ('Unsupported Tests ', lit.Test.UNSUPPORTED), ('Unresolved Tests ', lit.Test.UNRESOLVED), ('Unexpected Passes ', lit.Test.XPASS), - ('Unexpected Failures', lit.Test.FAIL),): + ('Unexpected Failures', lit.Test.FAIL)): if opts.quiet and not code.isFailure: continue N = len(byCode.get(code,[])) |

