summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRafael Espindola <rafael.espindola@gmail.com>2012-12-30 17:23:09 +0000
committerRafael Espindola <rafael.espindola@gmail.com>2012-12-30 17:23:09 +0000
commit5cab029e4b74f866bf706f5c0fd5fe18dd550d5e (patch)
tree9f6176d22d4bf031715d6bbc223cd5656cb631d2
parentb6ad98224a0f3efbc5a4b2f591e8ca2ba081a8dc (diff)
downloadbcm5719-llvm-5cab029e4b74f866bf706f5c0fd5fe18dd550d5e.tar.gz
bcm5719-llvm-5cab029e4b74f866bf706f5c0fd5fe18dd550d5e.zip
Don't get confused if a extern "C" builtin function is redeclared without
the extern "C". llvm-svn: 171260
-rw-r--r--clang/lib/AST/Decl.cpp2
-rw-r--r--clang/test/SemaCXX/warn-bad-memaccess.cpp5
2 files changed, 6 insertions, 1 deletions
diff --git a/clang/lib/AST/Decl.cpp b/clang/lib/AST/Decl.cpp
index 92b1e4abf2e..2d34e4c335f 100644
--- a/clang/lib/AST/Decl.cpp
+++ b/clang/lib/AST/Decl.cpp
@@ -2440,7 +2440,7 @@ unsigned FunctionDecl::getMemoryFunctionKind() const {
return Builtin::BIstrlen;
default:
- if (isExternC()) {
+ if (hasCLanguageLinkage()) {
if (FnInfo->isStr("memset"))
return Builtin::BImemset;
else if (FnInfo->isStr("memcpy"))
diff --git a/clang/test/SemaCXX/warn-bad-memaccess.cpp b/clang/test/SemaCXX/warn-bad-memaccess.cpp
index 3a02c84e9fc..7a7459acee1 100644
--- a/clang/test/SemaCXX/warn-bad-memaccess.cpp
+++ b/clang/test/SemaCXX/warn-bad-memaccess.cpp
@@ -5,6 +5,11 @@ extern "C" void *memmove(void *s1, const void *s2, unsigned n);
extern "C" void *memcpy(void *s1, const void *s2, unsigned n);
extern "C" void *memcmp(void *s1, const void *s2, unsigned n);
+
+// Redeclare without the extern "C" to test that we still figure out that this
+// is the "real" memset.
+void *memset(void *, int, unsigned);
+
// Several types that should not warn.
struct S1 {} s1;
struct S2 { int x; } s2;
OpenPOWER on IntegriCloud