diff options
author | Jack Carter <jcarter@mips.com> | 2012-10-03 21:58:54 +0000 |
---|---|---|
committer | Jack Carter <jcarter@mips.com> | 2012-10-03 21:58:54 +0000 |
commit | 5b5559d3f306d564d3d57394cb70a69d679649ab (patch) | |
tree | 429b45afa64f4090fe87da62475a253f3f0ddc58 | |
parent | 05c82a42dd501cbcc9f0872635bc252133f9227c (diff) | |
download | bcm5719-llvm-5b5559d3f306d564d3d57394cb70a69d679649ab.tar.gz bcm5719-llvm-5b5559d3f306d564d3d57394cb70a69d679649ab.zip |
This patch moves from using a hard coded number (4)
for the number of bytes in a particular instruction
to using
const MCInstrDesc &Desc = MCII.get(TmpInst.getOpcode());
Desc.getSize()
This is necessary with the advent of 16 bit instructions with
mips16 and micromips. It is also puts Mips in compliance with
the other targets for getting instruction size.
llvm-svn: 165171
-rw-r--r-- | llvm/lib/Target/Mips/MCTargetDesc/MipsMCCodeEmitter.cpp | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/llvm/lib/Target/Mips/MCTargetDesc/MipsMCCodeEmitter.cpp b/llvm/lib/Target/Mips/MCTargetDesc/MipsMCCodeEmitter.cpp index 06882e138c0..7fbdae02f41 100644 --- a/llvm/lib/Target/Mips/MCTargetDesc/MipsMCCodeEmitter.cpp +++ b/llvm/lib/Target/Mips/MCTargetDesc/MipsMCCodeEmitter.cpp @@ -146,8 +146,10 @@ EncodeInstruction(const MCInst &MI, raw_ostream &OS, if ((TSFlags & MipsII::FormMask) == MipsII::Pseudo) llvm_unreachable("Pseudo opcode found in EncodeInstruction()"); - // For now all instructions are 4 bytes - int Size = 4; // FIXME: Have Desc.getSize() return the correct value! + // Get byte count of instruction + unsigned Size = Desc.getSize(); + if (!Size) + llvm_unreachable("Desc.getSize() returns 0"); EmitInstruction(Binary, Size, OS); } |