diff options
| author | Evan Cheng <evan.cheng@apple.com> | 2007-06-04 18:54:57 +0000 |
|---|---|---|
| committer | Evan Cheng <evan.cheng@apple.com> | 2007-06-04 18:54:57 +0000 |
| commit | 59ca6a846f9c130ed44010e78bb539b9a2095490 (patch) | |
| tree | 83f268112a83d4e803c7e9c4cae48e294e6b826b | |
| parent | 38b6b22a4145e8e46314f90d6a014fbb7835ec14 (diff) | |
| download | bcm5719-llvm-59ca6a846f9c130ed44010e78bb539b9a2095490.tar.gz bcm5719-llvm-59ca6a846f9c130ed44010e78bb539b9a2095490.zip | |
Misuse of hasExternalLinkage(), should be checking isDeclaration().
llvm-svn: 37419
| -rwxr-xr-x | llvm/lib/Target/X86/X86ATTAsmPrinter.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/llvm/lib/Target/X86/X86ATTAsmPrinter.cpp b/llvm/lib/Target/X86/X86ATTAsmPrinter.cpp index 17de0530078..e3bb967f2a5 100755 --- a/llvm/lib/Target/X86/X86ATTAsmPrinter.cpp +++ b/llvm/lib/Target/X86/X86ATTAsmPrinter.cpp @@ -286,7 +286,7 @@ void X86ATTAsmPrinter::printOperand(const MachineInstr *MI, unsigned OpNo, } if (printStub(TM, Subtarget)) { - // Link-once, External, or Weakly-linked global variables need + // Link-once, declaration, or Weakly-linked global variables need // non-lazily-resolved stubs if (GV->isDeclaration() || GV->hasWeakLinkage() || @@ -351,7 +351,7 @@ void X86ATTAsmPrinter::printOperand(const MachineInstr *MI, unsigned OpNo, else O << "@GOTOFF"; } else if (Subtarget->isPICStyleRIPRel() && !NotRIPRel) { - if ((GV->hasExternalLinkage() || + if ((GV->isDeclaration() || GV->hasWeakLinkage() || GV->hasLinkOnceLinkage()) && TM.getRelocationModel() != Reloc::Static) |
