diff options
author | Mark Searles <m.c.searles@gmail.com> | 2019-02-21 18:19:54 +0000 |
---|---|---|
committer | Mark Searles <m.c.searles@gmail.com> | 2019-02-21 18:19:54 +0000 |
commit | 599ce44d3f3917a3c53cd4bf0bd151e1fce00ed1 (patch) | |
tree | 1b17d810d46e5b4cb9331e81bf1a59140d716629 | |
parent | 93ad8b3aa5669834789f839f3dd04880b87e4080 (diff) | |
download | bcm5719-llvm-599ce44d3f3917a3c53cd4bf0bd151e1fce00ed1.tar.gz bcm5719-llvm-599ce44d3f3917a3c53cd4bf0bd151e1fce00ed1.zip |
[AMDGPU] remove unused AssemblerPredicates
An internal build is hitting asserts complaining about too many subtarget
features:
llvm/utils/TableGen/Types.cpp:42:
const char* llvm::getMinimalTypeForEnumBitfield(uint64_t):
Assertion `MaxIndex <= 64 && "Too many bits"' failed.
llvm/utils/TableGen/AsmMatcherEmitter.cpp:1476:
void {anonymous}::AsmMatcherInfo::buildInfo():
Assertion `SubtargetFeatures.size() <= 64 && "Too many subtarget features!"'
failed.
The short-term solution is to remove a few unused AssemblerPredicates to get
under the limit.
The long-term solution seems to be to revisit these asserts. E.g., rather than
hardcoded '64', use the standard sized std::bitset like the other places that
track subtarget features.
Differential Revision: https://reviews.llvm.org/D58516
llvm-svn: 354604
-rw-r--r-- | llvm/lib/Target/AMDGPU/AMDGPU.td | 6 |
1 files changed, 1 insertions, 5 deletions
diff --git a/llvm/lib/Target/AMDGPU/AMDGPU.td b/llvm/lib/Target/AMDGPU/AMDGPU.td index 0b0c125e73f..828bf841f04 100644 --- a/llvm/lib/Target/AMDGPU/AMDGPU.td +++ b/llvm/lib/Target/AMDGPU/AMDGPU.td @@ -721,17 +721,13 @@ def HasDSAddTid : Predicate<"Subtarget->getGeneration() >= AMDGPUSubtarget::GFX9 def HasAddNoCarryInsts : Predicate<"Subtarget->hasAddNoCarry()">, AssemblerPredicate<"FeatureAddNoCarryInsts">; -def NotHasAddNoCarryInsts : Predicate<"!Subtarget->hasAddNoCarry()">, - AssemblerPredicate<"!FeatureAddNoCarryInsts">; +def NotHasAddNoCarryInsts : Predicate<"!Subtarget->hasAddNoCarry()">; def Has16BitInsts : Predicate<"Subtarget->has16BitInsts()">, AssemblerPredicate<"Feature16BitInsts">; def HasVOP3PInsts : Predicate<"Subtarget->hasVOP3PInsts()">, AssemblerPredicate<"FeatureVOP3P">; -def NotHasVOP3PInsts : Predicate<"!Subtarget->hasVOP3PInsts()">, - AssemblerPredicate<"!FeatureVOP3P">; - def HasSDWA : Predicate<"Subtarget->hasSDWA()">, AssemblerPredicate<"FeatureSDWA,FeatureVolcanicIslands">; |