diff options
| author | Enrico Granata <egranata@apple.com> | 2014-08-26 21:35:30 +0000 |
|---|---|---|
| committer | Enrico Granata <egranata@apple.com> | 2014-08-26 21:35:30 +0000 |
| commit | 59953f0dbea2678f1ad59ac75c871a888e3a9875 (patch) | |
| tree | a47c6fdf6b387c3917aa36a8591548480c56b601 | |
| parent | ca7b0aaa367f25ed00be3eb9d07fb359b499114f (diff) | |
| download | bcm5719-llvm-59953f0dbea2678f1ad59ac75c871a888e3a9875.tar.gz bcm5719-llvm-59953f0dbea2678f1ad59ac75c871a888e3a9875.zip | |
It was pointed out to me that an offset of 0 makes sense for ObjC, but not always for C++, and this API claims to be general enough that it should not drop C++ usability on the floor for no good reason. Fix it with an explicit offset argument
llvm-svn: 216487
| -rw-r--r-- | lldb/include/lldb/Core/ValueObject.h | 4 | ||||
| -rw-r--r-- | lldb/source/Core/ValueObject.cpp | 3 |
2 files changed, 3 insertions, 4 deletions
diff --git a/lldb/include/lldb/Core/ValueObject.h b/lldb/include/lldb/Core/ValueObject.h index 029139c6027..6a08ec6507f 100644 --- a/lldb/include/lldb/Core/ValueObject.h +++ b/lldb/include/lldb/Core/ValueObject.h @@ -677,8 +677,8 @@ public: GetSyntheticChildAtOffset(uint32_t offset, const ClangASTType& type, bool can_create); virtual lldb::ValueObjectSP - GetSyntheticBase (const ClangASTType& type, bool can_create); - + GetSyntheticBase (uint32_t offset, const ClangASTType& type, bool can_create); + virtual lldb::ValueObjectSP GetDynamicValue (lldb::DynamicValueType valueType); diff --git a/lldb/source/Core/ValueObject.cpp b/lldb/source/Core/ValueObject.cpp index a9d00702a02..1819e834536 100644 --- a/lldb/source/Core/ValueObject.cpp +++ b/lldb/source/Core/ValueObject.cpp @@ -2216,7 +2216,7 @@ ValueObject::GetSyntheticChildAtOffset(uint32_t offset, const ClangASTType& type } ValueObjectSP -ValueObject::GetSyntheticBase (const ClangASTType& type, bool can_create) +ValueObject::GetSyntheticBase (uint32_t offset, const ClangASTType& type, bool can_create) { ValueObjectSP synthetic_child_sp; @@ -2234,7 +2234,6 @@ ValueObject::GetSyntheticBase (const ClangASTType& type, bool can_create) if (!can_create) return ValueObjectSP(); - const uint32_t offset = 0; const bool is_base_class = true; ValueObjectChild *synthetic_child = new ValueObjectChild(*this, |
